Page MenuHomePhabricator
Create Task
Maniphest T199841

[Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the bottom of the dialog for a split second while editing an image
Closed, ResolvedPublic
Actions

Description

Steps to replicate:

  1. Click on the "Edit" button on any image

All kinds of buttons from different panels of Media Settings dialog is appearing at the bottom of the dialog for a split second while editing an image

Here is a screenshot from a video capture:

Screen Shot 2018-07-17 at 2.03.48 PM.png (623×633 px, 118 KB)

Details

SubjectRepoBranchLines +/-
ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcessmediawiki/extensions/VisualEditorwmf/1.32.0-wmf.13+16 -11
ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcessmediawiki/extensions/VisualEditormaster+16 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Jul 17 2018, 9:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2018, 9:07 PM
Ryasmeen added a comment.EditedJul 17 2018, 11:20 PM

Happens on the media search panel too, while inserting an image.

Ryasmeen mentioned this in T185944: OOUI window ready process runs before window is actually ready (Category drop down list gets sticky when it's open while closing the dialog).Jul 17 2018, 11:42 PM
matmarex edited projects, added VisualEditor-Media, VisualEditor (Current work); removed VisualEditor.Jul 18 2018, 12:46 AM
gerritbot subscribed.Jul 18 2018, 12:46 AM

Change 446516 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess

https://gerrit.wikimedia.org/r/446516

gerritbot added a project: Patch-For-Review.Jul 18 2018, 12:46 AM
Ryasmeen renamed this task from [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog is appearing at the bottom of the dialog for a split second while editing an image to [Regression wmf.13] All kinds of buttons from different panels of Media Settings dialog are appearing at the bottom of the dialog for a split second while editing an image .Jul 18 2018, 3:28 AM
Jdforrester-WMF assigned this task to matmarex.Jul 18 2018, 4:32 AM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Regression; removed Patch-For-Review.
gerritbot added a comment.Jul 18 2018, 4:51 AM

Change 446516 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess

https://gerrit.wikimedia.org/r/446516

gerritbot added a comment.Jul 18 2018, 6:01 AM

Change 446529 had a related patch set uploaded (by Jforrester; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.13] ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess

https://gerrit.wikimedia.org/r/446529

gerritbot added a project: Patch-For-Review.Jul 18 2018, 6:01 AM
• Deskana triaged this task as High priority.Jul 18 2018, 12:09 PM
Ryasmeen added a project: Verified.Jul 18 2018, 8:43 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
gerritbot added a comment.Jul 18 2018, 11:26 PM

Change 446529 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@wmf/1.32.0-wmf.13] ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess

https://gerrit.wikimedia.org/r/446529

Stashbot subscribed.Jul 18 2018, 11:33 PM

Mentioned in SAL (#wikimedia-operations) [2018-07-18T23:33:02Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.13/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWMediaDialog.js: SWAT: [[gerrit:446529|ve.ui.MWMediaDialog: Fix confusion between #getSetupProcess and #getReadyProcess]] T185944 T199841 (duration: 00m 56s)

matmarex added a subtask: T185944: OOUI window ready process runs before window is actually ready (Category drop down list gets sticky when it's open while closing the dialog).Jul 18 2018, 11:47 PM
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)); removed MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)).Jul 19 2018, 12:01 AM
Jdforrester-WMF removed a project: Patch-For-Review.Jul 25 2018, 6:39 PM
• Deskana closed this task as Resolved.Jul 30 2018, 3:26 PM
• Deskana closed subtask T185944: OOUI window ready process runs before window is actually ready (Category drop down list gets sticky when it's open while closing the dialog) as Resolved.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 30 2018, 3:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL