Maniphest T200081

Refactor ext.cx.common.less
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Petar.petkovic
	Jul 20 2018, 1:02 PM

Description

To reduce chance for regressions like T199503 happening in the future, I propose we split ext.cx.common.less file. It currently includes common styles definitions, mixed with LESS mixin and variable definitions.

Current structure:

modules/widgets/common/

ext.cx.common.less
ext.cx.highlight.less
/grid
- agora-grid.less
- grid-core.less
- grid-responsive.less
- grid-settings.less

Proposed structure:

modules/ui/styles/

mw.cx.common.less
mw.cx.mixins.less
mw.cx.variables.less
mw.cx.highlight.less
/grid
- agora-grid.less
- grid-core.less
- grid-responsive.less
- grid-settings.less

mw.* naming convention instead of ext.* is to make it consistant with VE and other mw extensions

Details

	Subject	Repo	Branch	Lines +/-
	Split common LESS file into mixins and variables	mediawiki/extensions/ContentTranslation	master	+150 -311

Customize query in gerrit

Related Objects

Mentioned Here: T199503: CX: Adjust background color in the translation editor view

Event Timeline

• Petar.petkovic triaged this task as Low priority.Jul 20 2018, 1:02 PM

• Petar.petkovic created this task.

• Petar.petkovic moved this task from Needs Triage to Enhancements on the ContentTranslation board.

Change 446596 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Split common LESS file into mixins and variables

https://gerrit.wikimedia.org/r/446596

gerritbot added a project: Patch-For-Review.Jul 20 2018, 1:06 PM

• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-July-September board.Jul 20 2018, 1:06 PM

Change 446596 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Split common LESS file into mixins and variables

https://gerrit.wikimedia.org/r/446596

• Petar.petkovic removed a project: Patch-For-Review.Jul 23 2018, 12:00 PM

• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.

Etonkovidova closed this task as Resolved.Jul 26 2018, 11:18 PM

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Jul 27 2018, 6:54 AM