Page MenuHomePhabricator

Refactor ext.cx.common.less
Closed, ResolvedPublic

Description

To reduce chance for regressions like T199503 happening in the future, I propose we split ext.cx.common.less file. It currently includes common styles definitions, mixed with LESS mixin and variable definitions.

Current structure:

modules/widgets/common/

  • ext.cx.common.less
  • ext.cx.highlight.less
  • /grid
    • agora-grid.less
    • grid-core.less
    • grid-responsive.less
    • grid-settings.less

Proposed structure:

modules/ui/styles/

  • mw.cx.common.less
  • mw.cx.mixins.less
  • mw.cx.variables.less
  • mw.cx.highlight.less
  • /grid
    • agora-grid.less
    • grid-core.less
    • grid-responsive.less
    • grid-settings.less

mw.* naming convention instead of ext.* is to make it consistant with VE and other mw extensions

Details

Related Gerrit Patches:
mediawiki/extensions/ContentTranslation : masterSplit common LESS file into mixins and variables

Event Timeline

Petar.petkovic triaged this task as Low priority.Jul 20 2018, 1:02 PM
Petar.petkovic created this task.
Petar.petkovic moved this task from Needs Triage to Enhancements on the ContentTranslation board.

Change 446596 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Split common LESS file into mixins and variables

https://gerrit.wikimedia.org/r/446596

Change 446596 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Split common LESS file into mixins and variables

https://gerrit.wikimedia.org/r/446596

Etonkovidova closed this task as Resolved.Jul 26 2018, 11:18 PM