Page MenuHomePhabricator
Create Task
Maniphest T200381

Remove PAGE_IMAGES_INSTALLED constant
Closed, ResolvedPublic
Actions

Description

ExtensionRegistry should be used instead to check whether an extension is installed.

https://codesearch.wmflabs.org/search/?q=PAGE_IMAGES_INSTALLED&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Don't use PAGE_IMAGES_INSTALLEDmediawiki/extensions/VisualEditormaster+1 -1
Stop setting PAGE_IMAGES_INSTALLEDmediawiki/extensions/PageImagesmaster+0 -9
Don't use PAGE_IMAGES_INSTALLEDmediawiki/extensions/MobileFrontendmaster+11 -9
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm triaged this task as Medium priority.Jul 25 2018, 11:09 PM
Legoktm created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2018, 11:09 PM
Legoktm updated the task description. (Show Details)Jul 25 2018, 11:09 PM
gerritbot subscribed.Jul 25 2018, 11:19 PM

Change 447926 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/VisualEditor@master] Don't use PAGE_IMAGES_INSTALLED

https://gerrit.wikimedia.org/r/447926

gerritbot added a project: Patch-For-Review.Jul 25 2018, 11:19 PM
gerritbot added a comment.Jul 26 2018, 1:19 AM

Change 447950 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MobileFrontend@master] Don't use PAGE_IMAGES_INSTALLED

https://gerrit.wikimedia.org/r/447950

gerritbot added a comment.Jul 26 2018, 1:21 AM

Change 447951 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/PageImages@master] Stop setting PAGE_IMAGES_INSTALLED

https://gerrit.wikimedia.org/r/447951

gerritbot added a comment.Jul 26 2018, 2:23 AM

Change 447950 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Don't use PAGE_IMAGES_INSTALLED

https://gerrit.wikimedia.org/r/447950

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 26 2018, 3:00 AM
gerritbot added a comment.Jul 26 2018, 3:02 AM

Change 447926 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Don't use PAGE_IMAGES_INSTALLED

https://gerrit.wikimedia.org/r/447926

gerritbot added a comment.Jul 26 2018, 3:02 AM

Change 447951 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Stop setting PAGE_IMAGES_INSTALLED

https://gerrit.wikimedia.org/r/447951

Legoktm closed this task as Resolved.Jul 26 2018, 3:05 AM
Legoktm claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL