Page MenuHomePhabricator
Create Task
Maniphest T180192

Audit wgExtensionFunctions, onRegistration and onSetupAfterCache callbacks in Wikimedia-deployed extensions
Open, MediumPublic
Actions

Description

@Krinkle and @Legoktm started doing this earlier this week, but we should audit all of the usage of $wgExtensionFunctions and extension.json's onRegistration callbacks to see what is still needed, and what can be removed.

Codesearch:

Details

Show related patches Customize query in gerrit

Revisions and Commits

rEFLW extension-Flow
rEFLWe9bf99b684bf Reduce initFlowExtension cost from Utils::isParsoidConfigured()
rEFLW6ad0ce958935 Remove dead code to load composer autoloader
rEFLW6e0f1a40bdb2 Set GrantPermissions in extension.json
rEFLW47d0128a490a Don't create the OccupationController during initialization
rEEVL extension-EventLogging
rEEVL7f51e9fedbcf Simplify onSetup check for configuration
rEEVLca2d23124f5e hooks: Remove redundant wgMemc check in onSetup
rECRE extension-CodeReview
rECREcebd129b68a8 Use custom ResourceLoader module instead of $wgExtensionFunctions
rEMMV extension-MultimediaViewer
rEMMV03eb49cde1e6 Remove unnecessary $wgExtensionFunctions

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Krinkle added a commit: rEEVL7f51e9fedbcf: Simplify onSetup check for configuration.Nov 23 2017, 8:33 AM
Legoktm moved this task from MWPT-Q2-Oct-Dec-2017 to MWPT-Q3-Jan-Mar-2018 on the MediaWiki-Platform-Team-Archived board.Dec 21 2017, 6:12 PM
Legoktm edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q2-Oct-Dec-2017).
Krinkle edited projects, added Performance-Team (Radar); removed Performance Issue.Feb 14 2018, 8:56 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
CCicalese_WMF edited projects, added MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018); removed MediaWiki-Platform-Team-Archived (MWPT-Q3-Jan-Mar-2018).Apr 4 2018, 7:03 PM
CCicalese_WMF edited projects, added Core-Platform-Team-Old; removed MediaWiki-Platform-Team-Archived (MWPT-Q4-Apr-Jun-2018).Jul 11 2018, 10:54 PM
CCicalese_WMF moved this task from Inbox to Backlog on the Core-Platform-Team-Old board.
gerritbot subscribed.Jul 25 2018, 11:26 PM

Change 447928 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/CodeReview@master] Use custom ResourceLoader module instead of $wgExtensionFunctions

https://gerrit.wikimedia.org/r/447928

gerritbot added a project: Patch-For-Review.Jul 25 2018, 11:26 PM
Legoktm mentioned this in T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime.Jul 25 2018, 11:31 PM
gerritbot added a comment.Jul 25 2018, 11:49 PM

Change 447931 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Interwiki@master] Get rid of most of the need for an extension function

https://gerrit.wikimedia.org/r/447931

gerritbot added a comment.Jul 25 2018, 11:54 PM

Change 447928 merged by jenkins-bot:
[mediawiki/extensions/CodeReview@master] Use custom ResourceLoader module instead of $wgExtensionFunctions

https://gerrit.wikimedia.org/r/447928

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)).Jul 26 2018, 12:00 AM
gerritbot added a comment.Jul 26 2018, 12:03 AM

Change 447932 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/MultimediaViewer@master] Remove unnecessary $wgExtensionFunctions

https://gerrit.wikimedia.org/r/447932

gerritbot added a comment.Jul 26 2018, 12:12 AM

Change 447933 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BounceHandler@master] Improve default $wgUnrecognizedBounceNotify behavior

https://gerrit.wikimedia.org/r/447933

gerritbot added a comment.Jul 26 2018, 12:12 AM

Change 447934 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/BounceHandler@master] Provide a default for $wgVERPdomainPart at runtime

https://gerrit.wikimedia.org/r/447934

gerritbot added a comment.Jul 26 2018, 12:19 AM

Change 447936 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Echo@master] Use UserGetDefaultOptions hook instead of $wgExtensionFunctions

https://gerrit.wikimedia.org/r/447936

gerritbot added a comment.Jul 26 2018, 2:23 AM

Change 447932 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Remove unnecessary $wgExtensionFunctions

https://gerrit.wikimedia.org/r/447932

Krinkle added commits: rECREcebd129b68a8: Use custom ResourceLoader module instead of $wgExtensionFunctions, rEMMV03eb49cde1e6: Remove unnecessary $wgExtensionFunctions.Jul 26 2018, 2:42 AM
Krinkle added a parent task: T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).Jul 26 2018, 2:46 AM
Krinkle updated the task description. (Show Details)Jul 26 2018, 2:52 AM
gerritbot added a comment.Jul 26 2018, 3:00 AM

Change 447936 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use UserGetDefaultOptions hook instead of $wgExtensionFunctions

https://gerrit.wikimedia.org/r/447936

Legoktm closed subtask T200381: Remove PAGE_IMAGES_INSTALLED constant as Resolved.Jul 26 2018, 3:05 AM
Agabi10 subscribed.Jul 26 2018, 10:12 AM
gerritbot added a comment.Jul 26 2018, 3:55 PM

Change 447931 merged by jenkins-bot:
[mediawiki/extensions/Interwiki@master] Get rid of most of the need for an extension function

https://gerrit.wikimedia.org/r/447931

gerritbot added a comment.Jul 26 2018, 4:28 PM

Change 448065 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/OAuth@master] Get rid of extension.json callback

https://gerrit.wikimedia.org/r/448065

gerritbot added a comment.Jul 26 2018, 4:41 PM

Change 448069 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ZeroPortal@master] Don't use $wgExtensionFunctions for an extension dependency

https://gerrit.wikimedia.org/r/448069

gerritbot added a comment.Jul 26 2018, 5:05 PM

Change 448069 merged by jenkins-bot:
[mediawiki/extensions/ZeroPortal@master] Don't use $wgExtensionFunctions for an extension dependency

https://gerrit.wikimedia.org/r/448069

gerritbot added a comment.Jul 28 2018, 5:33 PM

Change 448065 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Get rid of extension.json callback

https://gerrit.wikimedia.org/r/448065

gerritbot added a comment.Jul 29 2018, 7:48 PM

Change 449034 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ParserFunctions@master] Enable string functions if running parser/PHPUnit tests

https://gerrit.wikimedia.org/r/449034

Legoktm added a subtask: T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime.Jul 31 2018, 1:25 AM
tstarling moved this task from Backlog to CPT-Q1-Jul-Sep-2018 on the Core-Platform-Team-Old board.Jul 31 2018, 4:28 AM
tstarling edited projects, added Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018); removed Core-Platform-Team-Old.
tstarling moved this task from Backlog to In Progress on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.
• Catrope closed subtask T200390: Why does $wgNotificationSender exist as Resolved.Aug 23 2018, 8:35 PM
CCicalese_WMF assigned this task to Legoktm.Oct 1 2018, 1:33 PM
CCicalese_WMF edited projects, added Platform Team Legacy (Designing); removed Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018).
CCicalese_WMF moved this task from Inbox to Doing on the Platform Team Legacy (Designing) board.
CCicalese_WMF added a project: Platform Engineering.Oct 2 2018, 2:25 PM
CCicalese_WMF moved this task from Inbox to Needs Cleaning - Code Health (TEC13) on the Platform Engineering board.Oct 3 2018, 2:16 PM
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Engineering.
CCicalese_WMF edited projects, added Platform Team Workboards (Doing); removed Platform Team Legacy (Designing).Oct 14 2018, 3:57 PM
gerritbot added a comment.Dec 9 2018, 2:01 AM

Change 447934 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Provide a default for $wgVERPdomainPart at runtime

https://gerrit.wikimedia.org/r/447934

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 9 2018, 3:01 AM
gerritbot added a comment.Feb 7 2019, 2:30 AM

Change 447933 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Improve default $wgUnrecognizedBounceNotify behavior

https://gerrit.wikimedia.org/r/447933

Krinkle removed projects: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MW-1.32-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), Patch-For-Review.Feb 7 2019, 2:30 AM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 7 2019, 3:01 AM
gerritbot added a comment.Feb 7 2019, 11:41 PM

Change 449034 merged by jenkins-bot:
[mediawiki/extensions/ParserFunctions@master] Enable string functions if running parser/PHPUnit tests

https://gerrit.wikimedia.org/r/449034

WDoranWMF removed Legoktm as the assignee of this task.Jul 5 2019, 6:27 PM
WDoranWMF removed a project: Platform Team Workboards (Doing).
WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering (Needs Cleaning - Code Health (TEC13)).Sep 10 2019, 6:21 PM
WDoranWMF subscribed.

We should define a done state for this task.

Krinkle closed subtask T200650: Deprecate/obsolete $wgWikimediaJenkinsCI as Resolved.Sep 30 2019, 1:30 AM
Krinkle updated the task description. (Show Details)
Krinkle updated the task description. (Show Details)Sep 30 2019, 1:32 AM
Krinkle removed a parent task: T189966: Audit and simplify MediaWiki initialisation code (Spring 2018).Oct 3 2019, 9:44 PM

Untagging from T189966 as it does not stand out in perf analysis. Possibly because we've already fixed the vast majority by now, but de-parenting because its current sub tasks are not required for its completion.

daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
• AMooney changed the task status from Open to Stalled.Mar 12 2020, 1:22 PM
• AMooney edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team).
WDoranWMF moved this task from Inbox to Icebox on the Platform Engineering board.Mar 12 2020, 1:32 PM
WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:04 PM
daniel added a parent task: T271574: Phase out $wgExtensionFunctions.Jan 8 2021, 6:52 PM
Krinkle renamed this task from Audit $wgExtensionFunction and extension.json callback usage by Wikimedia-deployed extensions to Audit wgExtensionFunction, onRegistration and onSetupAfterCache callbacks in Wikimedia-deployed extensions.Apr 16 2021, 2:16 AM
Krinkle mentioned this in T226462: ExtensionFunctions defined in wmf-config are run after extensions' own ExtensionFunctions.Apr 16 2021, 2:39 AM
gerritbot added a comment.Apr 16 2021, 2:39 AM

Change 680090 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/OAuth@master] Remove $wgMWOAuthSharedUserIDs, and drop runtime changes to config

https://gerrit.wikimedia.org/r/680090

gerritbot added a project: Patch-For-Review.Apr 16 2021, 2:39 AM
Krinkle updated the task description. (Show Details)Apr 16 2021, 2:45 AM
Krinkle changed the task status from Stalled to Open.Apr 16 2021, 2:49 AM
Krinkle moved this task from Watching to Perf recommendation on the Performance-Team (Radar) board.
gerritbot added a comment.Apr 19 2021, 1:51 AM

Change 680811 had a related patch set uploaded (by Krinkle; author: Reedy):

[operations/mediawiki-config@master] Update RelatedArticles config

https://gerrit.wikimedia.org/r/680811

gerritbot added a comment.Apr 19 2021, 2:29 AM

Change 680830 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/CentralAuth@master] Move conditional SpecialUsersWhoWillBeRenamed to relevant hook

https://gerrit.wikimedia.org/r/680830

gerritbot added a comment.Apr 19 2021, 2:50 PM

Change 680811 merged by jenkins-bot:

[operations/mediawiki-config@master] Update RelatedArticles config

https://gerrit.wikimedia.org/r/680811

gerritbot added a comment.Aug 4 2021, 10:01 PM

Change 680830 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Move conditional SpecialUsersWhoWillBeRenamed to relevant hook

https://gerrit.wikimedia.org/r/680830

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 4 2021, 11:00 PM
Legoktm added subtasks: T288225: Remove need for $wgExtensionFunction to configure CSP in MediaWiki, T288224: Fix $wgMathFullRestbaseURL so it doesn't require a $wgExtensionFunction to set, T288223: Move Wikimedia's XFF log to MediaWiki core.Aug 5 2021, 10:26 AM
gerritbot added a comment.Sep 23 2022, 3:14 PM

Change 680090 abandoned by Krinkle:

[mediawiki/extensions/OAuth@master] Remove $wgMWOAuthSharedUserIDs, and drop runtime changes to config

Reason:

https://gerrit.wikimedia.org/r/680090

Krinkle added a parent task: T302623: FY2022-2023: Improve Backend Pageview Timing.Oct 3 2022, 9:19 PM
Krinkle moved this task from Perf recommendation to Watching on the Performance-Team (Radar) board.
gerritbot added a comment.Mar 31 2023, 12:31 AM

Change 904653 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/CentralAuth@master] Declare AntiSpoof as required dependency for CentralAuth

https://gerrit.wikimedia.org/r/904653

gerritbot added a comment.Jun 6 2023, 11:55 PM

Change 904653 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Declare AntiSpoof as required dependency for CentralAuth

https://gerrit.wikimedia.org/r/904653

Maintenance_bot removed a project: Patch-For-Review.Jun 7 2023, 12:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.13; 2023-06-13).Jun 7 2023, 1:00 AM
Krinkle renamed this task from Audit wgExtensionFunction, onRegistration and onSetupAfterCache callbacks in Wikimedia-deployed extensions to Audit wgExtensionFunctions, onRegistration and onSetupAfterCache callbacks in Wikimedia-deployed extensions.Jun 9 2023, 4:54 PM
gerritbot added a comment.Jun 9 2023, 5:08 PM

Change 928884 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/CentralAuth@master] Phase out use of $wgExtensionFunctions callback

https://gerrit.wikimedia.org/r/928884

gerritbot added a project: Patch-For-Review.Jun 9 2023, 5:08 PM
gerritbot added a comment.Jun 9 2023, 5:58 PM

Change 928884 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Phase out use of $wgExtensionFunctions callback

https://gerrit.wikimedia.org/r/928884

Maintenance_bot removed a project: Patch-For-Review.Jun 9 2023, 6:10 PM
Krinkle moved this task from Watching to Perf recommendation on the Performance-Team (Radar) board.Aug 6 2023, 10:41 PM
Krinkle edited projects, added Wikimedia-Performance-recommendation; removed Performance-Team (Radar).Aug 18 2023, 8:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits