Maybe someone else remembers why $wgNotificationSender exists.
public static function registerExtension() {
global $wgNotificationSender, $wgPasswordSender;
$wgNotificationSender = $wgPasswordSender;
}Since it's unconditionally set to $wgPasswordSender, it's impossible to override. Why don't we just use $wgPasswordSender everywhere instead then?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Drop $wgNotificationSender, written to but never configurable | mediawiki/extensions/Echo | master | +6 -13 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T271574 Phase out $wgExtensionFunctions | |||
| Open | pmiazga | T302623 FY2022-2023: Improve Backend Pageview Timing | |||
| Open | None | T180192 Audit wgExtensionFunctions, onRegistration and onSetupAfterCache callbacks in Wikimedia-deployed extensions | |||
| Resolved | Catrope | T200390 Why does $wgNotificationSender exist |
From https://codesearch.wmflabs.org/operations/?q=wgNotificationSender&i=nope&files=&repos= it looks like people thought they could set this…
Interesting. https://codesearch.wmflabs.org/search/?q=%5B%27%22g%5DNotificationSender&i=nope&files=&repos=
17885'wmgNotificationSender' => [ 17886 'default' => 'wiki@wikimedia.org', 17887 'enwiki' => 'no-reply-notifications@wikipedia.org',
2749 $wgNotificationSender = $wmgNotificationSender; 2750 $wgNotificationSenderName = $wgSitename;
But:
$ mwscript eval.php --wiki enwiki > echo $wmgNotificationSender; no-reply-notifications@wikipedia.org > echo $wgNotificationSender; wiki@wikimedia.org
It looks like this was broken when Echo was converted to extension.json in rECHOd66771523c23: Add extension.json, empty PHP entry point
Change 454144 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Echo@master] Drop $wgNotificationSender, written to but never configurable
Change 454144 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Drop $wgNotificationSender, written to but never configurable