Page MenuHomePhabricator

Why does $wgNotificationSender exist
Closed, ResolvedPublic


Maybe someone else remembers why $wgNotificationSender exists.

	public static function registerExtension() {
		global $wgNotificationSender, $wgPasswordSender;

		$wgNotificationSender = $wgPasswordSender;

Since it's unconditionally set to $wgPasswordSender, it's impossible to override. Why don't we just use $wgPasswordSender everywhere instead then?

Event Timeline

Legoktm triaged this task as Medium priority.Jul 26 2018, 12:37 AM
Legoktm created this task.


17885'wmgNotificationSender' => [
17886	'default' => '',
17887	'enwiki' => '',
2749	$wgNotificationSender = $wmgNotificationSender;
2750	$wgNotificationSenderName = $wgSitename;


$ mwscript eval.php --wiki enwiki
> echo $wmgNotificationSender;

> echo $wgNotificationSender;

It looks like this was broken when Echo was converted to extension.json in rECHOd66771523c23: Add extension.json, empty PHP entry point

Change 454144 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/Echo@master] Drop $wgNotificationSender, written to but never configurable

Catrope claimed this task.

Change 454144 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Drop $wgNotificationSender, written to but never configurable