Seen in several newbie patches. Instead of
global $wgMyConfigGlobal;
they should use
$this->getConfig()->get( 'MyConfigGlobal' );
Quite similiar to [[ https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/Sniffs/Usage/ExtendClassUsageSniff.php | ExtendClassUsageSniff ]].
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Expand ExtendClassUsageSniff to check for config globals | mediawiki/tools/codesniffer | master | +116 -16 |
Is this a recommendation that is valid for all config globals in all places? Is there any documentation about this?
This could be tricky, because the sniff has to decide between config globals and objects/non-config globals. That means the sniff needs the way to set globals in .phpcs.xml as input for use in extensions. The core list can be found on T159283 and should be hard coded.
ExtendClassUsageSniff is only acting on classes extends ContextSource, because there it is better to call getConfig to get modern code.
Change 481653 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/tools/codesniffer@master] Expand ExtendClassUsageSniff to check for config globals
Change 481653 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Expand ExtendClassUsageSniff to check for config globals