Page MenuHomePhabricator
Create Task
Maniphest T200861

Web upgrade of SQLite does not work, just skips to install
Closed, ResolvedPublic
Actions

Description

Attempting to upgrade an SQLite wiki using the web installer does not work, needsUpgrade() always returns false. It just skips to the installation step without any error message. This is because DatabaseSqlite::selectDB() always returns false as of 8d61cf2793abd24166f2cc5da10b517a2802d6cb (October 2016).

Details

SubjectRepoBranchLines +/-
Fix total breakage of SQLite web upgrademediawiki/coreREL1_31+1 -4
Fix total breakage of SQLite web upgrademediawiki/coreREL1_29+1 -4
Fix total breakage of SQLite web upgrademediawiki/coreREL1_30+1 -4
Fix total breakage of SQLite web upgrademediawiki/coremaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

tstarling created this task.Aug 1 2018, 12:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2018, 12:17 AM
gerritbot subscribed.Aug 1 2018, 12:21 AM

Change 449638 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449638

gerritbot added a project: Patch-For-Review.Aug 1 2018, 12:21 AM
tstarling moved this task from Backlog to In Progress on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Aug 1 2018, 1:34 AM
gerritbot added a comment.Aug 1 2018, 2:10 AM

Change 449638 merged by jenkins-bot:
[mediawiki/core@master] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449638

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 1 2018, 3:01 AM
Legoktm added projects: MW-1.29-release, MW-1.30-release, MW-1.31-release.Aug 1 2018, 6:47 AM
gerritbot added a comment.Aug 1 2018, 2:12 PM

Change 449728 had a related patch set uploaded (by Reedy; owner: Tim Starling):
[mediawiki/core@REL1_29] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449728

gerritbot added a comment.Aug 1 2018, 2:12 PM

Change 449729 had a related patch set uploaded (by Reedy; owner: Tim Starling):
[mediawiki/core@REL1_30] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449729

gerritbot added a comment.Aug 1 2018, 2:13 PM

Change 449730 had a related patch set uploaded (by Reedy; owner: Tim Starling):
[mediawiki/core@REL1_31] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449730

gerritbot added a comment.Aug 6 2018, 2:52 PM

Change 449729 merged by jenkins-bot:
[mediawiki/core@REL1_30] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449729

gerritbot added a comment.Aug 6 2018, 2:57 PM

Change 449728 merged by jenkins-bot:
[mediawiki/core@REL1_29] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449728

ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.30-release-notes.Aug 6 2018, 3:00 PM
gerritbot added a comment.Aug 7 2018, 3:58 PM

Change 449730 merged by jenkins-bot:
[mediawiki/core@REL1_31] Fix total breakage of SQLite web upgrade

https://gerrit.wikimedia.org/r/449730

ReleaseTaggerBot added a project: MW-1.31-release-notes.Aug 7 2018, 4:00 PM
Krinkle moved this task from Untriaged to Usage problem on the MediaWiki-libs-Rdbms board.Aug 8 2018, 3:09 AM
tstarling moved this task from In Progress to Closed on the Core-Platform-Team-Old (CPT-Q1-Jul-Sep-2018) board.Aug 14 2018, 6:50 AM
CCicalese_WMF closed this task as Resolved.Aug 20 2018, 8:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL