Maniphest T201288

Improve qualifier suggestions using constraint definition (allowed qualifiers)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

As a user I would like to get suggestions for qualifiers that are valid in that context, so I can easily chose the right qualifier property.

GIVEN I am on a property page.
WHEN I add a property 'property constraint' (P2302)
AND I add a qualifier
THEN I would like to see 'allowed qualifiers' or ' mandatory qualifier' suggested.

Tasks:

Implement the consumer of the search suggester hook, and the suggestion code in the WikibaseQualityConstraints extension, by analogy to this

Query for all properties that have a allowed qualifiers constraint definition
http://tinyurl.com/y8sgn4j9

Details

	Subject	Repo	Branch	Lines +/-
	Introduce qualifier suggestions using allowed qualifiers	mediawiki/extensions/WikibaseQualityConstraints	master	+58 -11

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Jonas	T198228 Investigate improvements for item suggester in property values
Resolved	• Jonas	T199672 Improve constraint property item suggestions for property constraint values (one-of)
Resolved	• Jonas	T201288 Improve qualifier suggestions using constraint definition (allowed qualifiers)
Resolved	• Jonas	T202712 Beta feature for constraint suggestions

Event Timeline

• Jonas triaged this task as Medium priority.Aug 6 2018, 8:04 AM

• Jonas created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2018, 8:04 AM

• Jonas merged a task: T201289: Improve qualifier suggestions using constraint definition (allowed qualifiers, mandatory qualifier).Aug 6 2018, 8:05 AM

• Jonas moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

• Jonas moved this task from Ready to estimate to Incoming on the Wikidata-Campsite board.Aug 15 2018, 1:10 PM

This is basically another consumer for search suggester hook, that takes two constraint definitions, and returns items defined in these defintions.
Entity suggester has to made aware of its context (is it a qualifier, or main snak).

WMDE-leszek moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Aug 21 2018, 1:46 PM

WMDE-leszek updated the task description. (Show Details)Aug 21 2018, 1:50 PM

Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Aug 23 2018, 9:28 AM

• Jonas claimed this task.Aug 24 2018, 9:04 AM

• Jonas moved this task from Ready to estimate to In Progress on the Wikidata-Campsite board.

• Jonas moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 455168 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Introduce qualifier suggestions using allowed qualifiers

https://gerrit.wikimedia.org/r/455168

gerritbot added a project: Patch-For-Review.Aug 24 2018, 1:46 PM

• Jonas renamed this task from Improve qualifier suggestions using constraint definition (allowed qualifiers, mandatory qualifier) to Improve qualifier suggestions using constraint definition (allowed qualifiers).Aug 27 2018, 9:54 AM

• Jonas updated the task description. (Show Details)

• Jonas moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Aug 27 2018, 10:01 AM

Liuxinyu970226 subscribed.Sep 2 2018, 9:30 AM

Change 455168 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Introduce qualifier suggestions using allowed qualifiers

https://gerrit.wikimedia.org/r/455168

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 4 2018, 7:00 PM

• Jonas moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 5 2018, 6:16 AM