Page MenuHomePhabricator
Create Task
Maniphest T201644

[betalabs] AfC - Declined date displayed as the date of the most recent draft update
Closed, ResolvedPublic
Actions

Description

  1. In betalabs create a draft and submit it for review, then 'Mark as under review', then 'Decline'.
  2. Check if all dates - the creating date and the decline date - displayed correctly on Special:NewPagesFeed with AfC filters - all dates are exactly (or off by a min) as they displayed in the draft View history record.
  3. Go to the draft and do some editing & save.
  4. Click 'Refresh list' on Special:NewPagesFeed - the Declined date will reflect the date of the most recent update:

Screen Shot 2018-08-09 at 1.57.02 PM.png (483×1 px, 133 KB)

Screen Shot 2018-08-09 at 1.57.17 PM.png (563×1 px, 219 KB)

Details

SubjectRepoBranchLines +/-
Only update ptrp_reviewed_updated when the afc_state changesmediawiki/extensions/PageTriagemaster+33 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Aug 9 2018, 9:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 9 2018, 9:00 PM
Etonkovidova mentioned this in T201373: New Pages Feed: "created date" value changes depending on sort.Aug 9 2018, 9:27 PM
SBisson subscribed.Aug 13 2018, 1:30 PM

I can reproduce it locally and I see it in the code. It was introduced in T195547.

Basically every time a page is edited, categories are inspected to update the AfC state and the ptrp_reviewed_updated field is updated, regardless of the nature of the edit (content modification vs. AfC review).

SBisson claimed this task.Aug 16 2018, 3:51 PM
SBisson moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot subscribed.Aug 16 2018, 4:20 PM

Change 453157 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Only update ptrp_reviewed_updated when the afc_state changes

https://gerrit.wikimedia.org/r/453157

gerritbot added a project: Patch-For-Review.Aug 16 2018, 4:20 PM
SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2018, 4:40 PM
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 16 2018, 9:32 PM
gerritbot added a comment.Aug 17 2018, 12:09 AM

Change 453157 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Only update ptrp_reviewed_updated when the afc_state changes

https://gerrit.wikimedia.org/r/453157

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).Aug 17 2018, 1:00 AM
Etonkovidova closed this task as Resolved.Aug 17 2018, 7:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL