Page MenuHomePhabricator

[betalabs] AfC - Declined date displayed as the date of the most recent draft update
Closed, ResolvedPublic

Description

  1. In betalabs create a draft and submit it for review, then 'Mark as under review', then 'Decline'.
  2. Check if all dates - the creating date and the decline date - displayed correctly on Special:NewPagesFeed with AfC filters - all dates are exactly (or off by a min) as they displayed in the draft View history record.
  3. Go to the draft and do some editing & save.
  4. Click 'Refresh list' on Special:NewPagesFeed - the Declined date will reflect the date of the most recent update:

Event Timeline

I can reproduce it locally and I see it in the code. It was introduced in T195547.

Basically every time a page is edited, categories are inspected to update the AfC state and the ptrp_reviewed_updated field is updated, regardless of the nature of the edit (content modification vs. AfC review).

Change 453157 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Only update ptrp_reviewed_updated when the afc_state changes

https://gerrit.wikimedia.org/r/453157

Change 453157 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Only update ptrp_reviewed_updated when the afc_state changes

https://gerrit.wikimedia.org/r/453157