Page MenuHomePhabricator
Create Task
Maniphest T202293

Sort out the dependency of fill_table_monuments_all.py on pywikibot
Closed, ResolvedPublic
Actions

Description

Added in rTHER4bb0c127, fill_table_monuments_all.py has a dependency on pywikibot for logging.

This means I can’t run it locally, as instructed by the ReadMe, as I don’t have pywikibot globally installed (it’s only in Docker).

Two ways forward:

  • Update the ReadMe to tell people to run the Python commands through docker-compose. It sort of works, except that it will also boot up the database container − which then has no tables to create ; and one needs to kill the DB, restart it etc. Could be solveable with another compose file.
  • Remove the dependency on pywikibot

Details

SubjectRepoBranchLines +/-
Streamline start-up instructions in ReadMelabs/tools/heritagemaster+8 -5
Customize query in gerrit

Related Objects

Event Timeline

JeanFred created this task.Aug 20 2018, 2:58 PM
gerritbot subscribed.Aug 21 2018, 9:55 AM

Change 454225 had a related patch set uploaded (by Jean-Frédéric; owner: Jean-Frédéric):
[labs/tools/heritage@master] Streamline start-up instructions in ReadMe

https://gerrit.wikimedia.org/r/454225

gerritbot added a project: Patch-For-Review.Aug 21 2018, 9:55 AM
JeanFred added a comment.Aug 21 2018, 9:59 AM

Update the ReadMe to tell people to run the Python commands through docker-compose. It sort of works, except that it will also boot up the database container − which then has no tables to create ; and one needs to kill the DB, restart it etc. Could be solveable with another compose file.

I submitted a patch for this (same Compose file, just using --no-deps)

gerritbot added a comment.Sep 4 2018, 7:06 AM

Change 454225 merged by jenkins-bot:
[labs/tools/heritage@master] Streamline start-up instructions in ReadMe

https://gerrit.wikimedia.org/r/454225

Lokal_Profil added a comment.Sep 4 2018, 3:22 PM

per review comments. The set-up steps should be collected in a shell script. As it is missing the docker-compose up --build -d sticks you in an infinite loop of "waiting for database" which you cannot leave

Stashbot subscribed.Sep 5 2018, 6:05 PM

Mentioned in SAL (#wikimedia-cloud) [2018-09-05T18:05:04Z] <JeanFred> Deploy latest from Git master: 8466ed3 (T202293), 06586e9 (T203432), 0631774, d2ff281 (T200159), d55090e

Stashbot mentioned this in T203432: Toolforge pip cannot handle the requirements as formatted by pipenv.Sep 5 2018, 6:05 PM
Stashbot mentioned this in T200159: Solve InsecurePlatformWarning in ErfgoedBot.
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:42 PM
Lokal_Profil closed this task as Resolved.EditedMay 27 2019, 9:26 AM
Lokal_Profil claimed this task.
Lokal_Profil mentioned this in T224409: Create bash script for docker-compose set-up steps.

Moved the last comment to a separate task so that this can be resolved

Lokal_Profil reassigned this task from Lokal_Profil to JeanFred.May 27 2019, 9:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits