Maniphest T202525

ve.ce.LinearSelection throws exception
Closed, ResolvedPublic
Actions

Description

Open empty.html
Type one char ('a') and link it (ctrl+k, enter)
Move the cursor to the end (right) then delete the text, and the empty link cartouche (backspace x 3)
Press ctrl+k again

An exception is thrown trying to get a bounding rectangle for the cursor.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	master	+1 -1	Update VE core submodule to master (874470c1b)
	VisualEditor/VisualEditor	master	+1 -1	ve.ce.LinearSelection: Guard against node=null in getNodeClientRectFromRange

Customize query in gerrit

Related Objects

Mentioned Here: rGVED874470c1bb54: ve.ce.LinearSelection: Guard against node=null in getNodeClientRectFromRange

Event Timeline

Esanders created this task.Aug 22 2018, 12:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 12:55 PM

Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.Aug 22 2018, 12:55 PM

Change 454537 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] ve.ce.LinearSelection: Guard against node=null in getNodeClientRectFromRange

https://gerrit.wikimedia.org/r/454537

gerritbot added a project: Patch-For-Review.Aug 22 2018, 12:58 PM

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Aug 22 2018, 12:58 PM

Change 454537 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ve.ce.LinearSelection: Guard against node=null in getNodeClientRectFromRange

https://gerrit.wikimedia.org/r/454537

Looks like the (empty) input flashes red when you close the link inspector again, though this was already happening.

Change 454567 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (874470c1b)

https://gerrit.wikimedia.org/r/454567

Change 454567 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (874470c1b)

https://gerrit.wikimedia.org/r/454567

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 22 2018, 4:00 PM

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 22 2018, 5:02 PM

Deskana triaged this task as Medium priority.Aug 31 2018, 3:18 PM

Ryasmeen added a project: Verified.Sep 13 2018, 11:30 PM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Jdforrester-WMF removed a project: Patch-For-Review.Sep 13 2018, 11:31 PM

Deskana closed this task as Resolved.Sep 28 2018, 12:32 PM