Page MenuHomePhabricator

Text input for the CAPTCHA when editing (adding a link) is tiny and ugly
Closed, ResolvedPublic

Description

The text input field for the CAPTCHA when editing (adding a link) is tiny and doesn't use a pretty OOUI field, unlike most of the form. Spotted by @iamjessklein.

Screen Shot 2018-09-04 at 3.54.11 PM.png (844×2 px, 286 KB)

(When I've first seen the screenshot, it took me a while to even notice the input…)

The same interface on the signup page (https://en.wikipedia.org/wiki/Special:CreateAccount, logged out) looks much better (I think that has some custom hacks on top of it…)

image.png (980×1 px, 159 KB)

To reproduce the problem locally, you need these settings:

wfLoadExtensions( array( 'ConfirmEdit', 'ConfirmEdit/FancyCaptcha' ) );
$wgCaptchaClass = 'FancyCaptcha';
$wgCaptchaTriggers['addurl'] = true;

…then edit a page and try to add http://example.net/ to it as an anonymous user.

Event Timeline

Change 458599 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/ConfirmEdit@master] FancyCaptcha: Actually load styles for the CAPTCHA input

https://gerrit.wikimedia.org/r/458599

Screenshots from my test wiki:

BeforeAfter
image.png (980×1 px, 101 KB)
image.png (980×1 px, 106 KB)

I don't think this task is solved by this patch, but it's an improvement, and something I could trivially debug and fix in fifteen minutes :)

Change 458599 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] FancyCaptcha: Actually load styles for the CAPTCHA input

https://gerrit.wikimedia.org/r/458599

So actually, I consulted with @Volker_E about this and learned that this probably could use an OOUI update.

This is how CAPTCHA looks on the Medi Wiki page for reference

Screen Shot 2018-09-11 at 1.27.39 PM.png (968×1 px, 720 KB)

OOUI update wasn't my word choice (nor @iamjessklein's) ;), but definitely in need for a reuse of our TextInputWidget standard look.

Deskana triaged this task as Medium priority.

There's more to do here to get this to an ideal state, but this is at least an iterative improvement.