Page MenuHomePhabricator

mw.util.jsMessage should not use inline style "display: block;"
Closed, ResolvedPublic

Description

Author: sylvain.brunerie

Description:
When I add a page to my watchlist by clicking "watch" tab, a message appears (div#mw-js-message.mw-js-message-watch) (“The page "..." has been added to your watchlist. [...]”) to indicate that the page has been added.

I tried to add “div#mw-js-message.mw-js-message-watch { display: none; }” to my monobook.css, because I wanted to automatically hide this message. Unfortunately, this div uses an inline style "display: block;", which stops any attempt to hide it using CSS.

I think this inline style is not necessary, it could probably be easily replaced by using other CSS methods.
Please forgive me if I'm wrong, or if the problem has been mentioned yet.


Version: unspecified
Severity: minor

Details

Reference
bz18436

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:34 PM
bzimport set Reference to bz18436.
bzimport added a subscriber: Unknown Object (MLST).

happy.melon.wiki wrote:

Done in r56902.

This breaks in Vector; the div is initially hidden and now never gets unhidden.

chinchi29 wrote:

Removing easy keyword. So... how could the "display: block" style be replaced while not breaking in vector?

Is this bug made obsolete by the new mw.notify module?