| Krinkle | |
| Sep 17 2018, 11:16 PM |
| F26002270: Screen Shot 2018-09-18 at 03.16.52.png | |
| Sep 18 2018, 3:02 AM |
| F26002272: Screen Shot 2018-09-18 at 03.14.59.png | |
| Sep 18 2018, 3:02 AM |
| F25998384: Screen Shot 2018-09-17 at 05.15.16.png | |
| Sep 17 2018, 11:16 PM |
Follows-up T202357.
It's still not as good as it could be. It seems the wrap() is particularly expensive. Fine if called rarely, but this is quite popular method. It also seems to be setting the same attribute multiple times, probably unintentionally.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T127328 Optimise critical rendering path | |||
| Resolved | Krinkle | T204625 Reduce overhead of mw.util.addPortletLink |
| Before |
|---|
 |
| After |
|---|
 |
This is on a plain MW core install with EventLogging+Navigation Timing, and a snippet from https://www.mediawiki.org/w/index.php?title=Snippets/Purge_action&oldid=2878656#Code placed in MediaWiki:Common.js that calls addPortletLink().
Change 461022 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.util: Improve unit tests
Change 461023 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.util: Optimise addPortletLink
Change 461022 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.util: Improve unit tests
Change 461224 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.32.0-wmf.22] mediawiki.util: Improve unit tests
Change 461227 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@wmf/1.32.0-wmf.22] mediawiki.util: Optimise addPortletLink
Change 461023 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.util: Optimise addPortletLink
Change 461224 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.22] mediawiki.util: Improve unit tests
Change 461227 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.22] mediawiki.util: Optimise addPortletLink