Maniphest T204629

AfC: Issues with reloading the page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Sep 17 2018, 11:48 PM

Description

(1) Stats reflect the total count of pages disregarding filter selection set.

On Special:NewPagesFeed AfC select some filters and see some results or no results.
Refresh the page - the stats will show the total number of pages in the feed not the actual number of results.

(2) 'All' selection is not sticky when the page is reloaded.

On Special:NewPagesFeed AfC select some option for the State filter, click 'Set filters'.
Select 'All' for the State filter, click 'Set filters' - 'All' will be shown.
Re-load the page - the selection 'All' will be gone, the previously selected State filter option will be displayed.

Details

Subject	Repo	Branch	Lines +/-
Use same api params for list and stats on page load	mediawiki/extensions/PageTriage	wmf/1.32.0-wmf.22	+13 -19
Correctly sync the form when afc_state === 'all'	mediawiki/extensions/PageTriage	wmf/1.32.0-wmf.22	+3 -3
Use same api params for list and stats on page load	mediawiki/extensions/PageTriage	master	+13 -19
Correctly sync the form when afc_state === 'all'	mediawiki/extensions/PageTriage	master	+3 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		MMiller_WMF	T193782 [EPIC] Prioritization tools for AfC and NPP
		Resolved		SBisson	T204629 AfC: Issues with reloading the page

Event Timeline

Etonkovidova created this task.Sep 17 2018, 11:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2018, 11:48 PM

Etonkovidova renamed this task from AfC: Stats reflect the total count of pages disregarding filter selection set to AfC: Issues with reloading the page .Sep 18 2018, 12:08 AM

Etonkovidova updated the task description. (Show Details)

SBisson added a project: PageTriage.Sep 18 2018, 10:35 AM

SBisson claimed this task.Sep 18 2018, 12:47 PM

SBisson moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 461149 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Correctly sync the form when afc_state === 'all'

https://gerrit.wikimedia.org/r/461149

gerritbot added a project: Patch-For-Review.Sep 18 2018, 3:52 PM

Change 461150 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Use same api params for list and stats on page load

https://gerrit.wikimedia.org/r/461150

SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 18 2018, 3:57 PM

MMiller_WMF added a parent task: T203184: Deploy PageTriage AfC to production.Sep 18 2018, 5:24 PM

Change 461149 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Correctly sync the form when afc_state === 'all'

https://gerrit.wikimedia.org/r/461149

Change 461424 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.22] Correctly sync the form when afc_state === 'all'

https://gerrit.wikimedia.org/r/461424

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 4:00 PM

Change 461150 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Use same api params for list and stats on page load

https://gerrit.wikimedia.org/r/461150

Etonkovidova moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 19 2018, 4:07 PM

Checked the fix in betalabs - the issue is not present anymore.

Change 461648 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.22] Use same api params for list and stats on page load

https://gerrit.wikimedia.org/r/461648

Change 461424 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.22] Correctly sync the form when afc_state === 'all'

https://gerrit.wikimedia.org/r/461424

Change 461648 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.22] Use same api params for list and stats on page load

https://gerrit.wikimedia.org/r/461648

Mentioned in SAL (#wikimedia-operations) [2018-09-20T18:31:46Z] <thcipriani@deploy1001> Synchronized php-1.32.0-wmf.22/extensions/PageTriage/modules: SWAT: [[gerrit:461424|Correctly sync the form when afc_state === "all"]] T204629 [[gerrit:461648|Use same api params for list and stats on page load]] T204629 (duration: 00m 54s)