Page MenuHomePhabricator
Create Task
Maniphest T204769

Reconstruct opt_in data from buggy paypal form
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Need to use the web logs. hopefully everyone with opt_in=1 will also have an email address in the querystring.

Details

SubjectRepoBranchLines +/-
One more opt_in fix, this time for folks with NULLwikimedia/fundraising/crmmaster+30 -0
Follow-up: fix opt-in data for 148 non-PayPal donorswikimedia/fundraising/crmmaster+22 -0
Fix PayPal opt_in data affected by form bugwikimedia/fundraising/crmmaster+22 -0
Customize query in gerrit

Event Timeline

Ejegg created this task.Sep 18 2018, 8:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2018, 8:35 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Sep 18 2018, 8:36 PM
• DStrine added a project: Fundraising Sprint Sasquatches can't find us either.Sep 18 2018, 8:37 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Sasquatches can't find us either board.Sep 19 2018, 3:58 AM
Pcoombe subscribed.Sep 19 2018, 10:10 AM

You could look at drupal.contribution_tracking.utm_source instead, it should have either "optIn0" or "optIn1" in there.

gerritbot subscribed.Sep 20 2018, 2:39 AM

Change 461508 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Fix opt_in data affected by form bug

https://gerrit.wikimedia.org/r/461508

gerritbot added a project: Patch-For-Review.Sep 20 2018, 2:39 AM
Ejegg claimed this task.Sep 20 2018, 2:39 AM
Ejegg triaged this task as High priority.
Ejegg moved this task from Doing to Review on the Fundraising Sprint Sasquatches can't find us either board.
Ejegg set the point value for this task to 1.
gerritbot added a comment.Sep 20 2018, 4:27 PM

Change 461685 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Follow-up: fix opt-in data for 148 non-PayPal donors

https://gerrit.wikimedia.org/r/461685

gerritbot added a comment.Sep 20 2018, 4:45 PM

Change 461508 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Fix PayPal opt_in data affected by form bug

https://gerrit.wikimedia.org/r/461508

Ejegg moved this task from Review to Done on the Fundraising Sprint Sasquatches can't find us either board.Sep 20 2018, 11:53 PM
Ejegg added subscribers: • CCogdill_WMF, • MNoorWMF.Sep 20 2018, 11:58 PM

OK, this is fixed for the 1,341 PayPal donors affected.

There are 148 credit card donors who were also potentially affected by this bug - they have optin0 in the utm_source, indicating that they clicked 'no' in the banner, but opt_in = 1 in Civi. The bug that @Pcoombe pointed out (payments form showing 'yes' checked for people with opt_in=0 in querystring) affected card donors as well, it's just that they had the chance to click 'no' a second time before submitting their details. It's possible some of them changed their mind and decided 'yes' was fine on the payments form, but I imagine we'd want to set all of those donors to opt_in=0 also. I've got a patch ready to do that.

Pcoombe added a comment.Sep 21 2018, 12:43 PM

Ah, I hadn't realised the form bug affected credit card too. I assume that was fixed at the same time as PayPal?

Correcting those donors to opt_in=0 sounds like the safest action to me.

gerritbot added a comment.Sep 24 2018, 5:02 PM

Change 461685 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Follow-up: fix opt-in data for 148 non-PayPal donors

https://gerrit.wikimedia.org/r/461685

Ejegg closed this task as Resolved.Sep 27 2018, 12:12 AM
gerritbot added a comment.Oct 26 2018, 8:11 PM

Change 470033 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] One more opt_in fix, this time for folks with NULL

https://gerrit.wikimedia.org/r/470033

gerritbot added a comment.Oct 26 2018, 8:38 PM

Change 470033 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] One more opt_in fix, this time for folks with NULL

https://gerrit.wikimedia.org/r/470033

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL