Maniphest T205118

CentralNotice: When fetching banner settings, pull translation metadata only when necessary
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	AndyRussG
	Sep 21 2018, 4:28 PM

Tags

Referenced Files

None

Subscribers

Description

Any call to Banner::getBannerSettings() with detailed set to true (the default) causes the Translate extension to pull in all translation metadata (see T204026). There are times when we do this but it's not necessary.

Related Objects

Mentioned In: T203925: Save times for changes to translation variable text in centralnotice paralysingly slow
Mentioned Here: T204026: DBPerformance warning "Query returned XXXX rows: query: SELECT * FROM `translate_metadata`"

Event Timeline

AndyRussG created this task.Sep 21 2018, 4:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 21 2018, 4:28 PM

AndyRussG updated the task description. (Show Details)Sep 24 2018, 4:45 AM

AndyRussG mentioned this in T203925: Save times for changes to translation variable text in centralnotice paralysingly slow.Sep 24 2018, 5:04 AM

• DStrine moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 24 2018, 7:39 PM

• DStrine moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.

• DStrine moved this task from Current Sprint to Sprint +1 on the Fundraising-Backlog board.

• DStrine moved this task from Sprint +1 to Q3 2021-2022 on the Fundraising-Backlog board.May 6 2019, 9:41 PM

AndyRussG added a project: FR-Q2-FY2019-20-cleanup-list.Sep 6 2019, 2:54 AM

• DStrine removed a project: FR-Q2-FY2019-20-cleanup-list.Sep 11 2019, 5:59 PM

XenoRyet moved this task from Q3 2021-2022 to Unscheduled on the Fundraising-Backlog board.Mar 14 2023, 10:24 PM