Page MenuHomePhabricator

[GUI] Disable login button submit function on the provider picker page until something is entered as username
Closed, ResolvedPublic

Description

Author: sergey.chernyshev

Description:
OpenID breaks when empty username is submitted - disable login button until something is entered into username field.


Version: unspecified
Severity: enhancement

Details

Reference
bz18528

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:34 PM
bzimport set Reference to bz18528.
bzimport created this task.Apr 20 2009, 1:31 AM

Mass maintainer change.

(In reply to comment #0)

OpenID breaks when empty username is submitted - disable login button until
something is entered into username field.

Sergey, I took maitenance over, thank you for your previous work. Please can you describe this problem more elaborated. I do not understand, at which stage you mean an "empty username" comes up.

Tom

sergey.chernyshev wrote:

It's for UI with provider picker, some providers require you to enter the name which we use to construct the URL.

It's useful to no be able to submit a form without entering this name (otherwise user is sent to wrong URL).

(In reply to comment #3)

It's for UI with provider picker, some providers require you to enter the name
which we use to construct the URL.
It's useful to no be able to submit a form without entering this name
(otherwise user is sent to wrong URL).

Ok. Now I understand, this is an easy-to-fix bug.
Thanks

(In reply to comment #4)

Ok. Now I understand, this is an easy-to-fix bug.

Tagging easy, lowering priority.

Patch in Gerrit needs rework...

(In reply to comment #7)

Patch in Gerrit needs rework...

message received, ty

Change 50593 had a related patch set uploaded by Wikinaut:
Bug 18528: Show error for empty username for providers.

https://gerrit.wikimedia.org/r/50593

Change 50593 merged by Wikinaut:
Bug 18528: Show error for empty username for providers.

https://gerrit.wikimedia.org/r/50593

fixed in version 4.02