Page MenuHomePhabricator
Create Task
Maniphest T205612

Adding focus via tabbing to 'More' in wiki skin Refreshed
Closed, ResolvedPublic
Actions

Description

In wiki Skin Refreshed, focus via tabbing is not currently exist for 'More' in standard-toolbox.

The Current tabbing Order: Main page, Discussion, Edit, History, User's Guide.

  • If 'More' is clicked then the order is the Main page, Discussion, Edit, History, standard-toolbox-dropdown-menu Elements[Move, Watch.....], User's Guide

Expected tabbing order: Main page, Discussion, Edit, History, More, User's Guide.

Selection_020.png (336×544 px, 29 KB)

This will be the perfect task for Google-Code-in-2018, I will mentor this task.

To Install and config wiki Skin Refreshed follow this https://www.mediawiki.org/wiki/Skin:Refreshed

Details

SubjectRepoBranchLines +/-
Fix focus on 'More' drop down when tabbing in skin Refreshed.mediawiki/skins/Refreshedmaster+9 -2
Fix focus on 'More' drop down when tabbing in skin Refreshed.mediawiki/skins/Refreshedmaster+9 -2
Customize query in gerrit

Related Objects

Event Timeline

Gopavasanth created this task.Sep 27 2018, 10:17 AM
Gopavasanth moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2018 board.Sep 28 2018, 3:45 AM

Imported in Google-Code-in-2018 https://codein.withgoogle.com/dashboard/tasks/5177614659485696/

MtMNC subscribed.Oct 15 2018, 5:19 AM

This would be a good task to include in T200303, so if anyone wants to contribute for Google Code-in, consider working on the refreshed4-beta branch. Thank you!

gerritbot subscribed.Oct 28 2018, 9:45 AM

Change 470234 had a related patch set uploaded (by Mogmog123; owner: Mogmog123):
[mediawiki/skins@master] Task: https://phabricator.wikimedia.org/T205612

https://gerrit.wikimedia.org/r/470234

gerritbot added a project: Patch-For-Review.Oct 28 2018, 9:45 AM
gerritbot added a comment.Oct 30 2018, 3:36 PM

Change 470616 had a related patch set uploaded (by Artbarte; owner: Artbarte):
[mediawiki/skins/Refreshed@master] Fix focus on 'More' drop down when tabbing in skin Refreshed.

https://gerrit.wikimedia.org/r/470616

gerritbot added a comment.Oct 30 2018, 4:04 PM

Change 470621 had a related patch set uploaded (by Artbarte; owner: Artbarte):
[mediawiki/skins/Refreshed@master] Fix focus on 'More' drop down when tabbing in skin Refreshed.

https://gerrit.wikimedia.org/r/470621

Diffusion mentioned this in R1893:d54975aa2264: Fix focus on 'More' drop down when tabbing in skin Refreshed..Oct 30 2018, 4:26 PM
Diffusion mentioned this in R1893:8632eecec80f: Fix focus on 'More' drop down when tabbing in skin Refreshed..
gerritbot added a comment.Oct 30 2018, 6:33 PM

Change 470616 abandoned by Artbarte:
Fix focus on 'More' drop down when tabbing in skin Refreshed.

https://gerrit.wikimedia.org/r/470616

Diffusion mentioned this in R1893:aee41db2109a: Fix focus on 'More' drop down when tabbing in skin Refreshed..Oct 30 2018, 6:34 PM
gerritbot added a comment.Oct 30 2018, 7:26 PM

Change 470234 abandoned by Umherirrender:
Task: https://phabricator.wikimedia.org/T205612

Reason:
Please do not commit against this repo, use the mediawiki/skins/Refreshed repo, see https://gerrit.wikimedia.org/r/#/q/project:mediawiki/skins/Refreshed

https://gerrit.wikimedia.org/r/470234

Diffusion mentioned this in R1893:69ba79b73f7c: Fix focus on 'More' drop down when tabbing in skin Refreshed..Oct 31 2018, 4:00 PM
gerritbot added a comment.Jan 5 2020, 11:42 PM

Change 470621 abandoned by MtMNC:
Fix focus on 'More' drop down when tabbing in skin Refreshed.

Reason:
I believe this is incompatible with the latest major release

https://gerrit.wikimedia.org/r/470621

Restricted Application added a subscriber: MacFan4000. · View Herald TranscriptJan 5 2020, 11:42 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 6 2020, 12:10 AM
MtMNC closed this task as Resolved.Aug 16 2021, 3:20 AM
MtMNC claimed this task.

Marking as resolved as the dropdown is now accessible through tab focus. Any future issues regarding the more button or tab focus can be placed in a new issue.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits