Page MenuHomePhabricator

Editing caret is off by several pixels in VisualEditor wikitext editor.
Closed, ResolvedPublic

Description

I dog food Minerva by using it on desktop.

I edit MediaWiki.org a lot via VisualEditor and this bug is plaguing me as it makes it near impossible to edit.

Let me know how to fix it and I will personally write the patch. I assume this is due to an off-style.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2018, 7:39 PM

I tested on https://www.mediawiki.org/wiki/Project:Sandbox?useskin=minerva and the most confounding this is that NWE actually loads. Isn't Minerva supposed to always load the mobile wikitext editor? (T198765) Fascinating.

The problem only appears when syntax highlighting is enabled. You can disable it in the options menu:

There is a very similar issue affecting Timeless: T205154: The text displays one line above the cursor when syntax highlighting in while using the 2017 wikitext editor

The elements .ve-ce-documentNode and .CodeMirror need to have the same margin/padding/border, and it seems they don't.

matmarex claimed this task.Sep 27 2018, 7:59 PM

Change 463366 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror: Fix padding to match VisualEditor's padding

https://gerrit.wikimedia.org/r/463366

Isn't Minerva supposed to always load the mobile wikitext editor? (T198765) Fascinating.

Only when it operates in mobile mode on the mobile domain. If it operates on the desktop domain it pulls down all the code desktop does.. including gadgets. It's a skin now after all and targets=desktop in this mode :)

Change 463366 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror: Fix padding to match VisualEditor's padding

https://gerrit.wikimedia.org/r/463366

Isn't Minerva supposed to always load the mobile wikitext editor? (T198765) Fascinating.

Only when it operates in mobile mode on the mobile domain. If it operates on the desktop domain it pulls down all the code desktop does.. including gadgets. It's a skin now after all and targets=desktop in this mode :)

Right, but the mobile editor still loads. I think something about its initialization is buggy. On https://www.mediawiki.org/wiki/OOUI/Using_OOUI_in_MediaWiki?useskin=minerva, I get the desktop editor when clicking the page edit link, but the mobile editor when clicking the section edit links. Anyway, hopefully this will go away with T198765.

Restricted Application added projects: User-Ryasmeen, Community-Tech. · View Herald TranscriptSep 27 2018, 9:52 PM