Page MenuHomePhabricator
Create Task
Maniphest T205918

[betalabs] NPP: 'Potential issues' do not display 'None' and 'Copyvio' filters
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
Etonkovidova
Oct 1 2018, 7:21 PM
Tags
Referenced Files
F26271070: Screen Shot 2018-10-01 at 20.30.09.png
Oct 2 2018, 12:31 AM
F26270961: Screen Shot 2018-10-01 at 4.40.10 PM.png
Oct 2 2018, 12:05 AM
F26269573: Screen Shot 2018-10-01 at 12.16.46 PM.png
Oct 1 2018, 7:21 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
SBisson
Stashbot

Description

Note:enwiki( wmf.23) - https://en.wikipedia.org/wiki/Special:NewPagesFeed?ores=1&copyvio=1 - displays all 'Potential issues' filter options correctly.

In betalabs two options are missing for NPP pages:

Screen Shot 2018-10-01 at 12.16.46 PM.png (595×764 px, 118 KB)

If this is some sort experimentation with a proposed feature flag, then it's ok. However, AfC filters do have 'Copyvio' option and still show the result for 'copyvio' filter but without 'copyvio' indication:

Screen Shot 2018-10-01 at 4.40.10 PM.png (390×1 px, 118 KB)

Details

SubjectRepoBranchLines +/-
Hide copyvio, none afc filter options behind flagmediawiki/extensions/PageTriagewmf/1.32.0-wmf.23+2 -0
Hide copyvio, none afc filter options behind flagmediawiki/extensions/PageTriagemaster+2 -0
Hide copyvio, none afc filter options behind flagmediawiki/extensions/PageTriagewmf/1.32.0-wmf.24+2 -0
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Oct 1 2018, 7:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 1 2018, 7:21 PM
Etonkovidova updated the task description. (Show Details)Oct 2 2018, 12:05 AM
SBisson closed this task as Invalid.Oct 2 2018, 12:31 AM

This is by design and it behaves as expected for me

Screen Shot 2018-10-01 at 20.30.09.png (554×1 px, 198 KB)

SBisson reopened this task as Open.Oct 2 2018, 4:52 PM
SBisson claimed this task.

It turns out the copyvio feature flag was not quite correct.

SBisson edited projects, added Growth-Team (Sprint 0 (Growth Team)), PageTriage; removed Growth-Team.Oct 2 2018, 4:53 PM
gerritbot subscribed.Oct 2 2018, 4:53 PM

Change 463991 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@master] Hide copyvio, none afc filter options behind flag

https://gerrit.wikimedia.org/r/463991

gerritbot added a project: Patch-For-Review.Oct 2 2018, 4:53 PM
SBisson moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 2 2018, 4:53 PM
gerritbot added a comment.Oct 2 2018, 7:44 PM

Change 463991 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@master] Hide copyvio, none afc filter options behind flag

https://gerrit.wikimedia.org/r/463991

gerritbot added a comment.Oct 2 2018, 7:49 PM

Change 464021 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.24] Hide copyvio, none afc filter options behind flag

https://gerrit.wikimedia.org/r/464021

SBisson moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Oct 2 2018, 7:58 PM
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 2 2018, 8:00 PM
Etonkovidova closed this task as Resolved.Oct 2 2018, 8:42 PM
gerritbot added a comment.Oct 2 2018, 11:33 PM

Change 464021 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.24] Hide copyvio, none afc filter options behind flag

https://gerrit.wikimedia.org/r/464021

Stashbot subscribed.Oct 2 2018, 11:38 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-02T23:38:39Z] <ladsgroup@deploy1001> Synchronized php-1.32.0-wmf.24/extensions/PageTriage/modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.underscore: SWAT: [[gerrit:464021|Hide copyvio, none afc filter options behind flag (T205918)]] (duration: 00m 56s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 3 2018, 12:01 AM
gerritbot added a comment.Oct 3 2018, 7:30 PM

Change 464397 had a related patch set uploaded (by Catrope; owner: Sbisson):
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.23] Hide copyvio, none afc filter options behind flag

https://gerrit.wikimedia.org/r/464397

gerritbot added a comment.Oct 3 2018, 11:14 PM

Change 464397 merged by jenkins-bot:
[mediawiki/extensions/PageTriage@wmf/1.32.0-wmf.23] Hide copyvio, none afc filter options behind flag

https://gerrit.wikimedia.org/r/464397

Stashbot added a comment.Oct 3 2018, 11:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-03T23:29:47Z] <catrope@deploy1001> Synchronized php-1.32.0-wmf.23/extensions/PageTriage/: Hide copyvio AFC filter option behind flag (T205918) (duration: 00m 57s)

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 4 2018, 12:01 AM
• Petar.petkovic removed a project: Patch-For-Review.Oct 6 2018, 2:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL