Maniphest T206153

OOUI MultilineTextInputWidget (PHP) crashes when using 'rows' option
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Oct 3 2018, 6:29 PM

Description

OOUI MultilineTextInputWidget (PHP) crashes when using 'rows' option.

Uncaught Error: Call to a member function setAttributes() on null in MultilineTextInputWidget.php:31

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.29.1	mediawiki/core	master	+484 -1 K
	MultilineTextInputWidget: Fix fatal	oojs/ui	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned Here: T206046: Host OOUI PHP demo (and all others?) on a PHP 7 capable server, because it needs PHP 7
T206155: OOUI comparison tests are not being generated

Event Timeline

matmarex created this task.Oct 3 2018, 6:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 6:29 PM

matmarex claimed this task.Oct 3 2018, 6:30 PM

matmarex triaged this task as Unbreak Now! priority.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 3 2018, 6:30 PM

This is in the v0.29.0 release made yesterday, and it is preventing us from updating OOUI in MediaWiki.

There are several reasons why this was allowed to happen:

Automatic tests are broken and no one noticed (T206155)
Canonical demo app is down (T206046)
Clearly, no one tested the code locally before submitting and merging it

Change 464385 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] MultilineTextInputWidget: Fix fatal

https://gerrit.wikimedia.org/r/464385

gerritbot added a project: Patch-For-Review.Oct 3 2018, 6:47 PM

Change 464385 merged by jenkins-bot:
[oojs/ui@master] MultilineTextInputWidget: Fix fatal

https://gerrit.wikimedia.org/r/464385

Volker_E moved this task from Backlog to OOUI-0.29.1 on the OOUI board.Oct 3 2018, 8:08 PM

Volker_E edited projects, added OOUI (OOUI-0.29.1); removed OOUI.

Jdforrester-WMF closed this task as Resolved.Oct 3 2018, 9:47 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Liuxinyu970226 unsubscribed.Oct 4 2018, 3:55 AM

Change 464607 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

gerritbot added a project: Patch-For-Review.Oct 4 2018, 5:13 PM

Volker_E removed a project: Patch-For-Review.Oct 4 2018, 6:12 PM

Change 464607 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.1