Page MenuHomePhabricator

OOUI MultilineTextInputWidget (PHP) crashes when using 'rows' option
Closed, ResolvedPublic

Description

OOUI MultilineTextInputWidget (PHP) crashes when using 'rows' option.

Uncaught Error: Call to a member function setAttributes() on null in MultilineTextInputWidget.php:31

Event Timeline

matmarex created this task.Oct 3 2018, 6:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 6:29 PM
matmarex claimed this task.Oct 3 2018, 6:30 PM
matmarex triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 3 2018, 6:30 PM

This is in the v0.29.0 release made yesterday, and it is preventing us from updating OOUI in MediaWiki.

There are several reasons why this was allowed to happen:

  • Automatic tests are broken and no one noticed (T206155)
  • Canonical demo app is down (T206046)
  • Clearly, no one tested the code locally before submitting and merging it

Change 464385 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] MultilineTextInputWidget: Fix fatal

https://gerrit.wikimedia.org/r/464385

Change 464385 merged by jenkins-bot:
[oojs/ui@master] MultilineTextInputWidget: Fix fatal

https://gerrit.wikimedia.org/r/464385

Volker_E moved this task from Backlog to OOUI-0.29.1 on the OOUI board.Oct 3 2018, 8:08 PM
Volker_E edited projects, added OOUI (OOUI-0.29.1); removed OOUI.
Jdforrester-WMF closed this task as Resolved.Oct 3 2018, 9:47 PM
Jdforrester-WMF removed a project: Patch-For-Review.

Change 464607 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

Change 464607 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607