Maniphest T206155

OOUI comparison tests are not being generated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Oct 3 2018, 6:30 PM

Description

OOUI comparison tests (comparing JS output to PHP output of many widgets) are not being generated, and thus don't run. These tests are pretty much the only kind of automatic testing we have.

Details

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.29.1	mediawiki/core	master	+484 -1 K
build: Fail in CI if there are uncommited build artefacts	oojs/ui	master	+17 -1
tests: Commit JS/PHP comparison test suite	oojs/ui	master	+73 K -11
tests: Fix generation of JS/PHP comparison test suite	oojs/ui	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T206153: OOUI MultilineTextInputWidget (PHP) crashes when using 'rows' option

Event Timeline

matmarex created this task.Oct 3 2018, 6:30 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2018, 6:30 PM

ruby bin/testsuitegenerator.rb src php >/dev/null
Generated 542 test cases.
* ActionFieldLayout: 0
* FieldLayout: 0
* FieldsetLayout: 0
* FormLayout: 0
* HorizontalLayout: 0
* PanelLayout: 0
* ButtonGroupWidget: 0
* ButtonInputWidget: 0
* ButtonWidget: 0
* CheckboxInputWidget: 0
* CheckboxMultiselectInputWidget: 0
* ComboBoxInputWidget: 0
* DropdownInputWidget: 0
* HiddenInputWidget: 15
* IconWidget: 0
* IndicatorWidget: 0
* LabelWidget: 0
* MultilineTextInputWidget: 0
* NumberInputWidget: 0
* ProgressBarWidget: 0
* RadioInputWidget: 0
* RadioSelectInputWidget: 0
* SearchInputWidget: 527
* TextInputWidget: 0

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptOct 3 2018, 6:31 PM

matmarex mentioned this in T206153: OOUI MultilineTextInputWidget (PHP) crashes when using 'rows' option.Oct 3 2018, 6:33 PM

Change 464383 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Fix generation of JS/PHP comparison test suite

https://gerrit.wikimedia.org/r/464383

gerritbot added a project: Patch-For-Review.Oct 3 2018, 6:46 PM

Change 464387 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] Commit JS/PHP comparison test suite

https://gerrit.wikimedia.org/r/464387

Volker_E moved this task from Backlog to OOUI-0.29.1 on the OOUI board.Oct 3 2018, 8:08 PM

Volker_E edited projects, added OOUI (OOUI-0.29.1); removed OOUI.

Change 464383 merged by jenkins-bot:
[oojs/ui@master] tests: Fix generation of JS/PHP comparison test suite

https://gerrit.wikimedia.org/r/464383

Jdforrester-WMF closed this task as Resolved.Oct 3 2018, 9:47 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Change 464387 merged by jenkins-bot:
[oojs/ui@master] tests: Commit JS/PHP comparison test suite

https://gerrit.wikimedia.org/r/464387

Change 464452 had a related patch set uploaded (by Bartosz Dziewoński; owner: Jforrester):
[oojs/ui@master] build: Fail in CI if there are uncommited build artefacts

https://gerrit.wikimedia.org/r/464452

gerritbot added a project: Patch-For-Review.Oct 3 2018, 11:25 PM

Change 464452 merged by jenkins-bot:
[oojs/ui@master] build: Fail in CI if there are uncommited build artefacts

https://gerrit.wikimedia.org/r/464452

Jdforrester-WMF removed a project: Patch-For-Review.Oct 4 2018, 12:29 AM

Liuxinyu970226 unsubscribed.Oct 4 2018, 3:55 AM

Change 464607 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607

gerritbot added a project: Patch-For-Review.Oct 4 2018, 5:14 PM

Volker_E removed a project: Patch-For-Review.Oct 4 2018, 6:12 PM

Change 464607 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.1

https://gerrit.wikimedia.org/r/464607