Maniphest T206427

Thanks: Remove unexpected '<' character from selector
Closed, InvalidPublic
Actions

Assigned To

Authored By

	Mh-3110
	Oct 7 2018, 8:40 PM

Description

In modules/ext.thanks.flowthank.js line 13 there is an unexpected '<' character in a selector that needs to be removed

Details

	Subject	Repo	Branch	Lines +/-
	Remove unexpected character from selector	mediawiki/extensions/Thanks	master	+1 -1

Customize query in gerrit

Event Timeline

Mh-3110 created this task.Oct 7 2018, 8:40 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 7 2018, 8:40 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

function findPostAuthorFromThankLink( $thankLink ) {
        // We can't use 'closest' directly because .flow-author is a cousin
        // of $thankLink rather than its ancestor
        return $( $thankLink.findWithParent( '< .flow-post .flow-author a.mw-userlink' )[ 0 ] ).text().trim();
}

Legoktm renamed this task from [Thanks extension]-Remove unexpected '<' character from selector to Thanks: Remove unexpected '<' character from selector.Oct 8 2018, 2:18 AM

Legoktm updated the task description. (Show Details)

Change 465207 had a related patch set uploaded (by Mh-3110; owner: Mahuton):
[mediawiki/extensions/Thanks@master] Remove unexpected character from selector

https://gerrit.wikimedia.org/r/465207

gerritbot added a project: Patch-For-Review.Oct 8 2018, 8:13 PM

@Mh-3110 thanks for looking into this

The documentation for findWithParent claims that it uses the "<" character.

I don't know if it's useful in this case of not but I would like to see a bit of analysis about what the DOM looks like and what is $thankLink in this context.

@SBisson ,
Thanks for the documentation. I don't think this is useful here but as it use is mentioned in the module documentation then it should be kept. I will close this ticket as invalid. My bad.
Thanks

Closing per the latest comment

Change 465207 abandoned by Catrope:
Remove unexpected character from selector

Reason:
Per submitter on phab task

https://gerrit.wikimedia.org/r/465207

Thanks: Remove unexpected '<' character from selectorClosed, InvalidPublicActions

Description

Details

Event Timeline

Thanks: Remove unexpected '<' character from selector
Closed, InvalidPublic
Actions