Page MenuHomePhabricator

Add a new application field for waitlist status
Closed, ResolvedPublic

Description

We want to collect some data on how many applications are made to waitlisted partners, and probe questions like how long those applications remain open. This is hard to do when the only waitlist information we have is whether the corresponding Partner is currently waitlisted. We have no historical data per-application.

This is a field that would be True if the application was filed while the partner was waitlisted, and False otherwise. It wouldn't change when the partner was unwaitlisted, but should be set to True if the app is still pending or under discussion when a partner is set to waitlisted.

There shouldn't be a time when waitlist_status should need to be changed from True to False, we're only interested in tracking what the waitlist status was at the time of application.

Event Timeline

Samwalton9 moved this task from Incoming tasks to Open tasks on the Library-Card-Platform board.

The purpose being that we could track how long applications were waitlisted for before being accepted (something that's hard to track while the only waitlist flag is on the partner), and potentially even send differently worded emails if an application that was waitlisted is eventually accepted.

I would like to work on this task.How do i get started?Where can i find the codebase?

Hi @Ahmed282000 - the codebase lives at https://github.com/wikipedialibrary/twlight; the main README and https://github.com/WikipediaLibrary/TWLight/blob/master/docs/developer.md should help you with setup. Let me know if you have any questions :)

Hello @Samwalton9 having few doubts here

(1) Should we add waitlist_status in some django-templates also, or is this not required right now?

(2) Also I could not understand this point completely

we're only interested in tracking what the waitlist status was at the time of application.

(1) Should we add waitlist_status in some django-templates also, or is this not required right now?

That's out of scope for this task - we'll use this data in some templates later.

(2) Also I could not understand this point completely

we're only interested in tracking what the waitlist status was at the time of application.

I meant to say that once an application has the waitlist_status flag set, we shouldn't need to modify it anywhere else.

Thank you for the clarifications :)
I have completed the steps mentioned and raised a PR at https://github.com/WikipediaLibrary/TWLight/pull/446

jsn.sherman added a subscriber: jsn.sherman.

@lalit97 's code has been deployed. Thanks!