Page MenuHomePhabricator
Create Task
Maniphest T207667

Long words destroy the two column layout
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Long, unbreakable words in the diff view destroy the layout:

image.png (299×1 px, 59 KB)

This came up in a test for T195721.

Solution: The .mw-twocolconflict-split-column CSS class already sets break-word, but this does not have an effect as long as overflow: hidden is not set. The later is missing.

Details

SubjectRepoBranchLines +/-
Break long wordsmediawiki/extensions/TwoColConflictmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Oct 22 2018, 3:35 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptOct 22 2018, 3:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
thiemowmde mentioned this in T195721: Support JS enhanced editing on the merge view (No. 7).Oct 22 2018, 3:36 PM
Lea_WMDE moved this task from Backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.Oct 23 2018, 10:10 AM
Lea_WMDE added a project: WMDE-QWERTY-Sprint-2018-10-23.Oct 23 2018, 1:20 PM
Lea_WMDE set the point value for this task to 2.
Lea_WMDE moved this task from Tickets ready for pickup to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.
Andrew-WMDE subscribed.Oct 24 2018, 10:38 AM

Why not use word-break: break-all;?

thiemowmde added a comment.Oct 24 2018, 12:20 PM

Sounds good. If it works without overflow: hidden, go ahead.

Andrew-WMDE claimed this task.Oct 24 2018, 1:43 PM
gerritbot subscribed.Oct 24 2018, 1:44 PM

Change 469427 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Break long words

https://gerrit.wikimedia.org/r/469427

gerritbot added a project: Patch-For-Review.Oct 24 2018, 1:44 PM
Andrew-WMDE mentioned this in rESCC0bb46ad50e0b: Break long words.Oct 24 2018, 1:44 PM
Andrew-WMDE moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2018-10-23 board.Oct 24 2018, 1:51 PM
gerritbot added a comment.Oct 26 2018, 7:42 PM

Change 469427 merged by Thiemo Kreuz (WMDE):
[mediawiki/extensions/TwoColConflict@master] Break long words

https://gerrit.wikimedia.org/r/469427

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 26 2018, 8:00 PM
WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2018-10-23 board.Oct 28 2018, 7:10 AM
Lea_WMDE closed this task as Resolved.Oct 29 2018, 11:50 AM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-10-23 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL