Page MenuHomePhabricator

Long words destroy the two column layout
Closed, ResolvedPublic2 Estimated Story Points

Description

Long, unbreakable words in the diff view destroy the layout:

This came up in a test for T195721.

Solution: The .mw-twocolconflict-split-column CSS class already sets break-word, but this does not have an effect as long as overflow: hidden is not set. The later is missing.

Event Timeline

Restricted Application added a project: TCB-Team. · View Herald TranscriptOct 22 2018, 3:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lea_WMDE set the point value for this task to 2.

Why not use word-break: break-all;?

Sounds good. If it works without overflow: hidden, go ahead.

Change 469427 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/TwoColConflict@master] Break long words

https://gerrit.wikimedia.org/r/469427

Change 469427 merged by Thiemo Kreuz (WMDE):
[mediawiki/extensions/TwoColConflict@master] Break long words

https://gerrit.wikimedia.org/r/469427

Lea_WMDE closed this task as Resolved.Oct 29 2018, 11:50 AM
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2018-10-23 board.