jkroll (Johannes Kroll (WMDE))
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2014, 1:58 PM (155 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Johannes Kroll (WMDE)

Recent Activity

Thu, Nov 16

jkroll added a comment to T180123: Define changes within wikidiff2 for mobile.

what will be done
Similar to the desktop diff, moved paragraphs will be detected, links inserted between them, and word diffs between the moved paragraphs will be displayed.

Thu, Nov 16, 5:57 PM · WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team, German-Community-Wishlist

Oct 10 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

It should be restarted after a native PHP extension is upgraded.

HHVM was restarted after installing the new package (otherwise it would not load the revised modules anyway). The cache is persistent on disk, though (but we can prune it manually).

Oct 10 2017, 2:26 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend
jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

The wikidiff2 patch introduced new parameters with default values to wikidiff2_do_diff() and wikidiff2_inline_diff(). Possible explanation for the crashes: HHVM caches data for performance reasons, including function signatures provided by extensions. Between deploying the new wikidiff2 version on the 15th and the HHVM unattended-upgrade on the 28th, HHVM would cache the old signatures in memory. The new wikidiff2 would have the new signatures though, and the PHP code is already patched to use them, causing a mismatch.

Oct 10 2017, 1:47 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Oct 9 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

On the 28th, the update to HHVM 3.18.5 was installed via unattended-upgrades. That might have fixed it (or could be entirely unrelated/coincidental).

Oct 9 2017, 3:34 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend
jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

Also, getting a core file when this happens would be helpful. The core pattern was set to /data/project/cores/ but /data doesn't seem to be mounted. I've temporarily set it to /tmp but I'm not sure if it will be overwritten by the next puppet run.

Oct 9 2017, 2:43 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend
jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

Thanks @MaxSem. I've tried to reproduce it on deployment-mediawiki04.eqiad.wmflabs without success. According to logs, the last crash was on Sep 28.

Oct 9 2017, 2:18 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Oct 3 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

@MaxSem: Jkroll

Oct 3 2017, 1:21 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Oct 2 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

This seems to be related to the new wikidiff2. I wrote the moved-paragraphs patch, and I have been trying to reproduce this problem for the last couple days. It's not reproducible for me on apache/zend. I can't reproduce it with my distro-provided hhvm 3.22.0 either. Next, I tried to install mw-vagrant as per MoritzMuehlenhoff's suggestion in T176217. After working around T152801 and provisioning the box, I found that it wasn't running hhvm at all. Unsurprisingly, I couldn't reproduce the problem there, so I gave up on mw-vagrant. Instead I built HHVM-3.18.5 from source. I cannot reproduce the problem with that version either. I can display diffs just fine, including the mobile diff, and haven't seen any stack traces or suspiscious log entries.

Oct 2 2017, 3:35 PM · WMDE-QWERTY-Team-Board, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Sep 28 2017

jkroll added a comment to T176217: Test the new wikidiff2 version on beta.

Recompiling wikidiff2 is not the issue here, I wrote the moved-paragraphs patch.

Sep 28 2017, 1:19 PM · User-Addshore, wikidiff2, MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, TCB-Team
jkroll added a comment to T176217: Test the new wikidiff2 version on beta.

I'm trying to reproduce it on my local machine. With my distro-supplied hhvm 3.22.0 (rel) I don't see anything suspicious in the logs at all so far. Can you pin down when the asserts happen? Probably when generating a mobile diff page?

Sep 28 2017, 12:07 PM · User-Addshore, wikidiff2, MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, TCB-Team
jkroll added a comment to T176217: Test the new wikidiff2 version on beta.

can you (or anyone) help interpret this output? I do x86 assembly, but I'm not familiar with php jit bytecode :)

Sep 28 2017, 11:44 AM · User-Addshore, wikidiff2, MediaWiki-History-or-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team-Board, TCB-Team

Sep 21 2017

jkroll added a comment to T173822: CatGraph on commons missing subcategories.

After some investigation, I found that the data in CatGraph is actually OK. The problem was in the catgraph-jsonp tool which makes CatGraph queries available to JavaScript code. catgraph-jsonp has some logic to catch case errors in category title input. In an edge case involving spaces in titles, catgraph-jsonp erroneously fetches the page_id of a redirection page. This commit fixes it. It's already deployed.

Sep 21 2017, 12:46 PM · WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Team-Board, DeepCat-Gadget, Catgraph, TCB-Team

Sep 5 2017

jkroll added a comment to T146781: Show changes in moved text chunks (C++).

@MaxSem I added some code to your fuzz test which hits the other code paths in the patch. It just creates shuffled lines basically.

Sep 5 2017, 1:16 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs

Jul 25 2017

jkroll added a comment to T146781: Show changes in moved text chunks (C++).

@MaxSem updated again :) Anything else you want changed? Or can you give a +1? Thanks

Jul 25 2017, 2:09 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs

Jul 24 2017

jkroll updated subscribers of T146781: Show changes in moved text chunks (C++).

@MaxSem Thanks for looking into https://gerrit.wikimedia.org/r/#/c/356582/. I updated it. Could you review this and https://gerrit.wikimedia.org/r/#/c/319866/ so we can get it merged?
@tstarling You could also review this, thanks!

Jul 24 2017, 3:34 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs

Jul 4 2017

jkroll closed T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold as Resolved.
Jul 4 2017, 3:37 PM · Wikimedia-Hackathon-2017, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
jkroll closed T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold, a subtask of T146781: Show changes in moved text chunks (C++), as Resolved.
Jul 4 2017, 3:37 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs
jkroll added a comment to T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold.

We benchmarked this and set the default to 25. The threshold is configurable in LocalSettings.

Jul 4 2017, 3:36 PM · Wikimedia-Hackathon-2017, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team

Jun 20 2017

jkroll created T168410: Migrate php-compile-hhvm test to jessie.
Jun 20 2017, 3:31 PM · Patch-For-Review, Continuous-Integration-Infrastructure, wikidiff2, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Jun 16 2017

jkroll added a comment to T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.
<?php
function hi($str) {
    print($str . "\n");
}
print wikidiff2_do_diff("hello\nworld\n", "world\nhello\n", 1, 1, "extra parameter that shouldn't be here");
hi("you should not see this string", "world");
?>
Jun 16 2017, 2:09 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
jkroll added a comment to T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.

This, of course, cannot work:

Jun 16 2017, 1:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Jun 14 2017

jkroll added a comment to T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.

Well the solution would be to make MediaWiki work with both the old and the new version of Wikidiff2, right?

Jun 14 2017, 1:03 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Jun 1 2017

Nemo_bis awarded T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2 a Doubloon token.
Jun 1 2017, 2:07 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Apr 12 2017

jkroll added a comment to T156439: Improve diff to handle splitting a paragraph.

@jkroll Is it fair to say that T146781: Show changes in moved text chunks (C++) is similar to this task?

Apr 12 2017, 3:20 PM · MediaWiki-History-or-Diffs, Community-Wishlist-Survey-2016

Apr 3 2017

jkroll closed T105489: [catgraph] switch hostmap to lighttpd as Resolved.
Apr 3 2017, 2:40 PM · Catgraph, TCB-Team
jkroll added a comment to T105489: [catgraph] switch hostmap to lighttpd.

Actually, this is already done :) The hostmap has been using lighttpd for some time now.

Apr 3 2017, 2:39 PM · Catgraph, TCB-Team

Mar 20 2017

jkroll added a comment to T160077: UI changes for showing changes in moved text chunks.

Taking Tim Starling's feedback on Gerrit into account, I've inserted named anchors in the diff output for moved paragraphs. The + and - symbols are replaced with "left shift" (<<) and "right shift" (>>) symbols. Hyperlinks allow to move between source and destination paragraphs. This is a good solution because

  • it shows which paragraphs were moved, even if they weren't changed
  • it's plain text, so it can be searched for in the browser
  • it doesn't require JavaScript or visual changes which have to be adjusted to each Skin, such as different background colors for moved blocks

The code is straightforward and doesn't have performance implications, so it doesn't require a separate patch set.

Mar 20 2017, 4:19 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team

Mar 9 2017

jkroll created T160077: UI changes for showing changes in moved text chunks.
Mar 9 2017, 2:59 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, WMDE-QWERTY-Team-Board, German-Community-Wishlist, MediaWiki-History-or-Diffs, TCB-Team
Lea_WMDE awarded T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold a Cookie token.
Mar 9 2017, 2:55 PM · Wikimedia-Hackathon-2017, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
jkroll added a parent task for T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold: T146781: Show changes in moved text chunks (C++).
Mar 9 2017, 2:54 PM · Wikimedia-Hackathon-2017, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team
jkroll added a subtask for T146781: Show changes in moved text chunks (C++): T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold.
Mar 9 2017, 2:54 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs
jkroll created T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold.
Mar 9 2017, 2:54 PM · Wikimedia-Hackathon-2017, MediaWiki-History-or-Diffs, WMDE-QWERTY-Team-Board, TCB-Team

Feb 27 2017

jkroll added a comment to T146781: Show changes in moved text chunks (C++).

It turns out that Tool Labs doesn't have the Wikidiff2 extension installed. Mediawiki falls back to some default diff implementation in that case (probably PHP) which produces slightly different output than Wikidiff2. I have set up two Labs instances with *unpatched* and with *patched* wikidiff2, so we can show a side-by-side diff of the diff code with and without our patch, yes that sentence makes sense.

Feb 27 2017, 7:44 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs
jkroll added a comment to T159162: Web proxies don't show up.

You're right, sorry for the confusion. Thanks!

Feb 27 2017, 6:19 PM · Cloud-Services
jkroll created T159162: Web proxies don't show up.
Feb 27 2017, 4:51 PM · Cloud-Services
jkroll added a comment to T158645: Request creation of wikidiff2-wmde-dev labs project.

Great. Thanks @Andrew !

Feb 27 2017, 2:02 PM · Cloud-Services

Feb 21 2017

jkroll added a comment to T146781: Show changes in moved text chunks (C++).

Here are some examples before/after the patch.

Feb 21 2017, 4:39 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs
jkroll added a comment to T146781: Show changes in moved text chunks (C++).

The case where a paragraph appears to have been moved to several places, and words deleted from the inserted copies, can't be displayed correctly. The workaround which is currently implemented shows only the first inserted paragraph as "moved". Users will rarely, if ever, see this edge case, so it is probably sufficient. Other suggestions to solve this are welcome.

Feb 21 2017, 4:31 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team-Board, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, TCB-Team, MediaWiki-History-or-Diffs
jkroll created T158645: Request creation of wikidiff2-wmde-dev labs project.
Feb 21 2017, 1:42 PM · Cloud-Services

Sep 1 2016

jkroll closed T142720: Create testing VM and install software as Resolved.
Sep 1 2016, 2:20 PM · TCB-Team, German-Community-Wishlist
jkroll closed T142720: Create testing VM and install software, a subtask of T139603: Show text changes when moving text chunks (#2), as Resolved.
Sep 1 2016, 2:20 PM · TCB-Team (Oct2016-March2017), MediaWiki-History-or-Diffs, German-Community-Wishlist-Main-Wishes
jkroll added a comment to T142720: Create testing VM and install software.

Created an instance in the catgraph project for testing. Installed mediawiki with wikidiff2 extension. Setup webproxy. Wiki Link: https://mwdiffstuff.wmflabs.org/core/index.php/Main_Page

Sep 1 2016, 2:19 PM · TCB-Team, German-Community-Wishlist

Aug 11 2016

jkroll created T142720: Create testing VM and install software.
Aug 11 2016, 3:34 PM · TCB-Team, German-Community-Wishlist

Aug 10 2016

jkroll added a comment to T141867: Investigate how to move files with history from wikipedia to commons .

As far as I can tell by https://de.wikipedia.org/wiki/Kategorie:Datei:Commonsf%C3%A4hig there are currently just under 400 files to move (most of which are logos)

Aug 10 2016, 8:44 PM · Move-Files-To-Commons, User-Addshore, German-Community-Wishlist, TCB-Team, TCB-Team-Sprint-2016-08-02
jkroll added a comment to T138922: Investigate what we can do to solve Wish #2 - Show text changes when moving text blocks.

Hi Leszek,

Aug 10 2016, 8:02 PM · TCB-Team-Sprint-2016-08-11, TCB-Team-Sprint-2016-08-02, Community-Tech, TCB-Team-Sprint-2016-07-14, Design, WMDE-Design, TCB-Team-Sprint-2016-06-29, TCB-Team, German-Community-Wishlist

May 4 2016

jkroll closed T133532: [Bug] Catgraph JSONP does not work with categories that contain a colon as Resolved.
May 4 2016, 3:49 PM · TCB-Team-Sprint-2016-05-04, DeepCat-Gadget, TCB-Team
jkroll added a comment to T133532: [Bug] Catgraph JSONP does not work with categories that contain a colon.

my cat accidentally fixed it.
something on labs is playing up currently, if you get "Name or service not known" errors or similar, try again in a couple minutes.

May 4 2016, 3:15 PM · TCB-Team-Sprint-2016-05-04, DeepCat-Gadget, TCB-Team

Mar 15 2016

jkroll added a comment to T129749: New project: Petscan.

The CatGraph project is running and in use by several tools we developed at WMDE. A graph exists for every wiki available on Labs, including Commons. Carrying the page IDs for each wiki takes a sizable amount of RAM; our tools only use the categories, and there was never any interest by community developers to use CatGraph, so I removed the graphs carrying the page IDs at some point. It is kind of frustrating to me personally but I can't force anybody to use our work. After I'm back from vacation, I could add the graphs back with some effort, if there is interest.

Mar 15 2016, 3:51 AM · Cloud-Services

Feb 2 2016

jkroll added a comment to T117559: [DeepCat] Bug: search should work no matter if the category name starts with a small or capital letter.

This should be done. See pull request mentioned above.

Feb 2 2016, 3:09 PM · TCB-Team-Sprint-2016-01-27, German-Community-Wishlist, DeepCat-Gadget, TCB-Team

Jan 27 2016

jkroll created T124957: New instance fails to mount /home.
Jan 27 2016, 7:45 PM · Cloud-Services

Nov 25 2015

jkroll added a comment to T119553: [Deepcat] improving search result list with more details for Wikimedia Commons.

Those could be useful, but DeepCat is only meant to make recursive search requests, not change or enhance the search results itself. So I do not think this is within the scope of DeepCat.

Nov 25 2015, 12:03 PM · German-Community-Wishlist, DeepCat-Gadget, TCB-Team

Nov 24 2015

jkroll added a comment to T105868: Search gadget for subcategories and intersections search (2013).

@Kersti
I get completely different results than you. When I log out of commons, i.e. when the Gadget is disabled, I get similar result sizes for your search queries.

Nov 24 2015, 8:13 AM · German-Community-Wishlist-Main-Wishes, Epic, DeepCat-Gadget, TCB-Team

Nov 23 2015

jkroll added a comment to T105868: Search gadget for subcategories and intersections search (2013).

when you use those links, the request goes directly to the server, without an opportunity for the DeepCat Gadget to intercept your query on the client side.
Please try the following:

  • log into your account on Commons.
  • make sure that you have the gadget enabled for Commons, i.e. by inserting the following snippet into your common.js
Nov 23 2015, 9:02 AM · German-Community-Wishlist-Main-Wishes, Epic, DeepCat-Gadget, TCB-Team

Nov 19 2015

jkroll added a comment to T105868: Search gadget for subcategories and intersections search (2013).

@Kersti
Can you please clarify for each search string:

  • what you intend to search for
  • what results you got instead
Nov 19 2015, 11:52 PM · German-Community-Wishlist-Main-Wishes, Epic, DeepCat-Gadget, TCB-Team

Sep 7 2015

jkroll added a comment to T111694: Bypass query length limit for incategory search.

It's probably easiest to just allow the maximum query length to be bypassed if there's an incategory operator anywhere in it, then. In the interests of resolving this once and for all, now would be the time to let me know if that doesn't work. :-)

Sep 7 2015, 10:29 PM · WMF-deploy-2015-09-15_(1.26wmf23), DeepCat-Gadget, Discovery-Search (Current work), TCB-Team, Patch-For-Review
jkroll added a comment to T111694: Bypass query length limit for incategory search.

@Ironholds I am referring to https://gerrit.wikimedia.org/r/#/c/236195/. And, technically, it's not a bug..

So that we can avoid the cat-and-mouse situation where we change the query length exception only to find out afterwards about another kind of query that the gadget can emit that is not covered by the exception, please provide an exhaustive list of all query signatures that your DeepCat gadget can query the API with. Thanks!

Sep 7 2015, 5:13 PM · WMF-deploy-2015-09-15_(1.26wmf23), DeepCat-Gadget, Discovery-Search (Current work), TCB-Team, Patch-For-Review

Sep 4 2015

jkroll added a comment to T107947: Set a hard byte or character limit for queries.

So what are your opinions on this? Do you think either of these would work? If not, do you see an alternative?

Sep 4 2015, 12:37 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-08-18_(1.26wmf19), User-notice, Patch-For-Review, Discovery-Search (Current work)

Sep 2 2015

jkroll added a comment to T107947: Set a hard byte or character limit for queries.

I'm sorry that the work you've invested into this might be wasted. I wish we knew about it much earlier so that we could have helped you sooner. But, as I said, cluster stability and performance must come first. If you have users that are unhappy with this outcome, then I would be happy to explain it to them.

Sep 2 2015, 12:41 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-08-18_(1.26wmf19), User-notice, Patch-For-Review, Discovery-Search (Current work)

Aug 19 2015

jkroll added a comment to T107947: Set a hard byte or character limit for queries.

@Deskana @Tfinc
I work on this gadget and the supporting infrastructure at WMDE. I do not believe we currently have meaningful usage data. The reason is that the gadget is not yet installed in a way that it can be easily enabled for an average user. Only a few people have been trying it out.

Aug 19 2015, 5:45 PM · WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-08-18_(1.26wmf19), User-notice, Patch-For-Review, Discovery-Search (Current work)

Jul 1 2015

jkroll added a comment to T101969: [Deepcat] adjust error message if the category can't be found.

@Tobi_WMDE_SW, you realize I was being sarcastic? The 'fix' you just committed makes the error message *less* informative. The original one was more accurate. If you know how error messages should be phrased in the context of the code better than the person who wrote the code, Christoph in this case, maybe you should have written the code instead (and that was, again, not a serious suggestion). Please don't disimprove things.

Jul 1 2015, 4:24 PM · DeepCat-Gadget, TCB-Team-Sprint-2015-07-01, TCB-Team, German-Community-Wishlist
jkroll added a comment to T101969: [Deepcat] adjust error message if the category can't be found.

"CatGraph could not find the category" is precisely what happened if that message is displayed. I see no problem here. If you think users need more information about Catgraph, https://wikitech.wikimedia.org/wiki/Nova_Resource:Catgraph/Documentation would be the link to use. If you think our users are too stupid to click a link, you could change the message to "Something Be Wrong" instead.

Jul 1 2015, 3:59 PM · DeepCat-Gadget, TCB-Team-Sprint-2015-07-01, TCB-Team, German-Community-Wishlist

Jun 22 2015

jkroll closed T101997: [Deepcat] Make the gadget work on Wikimedia Commons, a subtask of T7244: Allow searching in intersections, etc. of categories, as Resolved.
Jun 22 2015, 3:40 PM · TCB-Team, German-Community-Wishlist, Epic, MediaWiki-Categories
jkroll closed T101997: [Deepcat] Make the gadget work on Wikimedia Commons as Resolved.
Jun 22 2015, 3:40 PM · DeepCat-Gadget, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team
jkroll added a comment to T101997: [Deepcat] Make the gadget work on Wikimedia Commons.

tested, merged.

Jun 22 2015, 3:40 PM · DeepCat-Gadget, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team
jkroll reopened T103354: Can't login to catgraph instance as "Open".

Thanks for the quick response, but I still can't ssh there - same output as before :/

Jun 22 2015, 3:28 PM · TCB-Team, Cloud-VPS, Catgraph, Cloud-Services
jkroll created T103354: Can't login to catgraph instance.
Jun 22 2015, 3:09 PM · TCB-Team, Cloud-VPS, Catgraph, Cloud-Services

Jun 19 2015

jkroll added a comment to T101997: [Deepcat] Make the gadget work on Wikimedia Commons.

The Tools part seems up again, but non-Labs instances, including CatGraph, are still broken or down.

Jun 19 2015, 1:28 PM · DeepCat-Gadget, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team

Jun 18 2015

jkroll moved T101989: [Deepcat] Interception of search field changes and show hint from Backlog to Doing on the TCB-Team-Sprint-2015-06-17 board.
Jun 18 2015, 1:05 PM · DeepCat-Gadget, TCB-Team-Sprint-2015-07-01, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team
jkroll claimed T101989: [Deepcat] Interception of search field changes and show hint .
Jun 18 2015, 1:05 PM · DeepCat-Gadget, TCB-Team-Sprint-2015-07-01, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team
jkroll moved T101997: [Deepcat] Make the gadget work on Wikimedia Commons from Backlog to Doing on the TCB-Team-Sprint-2015-06-17 board.
Jun 18 2015, 1:05 PM · DeepCat-Gadget, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team
jkroll claimed T101997: [Deepcat] Make the gadget work on Wikimedia Commons.

I've pushed the change to the wiki-switch branch and will test&merge it when Tool Labs is up again.

Jun 18 2015, 1:03 PM · DeepCat-Gadget, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team

Jun 17 2015

jkroll added a comment to T101381: [DeepCat] probe for max values regarding CatGraph search depth .

see comments here: https://github.com/wmde/DeepCat-Gadget/issues/13

Jun 17 2015, 1:20 PM · DeepCat-Gadget, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team
jkroll added a comment to T101984: [DeepCat] Investigate CirrusSearch limits and how to raise them.

see comments here: https://github.com/wmde/DeepCat-Gadget/issues/13

Jun 17 2015, 1:20 PM · DeepCat-Gadget, TCB-Team-Sprint-2015-06-17, TCB-Team, German-Community-Wishlist

Jun 15 2015

jkroll added a comment to T101997: [Deepcat] Make the gadget work on Wikimedia Commons.

See my last comment at the related pull request.

Jun 15 2015, 2:11 PM · DeepCat-Gadget, Patch-For-Review, TCB-Team-Sprint-2015-06-17, German-Community-Wishlist, TCB-Team

Jun 11 2015

jkroll added a comment to T101241: [Attribution Generator] Extract human readable message strings and put them in a list.

First I thought strings would be inline in the app js files, so I wrote
a one-off script which extracts all the strings and writes them to an
HTML file, together with hyperlinks to the file+linenumber on github,
and an editable text field for explanations or notes. A human would
then go through all the string entries and remove those that aren't
shown to the user (this part cannot be easily automated).
Then I noticed that the app is already using the NLS thing, so all the
user-visible strings should be in files in app/nls. So my first script
would be useless. So I wrote another one-off script... Which extracts
the strings and their identifiers, and searches the js code for places
which reference the identifiers. So this generates a text file which
looks like this:

Jun 11 2015, 11:15 AM · TCB-Team-Sprint-2015-06-17, Tool-Attribution-Generator, TCB-Team-Sprint-2015-06-03, TCB-Team

Jun 8 2015

jkroll claimed T101241: [Attribution Generator] Extract human readable message strings and put them in a list.
Jun 8 2015, 12:01 PM · TCB-Team-Sprint-2015-06-17, Tool-Attribution-Generator, TCB-Team-Sprint-2015-06-03, TCB-Team

Jun 1 2015

jkroll added a member for TCB-Team: jkroll.
Jun 1 2015, 11:34 AM

May 25 2015

jkroll added a comment to T100266: Taxis to the airport or train station.

@Ckoerner Yes, let's do that. 11:45 in the lobby.

May 25 2015, 12:22 PM · Wikimedia-Hackathon-2015
jkroll added a comment to T100266: Taxis to the airport or train station.

My flight is at 14:45 from Terminal 2. So I'd like to take/share a taxi around 11:45-12:00.

May 25 2015, 11:06 AM · Wikimedia-Hackathon-2015

May 11 2015

jkroll added a comment to T98602: Instance in SHUTOFF state, not rebooting.

Great, instance is up and running now. Thanks a lot Andrew!

May 11 2015, 2:20 PM · Cloud-Services, Cloud-VPS
jkroll added a parent task for T98602: Instance in SHUTOFF state, not rebooting: T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter.
May 11 2015, 12:32 PM · Cloud-Services, Cloud-VPS
jkroll added a subtask for T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter: T98602: Instance in SHUTOFF state, not rebooting.
May 11 2015, 12:32 PM · Discovery-Search (Current work), Patch-For-Review, Discovery, CirrusSearch
jkroll removed a parent task for T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter: T98602: Instance in SHUTOFF state, not rebooting.
May 11 2015, 12:31 PM · Discovery-Search (Current work), Patch-For-Review, Discovery, CirrusSearch
jkroll removed a subtask for T98602: Instance in SHUTOFF state, not rebooting: T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter.
May 11 2015, 12:31 PM · Cloud-Services, Cloud-VPS
jkroll added a subtask for T98602: Instance in SHUTOFF state, not rebooting: T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter.
May 11 2015, 12:22 PM · Cloud-Services, Cloud-VPS
jkroll added a parent task for T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter: T98602: Instance in SHUTOFF state, not rebooting.
May 11 2015, 12:22 PM · Discovery-Search (Current work), Patch-For-Review, Discovery, CirrusSearch

May 8 2015

jkroll created T98602: Instance in SHUTOFF state, not rebooting.
May 8 2015, 1:11 PM · Cloud-Services, Cloud-VPS

Feb 20 2015

jkroll updated subscribers of T89823: CirrusSearch: Allow *ORs* of incategory to be sent via a post or get parameter.
Feb 20 2015, 6:18 PM · Discovery-Search (Current work), Patch-For-Review, Discovery, CirrusSearch

Feb 3 2015

jkroll added a comment to T87562: Shorten update interval of lighttpd error logs.

valhallasw: works for me, thanks.

Feb 3 2015, 4:23 PM · Toolforge

Jan 26 2015

jkroll created T87562: Shorten update interval of lighttpd error logs.
Jan 26 2015, 1:02 PM · Toolforge