Page MenuHomePhabricator

jkroll (Johannes Kroll (WMDE))
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 1 2014, 1:58 PM (241 w, 12 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
Johannes Kroll (WMDE) [ Global Accounts ]

Recent Activity

Mon, Jul 1

jkroll committed rEFLI328b77a62567: [WiP] Make it possible to transfer wiki-specific template parameters (authored by Johannes Kroll <j-kroll@gmx.de>).
[WiP] Make it possible to transfer wiki-specific template parameters
Mon, Jul 1, 4:45 PM

Fri, Jun 28

jkroll committed rEFLI6f0ed8e7cc47: [WiP] Make it possible to transfer wiki-specific template parameters (authored by Johannes Kroll <j-kroll@gmx.de>).
[WiP] Make it possible to transfer wiki-specific template parameters
Fri, Jun 28, 12:53 PM

Thu, Jun 27

jkroll created T226753: Check for possible regression in Wikidiff2 1.8.2.
Thu, Jun 27, 6:43 PM · TCB-Team, wikidiff2, WMDE-QWERTY-Sprint-2019-06-26

Wed, Jun 26

jkroll claimed T214365: Make it possible to transfer parameters to the commons information template that are specific to a wiki.
Wed, Jun 26, 1:51 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), TCB-Team, Move-Files-To-Commons
jkroll moved T214365: Make it possible to transfer parameters to the commons information template that are specific to a wiki from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-06-26 board.
Wed, Jun 26, 1:51 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), TCB-Team, Move-Files-To-Commons

May 23 2019

jkroll moved T222802: Add FileImporter to gated extensions from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-05-15 board.
May 23 2019, 4:02 PM · WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Sprint-2019-05-15, Goatification, Move-Files-To-Commons, TCB-Team
jkroll claimed T222802: Add FileImporter to gated extensions.
May 23 2019, 4:02 PM · WMDE-QWERTY-Sprint-2019-05-29, WMDE-QWERTY-Sprint-2019-05-15, Goatification, Move-Files-To-Commons, TCB-Team

Apr 11 2019

jkroll added a comment to T204010: Comparing revisions can fatal (timeout from wikidiff2 via TextSlotDiffRenderer).

Possibly unrelated, but curious: I also get a timeout for the the page in the first test case (the page itself, not the diff): https://de.wikipedia.org/w/index.php?title=Portal:Biologie/Fehlende_Artikel/Missing_Topics

Apr 11 2019, 1:17 PM · WMDE-QWERTY-Sprint-2019-04-30, Wikimedia-production-error, wikidiff2

Apr 10 2019

jkroll added a comment to T218772: Spike: GenderedCategories.

gedanken von mir zu dem thema:

Apr 10 2019, 2:33 PM · TCB-Team, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20

Feb 13 2019

jkroll claimed T215293: Moved 100% match was not found (Michgrig bug).
Feb 13 2019, 11:00 PM · Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-20, WMDE-QWERTY-Sprint-2019-02-06, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, TCB-Team

Feb 11 2019

jkroll claimed T215063: Rename link in footer to "Jump to footnote".
Feb 11 2019, 1:51 PM · WMDE-QWERTY-Season-Sprint-2019-03-20, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Reference Previews

Feb 6 2019

jkroll claimed T215195: [Bug] Hovering over references in reference previews dismisses dialog.
Feb 6 2019, 2:16 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews
jkroll moved T215195: [Bug] Hovering over references in reference previews dismisses dialog from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-06 board.
Feb 6 2019, 2:16 PM · MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review, WMDE-QWERTY-Sprint-2019-02-06, Readers-Web-Backlog (Tracking), Reference Previews

Feb 1 2019

jkroll added a comment to T214693: Investigate why Page and Reference Previews interfere when footnote comes right behind link on English Beta Wikipedia.

I tried to reproduce this, without success so far. Is there anything specific I need to do or do we have a page where it reliably happens? Or does it seem to happen only randomly?

Feb 1 2019, 5:58 PM · MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), Patch-For-Review, WMDE-QWERTY-Sprint-2019-04-30, WMDE-QWERTY-Sprint-2019-04-03, WMDE-QWERTY-Season-Sprint-2019-03-20, WMDE-QWERTY-Sprint-2019-03-06, WMDE-QWERTY-Sprint-2019-01-23, TCB-Team, Reference Previews

Dec 4 2018

jkroll moved T204519: cloudvps: mwfileimport project trusty deprecation from Sprint Backlog to Done on the WMDE-QWERTY-Sprint-2018-12-04 board.
Dec 4 2018, 4:20 PM · WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Move-Files-To-Commons, Cloud-VPS (Ubuntu Trusty Deprecation)
jkroll added a comment to T204519: cloudvps: mwfileimport project trusty deprecation.

done.

Dec 4 2018, 4:18 PM · WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Move-Files-To-Commons, Cloud-VPS (Ubuntu Trusty Deprecation)

Nov 23 2018

jkroll added a comment to T208400: Check whether catgraph project requires NFS or not.

Yes, I can confirm it needs the NFS mounts.

Nov 23 2018, 3:54 PM · TCB-Team, Catgraph, Cloud-VPS

Oct 30 2018

jkroll committed rESCC0da7917f06d1: Disable ancient "vars-on-top" ESLint rule (authored by thiemowmde).
Disable ancient "vars-on-top" ESLint rule
Oct 30 2018, 3:17 PM

Oct 8 2018

jkroll committed rESCCdbe5a55120d5: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 8 2018, 4:23 PM

Oct 5 2018

jkroll committed rESCC1c7652366fdf: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 5 2018, 1:18 PM
jkroll committed rESCC7f33549fd1ea: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 5 2018, 12:14 PM
jkroll committed rESCCf287f46f72a3: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 5 2018, 11:56 AM
jkroll committed rESCCceb1f872e73d: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 5 2018, 10:59 AM
jkroll committed rESCC36fd413eb850: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 5 2018, 10:59 AM
jkroll committed rESCCc9c4b06c480b: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 5 2018, 10:19 AM

Oct 2 2018

jkroll committed rESCC8565895b87cc: Fix CSS for Chrome on MacOS and Firefox with dark color scheme (authored by jkroll).
Fix CSS for Chrome on MacOS and Firefox with dark color scheme
Oct 2 2018, 4:08 PM

Oct 1 2018

RandomDSdevel awarded T197157: New diffs show lines in the wrong order a Baby Tequila token.
Oct 1 2018, 1:38 AM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Sep 28 2018

jkroll added a comment to T205431: Keep frames of text boxes also on Chrome.

I don't have Chrome installed, but I found "interesting" results with other browsers:

  • In Chromium 69.0.3497.81, nothing is greyed out. Everything looks fine to me.
  • In Opera 54.0.2952.64 (yes that still exists!) everything looks fine as well
  • In Firefox 62.0, the text boxes keep their color but the text itself is greyed out after clicking the edit button. In the attached screenshot the edit button was clicked in the first two rows, but not the last row.
Sep 28 2018, 3:11 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), WMDE-QWERTY-Sprint-2018-10-23, WMDE-QWERTY-Sprint-2018-10-09, Patch-For-Review, WMDE-QWERTY-Sprint-2018-09-25, TCB-Team, Two-Column-Edit-Conflict-Merge, WMDE-QWERTY-Team

Sep 26 2018

jkroll committed rESCC9a391e80e69f: Making the popups a bit larger seems to fix this for most, if not all cases. (authored by jkroll).
Making the popups a bit larger seems to fix this for most, if not all cases.
Sep 26 2018, 2:43 PM
jkroll committed rESCC0b862ee9ead5: Making the popups a bit larger seems to fix this for most, if not all cases. (authored by jkroll).
Making the popups a bit larger seems to fix this for most, if not all cases.
Sep 26 2018, 2:43 PM

Sep 10 2018

jkroll added a comment to T181454: Port wikidiff2 to a memory-safe language.
Sep 10 2018, 2:48 PM · MediaWiki-History-and-Diffs, wikidiff2

Sep 6 2018

jkroll committed rESCCa62cdf0828a0: Fix T202884 (Unwanted greyed out text in tour tip 3/3) (authored by jkroll).
Fix T202884 (Unwanted greyed out text in tour tip 3/3)
Sep 6 2018, 7:24 PM
jkroll committed rESCCb841a6d831db: Fix T202884 (Unwanted greyed out text in tour tip 3/3) (authored by jkroll).
Fix T202884 (Unwanted greyed out text in tour tip 3/3)
Sep 6 2018, 2:14 PM

Aug 27 2018

Liuxinyu970226 awarded T197157: New diffs show lines in the wrong order a Like token.
Aug 27 2018, 10:07 PM · Russian-Sites, User-notice, WMDE-QWERTY-Sprint-2018-08-14, WMDE-QWERTY-Sprint-2018-07-31, WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-and-Diffs

Aug 6 2018

jkroll claimed T200787: Import failing diff examples to test server.
Aug 6 2018, 6:41 PM · WMDE-QWERTY-Sprint-2018-07-31, wikidiff2, MediaWiki-History-and-Diffs

Jun 21 2018

jkroll moved T197664: Create test setup for Japanese, Chinese and Thai from Done to Demo on the WMDE-QWERTY-Sprint-2018-06-05 board.
Jun 21 2018, 1:42 PM · Chinese-Sites, WMDE-QWERTY-Sprint-2018-06-05, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team
jkroll moved T197664: Create test setup for Japanese, Chinese and Thai from Doing to Done on the WMDE-QWERTY-Sprint-2018-06-05 board.
Jun 21 2018, 1:42 PM · Chinese-Sites, WMDE-QWERTY-Sprint-2018-06-05, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team
jkroll added a comment to T197664: Create test setup for Japanese, Chinese and Thai.

https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Diffcompare-ja
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Diffcompare-zh
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Diffcompare-th

Jun 21 2018, 1:41 PM · Chinese-Sites, WMDE-QWERTY-Sprint-2018-06-05, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Jun 14 2018

jkroll added a comment to T195373: Remove bug that sometime a moved paragraph is indicated, but not visibly matched.

Test cases are here: https://wmde-wikidiff2-debug.wmflabs.org/core/index.php?title=DiffcompareDebug

Jun 14 2018, 12:32 PM · wikidiff2, WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-05-23
jkroll moved T195371: Create a test server for show changes in moved paragraphs on mobile from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-06-05 board.
Jun 14 2018, 12:27 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team
jkroll claimed T195371: Create a test server for show changes in moved paragraphs on mobile.
Jun 14 2018, 12:26 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team
jkroll added a comment to T195371: Create a test server for show changes in moved paragraphs on mobile.

Hi @Jdlrobson! The moved-lines functionality for mobile output in wikidiff2 is disabled by an ini variable. That's why you don't see any classes in the mobile output. It can be enabled by ini_set'ing wikidiff2.moved_paragraph_detection_cutoff_mobile to some positive integer, eg 30. A mobile diff with a moved paragraph will then look like this: https://wmde-wikidiff2-mobile.wmflabs.org/core/index.php/Special:MobileDiff/1455 -- it shows something was moved, but there's no proper styling yet.

Jun 14 2018, 12:26 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team

Jun 10 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rESCC4e7b67572041: Update patch set 10 (authored by jkroll).
Update patch set 10
Jun 10 2018, 7:43 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rESCCefa05820d677: Update patch set 9 (authored by jkroll).
Update patch set 9
Jun 10 2018, 7:43 AM

Jun 9 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rEFILEEXPORTd8d0954b757d: Update patch set 1 (authored by jkroll).
Update patch set 1
Jun 9 2018, 5:34 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEFLIf7c3fb9b6cb5: Update patch set 2 (authored by jkroll).
Update patch set 2
Jun 9 2018, 1:37 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEFLI37f10eb2095b: Update patch set 1 (authored by jkroll).
Update patch set 1
Jun 9 2018, 1:37 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEFLIfda5c4760b00: Update patch set 2 (authored by jkroll).
Update patch set 2
Jun 9 2018, 1:37 AM
Gerrit Code Review <gerrit@wikimedia.org> committed rEFLIfcde098cdafa: Update patch set 3 (authored by jkroll).
Update patch set 3
Jun 9 2018, 1:37 AM

Jun 8 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rADES276551164257: Update patch set 1 (authored by jkroll).
Update patch set 1
Jun 8 2018, 5:37 PM

May 31 2018

jkroll closed T185579: Import & compare script for wikidiff2 as Resolved.
May 31 2018, 2:53 PM · wikidiff2, WMDE-QWERTY-Team
jkroll added a comment to T195373: Remove bug that sometime a moved paragraph is indicated, but not visibly matched.

There is special code for the case where one destination paragraph seems to match several source paragraphs or vice versa. In that case, only one source (or destination) paragraph is then selected. In this particular diff, this detection doesn't work correctly. I'm working on a solution and feel I'm pretty close. Next step will be a patch, a new test VM and a mod to the compare script which will check what the fix changes. I will then check this list for possible regressions.

May 31 2018, 2:53 PM · wikidiff2, WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-05-23

May 24 2018

jkroll moved T195373: Remove bug that sometime a moved paragraph is indicated, but not visibly matched from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2018-05-23 board.
May 24 2018, 3:53 PM · wikidiff2, WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-05-23
jkroll claimed T195373: Remove bug that sometime a moved paragraph is indicated, but not visibly matched.
May 24 2018, 3:53 PM · wikidiff2, WMDE-QWERTY-Sprint-2018-06-05, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-05-23

May 23 2018

jkroll added a comment to T194146: Make sure show changes in moved paragraphs for mobile really improves things.

evaluation of mobile diff is here: http://wmde-wikidiff2-mobile.wmflabs.org/core/index.php?title=Diffcompare_Mobile

May 23 2018, 1:17 PM · WMDE-QWERTY-Sprint-2018-05-16, WMDE-QWERTY-Team, MediaWiki-History-and-Diffs

May 3 2018

jkroll closed T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced as Resolved.
May 3 2018, 2:12 PM · WMDE-QWERTY-Sprint-2018-05-02, WMDE-QWERTY-Team, MediaWiki-History-and-Diffs
jkroll closed T193640: Make sure that desktop version of the diffs did not change after the mobile version was introduced, a subtask of T191310: Show changes in moved paragraphs for mobile, as Resolved.
May 3 2018, 2:12 PM · Patch-For-Review, WMDE-QWERTY-Team, MediaWiki-History-and-Diffs
jkroll closed T191313: Create a first patch for "show changes in moved paragraphs for mobile" as Resolved.
May 3 2018, 2:09 PM · WMDE-QWERTY-Sprint-2018-05-02, WMDE-QWERTY-Sprint-2018-04-17, WMDE-QWERTY-Sprint-2018-04-03, WMDE-QWERTY-Team, MediaWiki-History-and-Diffs
jkroll closed T191313: Create a first patch for "show changes in moved paragraphs for mobile", a subtask of T191310: Show changes in moved paragraphs for mobile, as Resolved.
May 3 2018, 2:09 PM · Patch-For-Review, WMDE-QWERTY-Team, MediaWiki-History-and-Diffs

Apr 11 2018

jkroll added a comment to T191311: Set up test server for testing the mobile view of "show changes in moved paragraphs".

test server for the mobile stuff is at https://wmde-wikidiff2-mobile.wmflabs.org/core/index.php/Main_Page

Apr 11 2018, 4:42 PM · WMDE-QWERTY-Sprint-2018-04-03, MediaWiki-History-and-Diffs

Mar 13 2018

jkroll moved T189023: Clean up code + commit messages for final version of wikidiff2 - show paragraph moves from Sprint backlog to Review on the WMDE-QWERTY-Sprint-2018-03-06 board.
Mar 13 2018, 12:17 PM · WMDE-QWERTY-Sprint-2018-03-06, WMDE-QWERTY-Team
jkroll closed T189023: Clean up code + commit messages for final version of wikidiff2 - show paragraph moves as Resolved.
Mar 13 2018, 12:16 PM · WMDE-QWERTY-Sprint-2018-03-06, WMDE-QWERTY-Team
jkroll moved T187798: Gather data on diff behavior from Sprint backlog to Review on the WMDE-QWERTY-Sprint-2018-03-06 board.
Mar 13 2018, 12:16 PM · WMDE-QWERTY-Sprint-2018-03-06, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-02-20
jkroll closed T187798: Gather data on diff behavior as Resolved.

here's the list:
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Diffcompare

Mar 13 2018, 12:16 PM · WMDE-QWERTY-Sprint-2018-03-06, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-02-20

Mar 7 2018

jkroll added a comment to T186617: Figure out if new empty line treatment really improves things.

unfortunately, the diffs generated using this special-case code turned about to be incorrect so i had to revert this. looking at the list of random test diffs, these cases turn out to be rare though.

Mar 7 2018, 6:58 PM · WMDE-QWERTY-Sprint-2018-02-20, WMDE-QWERTY-Sprint-2018-02-06, TCB-Team, MediaWiki-History-and-Diffs, WMDE-QWERTY-Team

Mar 6 2018

jkroll added a comment to T186617: Figure out if new empty line treatment really improves things.

https://wmde-wikidiff2-unpatched.wmflabs.org/core/index.php?title=Honeyguide&type=revision&diff=45&oldid=44
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Honeyguide&type=revision&diff=45&oldid=44

Mar 6 2018, 3:56 PM · WMDE-QWERTY-Sprint-2018-02-20, WMDE-QWERTY-Sprint-2018-02-06, TCB-Team, MediaWiki-History-and-Diffs, WMDE-QWERTY-Team

Feb 28 2018

jkroll closed T187799: Investigate and fix why sometimes paragraphs are not indicated as moved as Resolved.

sometime a change DiffOp would contain add and delete ops, which would later not get picked up ba the moved paragraph stuff. fixed (see examples above).

Feb 28 2018, 3:50 PM · WMDE-QWERTY-Sprint-2018-02-20

Feb 21 2018

jkroll claimed T187798: Gather data on diff behavior.
Feb 21 2018, 4:44 PM · WMDE-QWERTY-Sprint-2018-03-06, WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-02-20
jkroll moved T187799: Investigate and fix why sometimes paragraphs are not indicated as moved from Sprint backlog to Doing on the WMDE-QWERTY-Sprint-2018-02-20 board.
Feb 21 2018, 4:44 PM · WMDE-QWERTY-Sprint-2018-02-20
jkroll claimed T187799: Investigate and fix why sometimes paragraphs are not indicated as moved.
Feb 21 2018, 3:09 PM · WMDE-QWERTY-Sprint-2018-02-20

Feb 20 2018

jkroll added a comment to T187799: Investigate and fix why sometimes paragraphs are not indicated as moved.

examples: https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Irregul%C3%A4rer_Satellit&type=revision&diff=3239&oldid=3238 http://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Autoimport/G.K.Singh&diff=2211&oldid=2210

Feb 20 2018, 4:35 PM · WMDE-QWERTY-Sprint-2018-02-20
jkroll closed T181494: Investigate what the ideal change detection threshold would be, a subtask of T146781: Show changes in moved text chunks (C++), as Resolved.
Feb 20 2018, 4:20 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team
jkroll closed T181494: Investigate what the ideal change detection threshold would be as Resolved.
Feb 20 2018, 4:20 PM · WMDE-QWERTY-Sprint-2018-02-06, WMDE-QWERTY-Sprint-2018-01-23, WMDE-QWERTY-Sprint-2018-01-09, WMDE-QWERTY-XMAS-Sprint-2017-12-20, WMDE-QWERTY-Sprint-2017-11-28, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team
jkroll added a comment to T181494: Investigate what the ideal change detection threshold would be.

I would say a default value of 0.2 looks pretty good for English. Some slightly annoying edge cases exist for any value, which could be fixed by special-case code. I also investigated "character runs" as an alternative to the character-based similarity but found no improvement.

Feb 20 2018, 4:19 PM · WMDE-QWERTY-Sprint-2018-02-06, WMDE-QWERTY-Sprint-2018-01-23, WMDE-QWERTY-Sprint-2018-01-09, WMDE-QWERTY-XMAS-Sprint-2017-12-20, WMDE-QWERTY-Sprint-2017-11-28, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Feb 6 2018

jkroll renamed T186599: evaluate wikidiff2 code changes against random wiki pages from TODO JOHANNES FILL: evaluate wikidiff2 code changes against random wiki pages to evaluate wikidiff2 code changes against random wiki pages.
Feb 6 2018, 3:14 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-01-23
jkroll updated the task description for T186599: evaluate wikidiff2 code changes against random wiki pages.
Feb 6 2018, 3:08 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-01-23
jkroll added a comment to T186599: evaluate wikidiff2 code changes against random wiki pages.

the list of pages is on an automatically generated page on the wiki: http://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Diffcompare

Feb 6 2018, 3:07 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2018-01-23

Jan 23 2018

jkroll created T185579: Import & compare script for wikidiff2.
Jan 23 2018, 3:32 PM · wikidiff2, WMDE-QWERTY-Team

Nov 16 2017

jkroll added a comment to T180123: Define changes within wikidiff2 for mobile.

what will be done
Similar to the desktop diff, moved paragraphs will be detected, links inserted between them, and word diffs between the moved paragraphs will be displayed.

Nov 16 2017, 5:57 PM · wikidiff2, Readers-Web-Backlog (Tracking), WMDE-QWERTY-Sprint-2017-11-14, MediaWiki-History-and-Diffs, WMDE-QWERTY-Team, German-Community-Wishlist, TCB-Team

Oct 10 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

It should be restarted after a native PHP extension is upgraded.

HHVM was restarted after installing the new package (otherwise it would not load the revised modules anyway). The cache is persistent on disk, though (but we can prune it manually).

Oct 10 2017, 2:26 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend
jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

The wikidiff2 patch introduced new parameters with default values to wikidiff2_do_diff() and wikidiff2_inline_diff(). Possible explanation for the crashes: HHVM caches data for performance reasons, including function signatures provided by extensions. Between deploying the new wikidiff2 version on the 15th and the HHVM unattended-upgrade on the 28th, HHVM would cache the old signatures in memory. The new wikidiff2 would have the new signatures though, and the PHP code is already patched to use them, causing a mismatch.

Oct 10 2017, 1:47 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Oct 9 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

On the 28th, the update to HHVM 3.18.5 was installed via unattended-upgrades. That might have fixed it (or could be entirely unrelated/coincidental).

Oct 9 2017, 3:34 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend
jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

Also, getting a core file when this happens would be helpful. The core pattern was set to /data/project/cores/ but /data doesn't seem to be mounted. I've temporarily set it to /tmp but I'm not sure if it will be overwritten by the next puppet run.

Oct 9 2017, 2:43 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend
jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

Thanks @MaxSem. I've tried to reproduce it on deployment-mediawiki04.eqiad.wmflabs without success. According to logs, the last crash was on Sep 28.

Oct 9 2017, 2:18 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Oct 3 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

@MaxSem: Jkroll

Oct 3 2017, 1:21 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Oct 2 2017

jkroll added a comment to T176637: Diff page consistently produces 503 on beta cluster on first visit.

This seems to be related to the new wikidiff2. I wrote the moved-paragraphs patch, and I have been trying to reproduce this problem for the last couple days. It's not reproducible for me on apache/zend. I can't reproduce it with my distro-provided hhvm 3.22.0 either. Next, I tried to install mw-vagrant as per MoritzMuehlenhoff's suggestion in T176217. After working around T152801 and provisioning the box, I found that it wasn't running hhvm at all. Unsurprisingly, I couldn't reproduce the problem there, so I gave up on mw-vagrant. Instead I built HHVM-3.18.5 from source. I cannot reproduce the problem with that version either. I can display diffs just fine, including the mobile diff, and haven't seen any stack traces or suspiscious log entries.

Oct 2 2017, 3:35 PM · WMDE-QWERTY-Team, WMDE-QWERTY-Sprint-2017-09-19, wikidiff2, Release-Engineering-Team (Watching / External), Contributors-Team, Readers-Web-Backlog (Tracking), Operations, MobileFrontend

Sep 28 2017

jkroll added a comment to T176217: Test the new wikidiff2 version on beta.

Recompiling wikidiff2 is not the issue here, I wrote the moved-paragraphs patch.

Sep 28 2017, 1:19 PM · User-Addshore, wikidiff2, MediaWiki-History-and-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team, TCB-Team
jkroll added a comment to T176217: Test the new wikidiff2 version on beta.

I'm trying to reproduce it on my local machine. With my distro-supplied hhvm 3.22.0 (rel) I don't see anything suspicious in the logs at all so far. Can you pin down when the asserts happen? Probably when generating a mobile diff page?

Sep 28 2017, 12:07 PM · User-Addshore, wikidiff2, MediaWiki-History-and-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team, TCB-Team
jkroll added a comment to T176217: Test the new wikidiff2 version on beta.

can you (or anyone) help interpret this output? I do x86 assembly, but I'm not familiar with php jit bytecode :)

Sep 28 2017, 11:44 AM · User-Addshore, wikidiff2, MediaWiki-History-and-Diffs, WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Team, TCB-Team

Sep 21 2017

jkroll added a comment to T173822: CatGraph on commons missing subcategories.

After some investigation, I found that the data in CatGraph is actually OK. The problem was in the catgraph-jsonp tool which makes CatGraph queries available to JavaScript code. catgraph-jsonp has some logic to catch case errors in category title input. In an edge case involving spaces in titles, catgraph-jsonp erroneously fetches the page_id of a redirection page. This commit fixes it. It's already deployed.

Sep 21 2017, 12:46 PM · WMDE-QWERTY-Sprint-2017-09-19, WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Team, DeepCat-Gadget, Catgraph, TCB-Team

Sep 5 2017

jkroll added a comment to T146781: Show changes in moved text chunks (C++).

@MaxSem I added some code to your fuzz test which hits the other code paths in the patch. It just creates shuffled lines basically.

Sep 5 2017, 1:16 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Jul 25 2017

jkroll added a comment to T146781: Show changes in moved text chunks (C++).

@MaxSem updated again :) Anything else you want changed? Or can you give a +1? Thanks

Jul 25 2017, 2:09 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Jul 24 2017

jkroll updated subscribers of T146781: Show changes in moved text chunks (C++).

@MaxSem Thanks for looking into https://gerrit.wikimedia.org/r/#/c/356582/. I updated it. Could you review this and https://gerrit.wikimedia.org/r/#/c/319866/ so we can get it merged?
@tstarling You could also review this, thanks!

Jul 24 2017, 3:34 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Jul 4 2017

jkroll closed T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold as Resolved.
Jul 4 2017, 3:37 PM · Wikimedia-Hackathon-2017, MediaWiki-History-and-Diffs, WMDE-QWERTY-Team, TCB-Team
jkroll closed T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold, a subtask of T146781: Show changes in moved text chunks (C++), as Resolved.
Jul 4 2017, 3:37 PM · WMDE-QWERTY-Sprint-2017-09-05, WMDE-QWERTY-Sprint-2017-08-22, WMDE-QWERTY-Sprint-2017-07-25, wikidiff2, Patch-For-Review, WMDE-QWERTY-Team, WMDE-QWERTY-Team-Experimental-Sprint, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team
jkroll added a comment to T160075: Benchmark "Show changes in moved text chunks" patch, find size threshold.

We benchmarked this and set the default to 25. The threshold is configurable in LocalSettings.

Jul 4 2017, 3:36 PM · Wikimedia-Hackathon-2017, MediaWiki-History-and-Diffs, WMDE-QWERTY-Team, TCB-Team

Jun 20 2017

jkroll created T168410: Migrate php-compile-hhvm test to jessie.
Jun 20 2017, 3:31 PM · Patch-For-Review, Continuous-Integration-Infrastructure, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Jun 16 2017

jkroll added a comment to T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.
<?php
function hi($str) {
    print($str . "\n");
}
print wikidiff2_do_diff("hello\nworld\n", "world\nhello\n", 1, 1, "extra parameter that shouldn't be here");
hi("you should not see this string", "world");
?>
Jun 16 2017, 2:09 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team
jkroll added a comment to T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.

This, of course, cannot work:

Jun 16 2017, 1:14 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team

Jun 14 2017

jkroll added a comment to T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.

Well the solution would be to make MediaWiki work with both the old and the new version of Wikidiff2, right?

Jun 14 2017, 1:03 PM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, wikidiff2, WMDE-QWERTY-Team, German-Community-Wishlist, MediaWiki-History-and-Diffs, TCB-Team