| Lea_WMDE | |
| Feb 6 2018, 4:49 PM |
| F13927708: Screenshot-2018-2-21 „Brot“ – Versionsunterschied – Wikipedia(1).png | |
| Feb 21 2018, 10:52 AM |
| F13927667: Screenshot-2018-2-21 „Brot“ – Versionsunterschied – Wikipedia.png | |
| Feb 21 2018, 10:52 AM |
| F13927714: Screenshot-2018-2-21 Difference between revisions of Brot - EnLocalWiki(1).png | |
| Feb 21 2018, 10:52 AM |
| F13927671: Screenshot-2018-2-21 Difference between revisions of Brot - EnLocalWiki.png | |
| Feb 21 2018, 10:52 AM |
| F13927739: Screenshot-2018-2-21 „Brot“ – Versionsunterschied – Wikipedia(2).png | |
| Feb 21 2018, 10:52 AM |
NB this is timeboxed to 5 hours
Figure out if we really create an improvement in diffs by introducing the new empty line treatment. To do so, please follow the process we established for changes in moved paragraphs, which means:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | WMDE-Fisch | T184531 Treat empty lines as part of the previous paragraph | |||
| Resolved | Lea_WMDE | T186617 Figure out if new empty line treatment really improves things |
During my investigation on that topic I got some regression on the following diffs. These can be used as examples to look into way to improve the issue.
Removed empty line and small text involved:
https://de.wikipedia.org/w/index.php?title=Brot&diff=prev&oldid=53879730
Move of a line above an empty line:
https://de.wikipedia.org/w/index.php?title=Brot&diff=prev&oldid=52803648
Adding an empty line and text:
https://de.wikipedia.org/w/index.php?title=Brot&diff=prev&oldid=50774933
Since we decided it might be better, if someone else looks at a way to implement this. I unassign myself here @jkroll @Addshore @Andrew-WMDE. The examples above can be used as edge cases that need to be taken care off.
This has been resolved differently by looking at paragraphs that have only been moved one line. For more details see the patch posted below.
examples (before/after):
https://wmde-wikidiff2-unpatched.wmflabs.org/core/index.php?title=Honeyguide&type=revision&diff=45&oldid=44
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Honeyguide&type=revision&diff=45&oldid=44
https://wmde-wikidiff2-unpatched.wmflabs.org/core/index.php?title=Bahnhof_Fl%C3%BCelen&type=revision&diff=68&oldid=67
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Bahnhof_Fl%C3%BCelen&type=revision&diff=68&oldid=67
https://wmde-wikidiff2-unpatched.wmflabs.org/core/index.php?title=Bahnstrecke_Mannheim%E2%80%93Frankfurt_am_Main&type=revision&diff=70&oldid=69
https://wmde-wikidiff2-patched.wmflabs.org/core/index.php?title=Bahnstrecke_Mannheim%E2%80%93Frankfurt_am_Main&type=revision&diff=70&oldid=69
patch (includes other improvements and fixes):
https://gerrit.wikimedia.org/r/#/c/404293/
unfortunately, the diffs generated using this special-case code turned about to be incorrect so i had to revert this. looking at the list of random test diffs, these cases turn out to be rare though.