Page MenuHomePhabricator
Create Task
Maniphest T215293

Moved 100% match was not found (Michgrig bug)
Closed, ResolvedPublic13 Estimated Story Points
Actions

Description

Bug description
If there are 100% matches of moved lines, wikidiff2 should be able to catch them.
However, in an example on ru-wiki Michgrig was matched with DrBug, instead of Michgrig itself. Furthermore, the link on "Michgrig" appearance on the right hand side line leads to a non-existing anchor.

Acceptance Criteria

  • Wikidiff2 correctly handles the "Michgrig" situation (and all similar ones)
  • None of the other examples of our test setup are worsened.

Notes

  • The page in question is going to be imported in the test wiki
  • Ideally, we could add a test to the repository that covers the test

Details

SubjectRepoBranchLines +/-
Fix matching of moved lines in some casesmediawiki/php/wikidiff2master+27 -9
Add test for T215293 bugmediawiki/php/wikidiff2master+218 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Lea_WMDE triaged this task as Medium priority.Feb 5 2019, 4:37 PM
• Lea_WMDE created this task.
IKhitron updated the task description. (Show Details)Feb 5 2019, 4:39 PM
IKhitron added subscribers: Michgrig, • Drbug.
SerDIDG subscribed.Feb 5 2019, 6:06 PM
• Lea_WMDE updated the task description. (Show Details)Feb 12 2019, 2:31 PM
• Lea_WMDE set the point value for this task to 13.
• jkroll claimed this task.Feb 13 2019, 11:00 PM
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2019-02-06.Feb 19 2019, 4:42 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-06 board.Feb 20 2019, 8:41 AM
thiemowmde added a project: WMDE-QWERTY-Sprint-2019-02-20.Feb 20 2019, 1:17 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-20 board.Feb 20 2019, 1:53 PM
gerritbot subscribed.Feb 27 2019, 3:50 PM

Change 493258 had a related patch set uploaded (by Jkroll; owner: Jkroll):
[mediawiki/php/wikidiff2@master] [WiP] Fix matching of moved lines in some cases

https://gerrit.wikimedia.org/r/493258

gerritbot added a project: Patch-For-Review.Feb 27 2019, 3:50 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-02-20 board.Feb 28 2019, 9:59 AM
WMDE-Fisch updated the task description. (Show Details)Mar 1 2019, 10:08 AM
gerritbot added a comment.Mar 1 2019, 1:20 PM

Change 493258 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Fix matching of moved lines in some cases

https://gerrit.wikimedia.org/r/493258

gerritbot added a comment.Mar 1 2019, 1:41 PM

Change 493688 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/php/wikidiff2@master] Add test for T215293 bug

https://gerrit.wikimedia.org/r/493688

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-02-20 board.EditedMar 1 2019, 4:05 PM

The issue is fixed in the patched version 1.8.1 currently deployed on the debug server:

https://wmde-wikidiff2-debug.wmflabs.org/core/index.php?title=MediaWiki%3AGadget-markadmins.json&type=revision&diff=316055&oldid=316051

WMDE-Fisch mentioned this in T217420: Tag and Release wikidiff 1.8.1.Mar 1 2019, 4:15 PM
gerritbot added a comment.Mar 1 2019, 8:48 PM

Change 493688 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Add test for T215293 bug

https://gerrit.wikimedia.org/r/493688

• Lea_WMDE closed this task as Resolved.Mar 4 2019, 10:40 AM
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-02-20 board.

FYI: This still needs to go out with the next wikidiff2 release. For the release please see T203069: Deploy wikidiff2 v1.8.1 with changed signature

WMDE-Fisch added a comment.Mar 4 2019, 10:47 AM
In T215293#4997397, @Lea_WMDE wrote:

FYI: This still needs to go out with the next wikidiff2 release. For the release please see T203069: Deploy wikidiff2 v1.8.1 with changed signature

I also already created T217420: Tag and Release wikidiff 1.8.1 alreasdy. This one would be on our watch. The deployment as last step of the above ticket can be initiated afterwards.

thiemowmde mentioned this in T217546: Line matching algorithm can produce dead left-to-right side links.Mar 4 2019, 11:43 AM
Tobi_WMDE_SW updated the task description. (Show Details)Mar 6 2019, 1:38 PM
IKhitron added a comment.Mar 12 2019, 7:46 PM

Well, @Lea_WMDE, it's Tuesday. And it's definitely looks different (compare to F27961541). But still wrong. Thank you.

• Lea_WMDE added a comment.Mar 13 2019, 10:24 AM

@IKhitron The diffing library we have to change (Wikidiff2) has to be deployed manually, and does not follow the train. If you watch T203069 you will see when the changes are live :)

IKhitron added a comment.Mar 13 2019, 10:43 AM

I see. Thank you.

IKhitron added a comment.Apr 11 2019, 8:27 AM

Hello, @Lea_WMDE. I can see that the wikidiff2 (T203069) has been already deployed, so the original diff looks much better, and "Michgrig" fits the aim of the tool. Nevertheless, please check "Фил Вечеровский", with comma on the left diff side.

WMDE-Fisch added a comment.Apr 12 2019, 10:09 AM
In T215293#5103359, @IKhitron wrote:

Hello, @Lea_WMDE. I can see that the wikidiff2 (T203069) has been already deployed, so the original diff looks much better, and "Michgrig" fits the aim of the tool. Nevertheless, please check "Фил Вечеровский", with comma on the left diff side.

Before there's even more confusion about whats going on here: The above link to the diff is build in a way that, it always compares a certain version with the the current version. So if the current version changes ( due to an update ) the diff changes as well. - I guess that's not very helpful in our case ^^'

@IKhitron I guess you mean this specific diff https://ru.wikipedia.org/w/index.php?diff=97742858&oldid=97533626&title=MediaWiki:Gadget-markadmins.json where АлександрВв on the left is linked to Salsero al Zviadi on the right :-)

I will adjust the link in the ticket description accordingly. - But we probably should create a new ticket for this. ( it looks a bit like the similarity threshold here is not working very well or not well with Cyrillic characters )

WMDE-Fisch updated the task description. (Show Details)Apr 12 2019, 10:10 AM
IKhitron added a comment.Apr 12 2019, 10:15 AM

It is not what I was tacking about, but it seems as another problem.

IKhitron added a subscriber: Lea_Lacroix_WMDE.Jul 14 2019, 12:45 PM

Hello, @Lea_Lacroix_WMDE. Is there something new with this task? See this diff from yesterday. Thank you.

Lea_Lacroix_WMDE added a comment.Jul 14 2019, 9:05 PM

The ping was certainly for @Lea_WMDE :)

IKhitron added a comment.Jul 14 2019, 11:58 PM

Of course. I am terribly sorry.

Lea_Lacroix_WMDE unsubscribed.Jul 15 2019, 5:57 AM

No worries :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits