Page MenuHomePhabricator
Create Task
Maniphest T160075

Benchmark "Show changes in moved text chunks" patch, find size threshold
Closed, ResolvedPublic
Actions

Description

Benchmark the patch created for T146781. Find a reasonable maximum amount of changed paragraphs and/or diff size for displaying changes in moved blocks. Make Wikidiff2 fall back to default behaviour above that threshold so that diffs don't spend excessive amount of CPU time.

Related Objects
Search...

Event Timeline

• jkroll created this task.Mar 9 2017, 2:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2017, 2:54 PM
• jkroll added a parent task: T146781: Show changes in moved text chunks (C++).Mar 9 2017, 2:54 PM
• Lea_WMDE awarded a token.Mar 9 2017, 2:55 PM
Aklapper added a project: TCB-Team (now WMDE-TechWish).Mar 9 2017, 3:10 PM
Tobi_WMDE_SW added projects: WMDE-TechWish, MediaWiki-Page-diffs.Mar 10 2017, 2:19 PM
Tobi_WMDE_SW subscribed.
Tobi_WMDE_SW moved this task from Proposed to Sprint ready on the WMDE-TechWish board.Mar 10 2017, 2:21 PM
Tobi_WMDE_SW moved this task from Incoming to Show changes in moved text chunks on the TCB-Team (now WMDE-TechWish) board.Apr 25 2017, 10:15 AM
• Lea_WMDE added a project: Wikimedia-Hackathon-2017.May 18 2017, 8:04 PM
• Lea_WMDE moved this task from Backlog to Featured Projects on the Wikimedia-Hackathon-2017 board.
MGChecker subscribed.May 21 2017, 9:44 PM
• Lea_WMDE added a subtask: T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2.Jun 2 2017, 1:14 PM
• Lea_WMDE merged a task: T146882: Benchmark the performance of Wikidiff2 with changes for handling moved text chunks.Jun 2 2017, 1:22 PM
• Lea_WMDE added subscribers: • Lea_WMDE, Zppix, Luke081515.
Tobi_WMDE_SW moved this task from Sprint ready to Done on the WMDE-TechWish board.Jul 4 2017, 2:12 PM
Tobi_WMDE_SW moved this task from Done to Demoed on the WMDE-TechWish board.Jul 4 2017, 3:34 PM
• jkroll added a comment.Jul 4 2017, 3:36 PM

We benchmarked this and set the default to 25. The threshold is configurable in LocalSettings.

• jkroll closed this task as Resolved.Jul 4 2017, 3:36 PM
Tobi_WMDE_SW closed subtask T166571: Introduce a configuration variable for the bailout threshold for moved-paragraph-detection in wikidiff2 as Resolved.Jul 25 2017, 2:15 PM
Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits