Page MenuHomePhabricator

Modern Skin should have print-specific CSS
Closed, ResolvedPublic

Description

include commonPrint.css

The modern skin is severely broken when printing, because it doesn't include commonPrint.css (which sets styling for thumbs etc). Although some of the defines of commonPrint.css are totally useless, several others are highly critical. Since it seems that the modern/print.css was never really finished, I think that we should include commonPrint.css instead, at the very least until the modern skin is finished.


Version: unspecified
Severity: enhancement

attachment print.diff ignored as obsolete

Details

Reference
bz18779

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:38 PM
bzimport set Reference to bz18779.
bzimport added a subscriber: Unknown Object (MLST).

river wrote:

i can't reproduce any severe brokenness. please describe the problem in more detail, and if possible, provide an example of a page that demonstrates it.

I'll attach three "print to pdf" files (Of the OS X print core, not "the mediawiki PDF version"). All the same article, with monobook skin, modern skin and a "patched" modern skin.

Observe the differences in rendering of thumbs, links, TOC and the appending of href element to external links. Mostly dealt with by commonPrint.css I have no problem with Modern providing an additional print skin, but I don't see why it should ignore the "shared" one that sets some very reasonable options. There are several elements in commonPrint.css that are not used in modern (#content), but these can be fixed either later, or implemented in modern/print.css at a later time.

Please ignore the articles headers (metadata extension in place there), and underlines (which i add myself to redirect links).

Created attachment 6112
Print with Monobook skin

Attached:

Created attachment 6113
print with Modern skin

Attached:

Created attachment 6114
print with patched Modern skin

Attached:

This problem with thumbnails in printed pages of the modern skin still exist. Either my patch needs applying, or the rules for thumb styling need to be copied from commonPrint.css to modern/print.css

Why don't you apply your patches? ;)

patch is super-obsolete (Resource Loader FTW!) but the problem remains.

Comment on attachment 6110
include commonPrint.css

Obsolete, already applied (or otherwise changed as such)

This issue has been solved now.