Page MenuHomePhabricator
Create Task
Maniphest T208938

Use maven wrapper (mvnw) to build maven based project from search platform team
Closed, ResolvedPublic
Actions

Description

During investigation of unrelated issue, it was not clear which version of Maven is used by CI. Ensuring that the same version is used for local development and CI would reduce variations and help pinpoint issues. Maven Wrapper is installed for all search platform projects and takes care of downloading the correct maven version. It would be nice to use it for CI as well.

Concretely, this means using the mvnw wrapper script that is available in the root of each project repository instead of the mvn command installed on the CI host.

Details

SubjectRepoBranchLines +/-
Update Jenkins job to use latest java8 containersintegration/configmaster+7 -7
java: build maven projects with maven wrapper if it existsintegration/configmaster+39 -0
Download maven from WMF archiva repository.search/extramaster+1 -1
Download maven from WMF archiva repository.wikidata/query/rdfmaster+1 -1
Download maven from WMF archiva repository.search/highlightermaster+1 -1
Download maven from WMF archiva repository.search/extra-analysismaster+1 -1
Download maven from WMF archiva repository.wikimedia/discovery/discovery-parent-pommaster+1 -1
Download maven from WMF archiva repository.wikimedia/discovery/discovery-maven-tool-configsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Gehel created this task.Nov 7 2018, 9:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 7 2018, 9:33 AM
greg moved this task from INBOX to Backlog on the Release-Engineering-Team board.Nov 20 2018, 11:49 PM
greg edited projects, added Release-Engineering-Team (Backlog); removed Release-Engineering-Team.
Gehel closed this task as Resolved.Jan 15 2019, 6:38 PM
Gehel claimed this task.

This has been done for some time already

Gehel reopened this task as Open.Jan 15 2019, 6:39 PM

my mistake, this ticket is still ongoing, the CI part isn't done yet.

greg added a project: Continuous-Integration-Config.Jan 15 2019, 9:26 PM
TJones edited projects, added Discovery-Search; removed Discovery-Search (Current work).Jan 29 2019, 9:59 PM
TJones moved this task from needs triage to Ops / SRE on the Discovery-Search board.
gerritbot subscribed.Jan 30 2019, 10:05 PM

Change 487285 had a related patch set uploaded (by Gehel; owner: Gehel):
[integration/config@master] java: build maven projects with maven wrapper if it exists

https://gerrit.wikimedia.org/r/487285

gerritbot added a project: Patch-For-Review.Jan 30 2019, 10:05 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.Jan 30 2019, 10:07 PM
Gehel moved this task from Incoming to not in use - please delete on the Discovery-Search (Current work) board.
debt moved this task from not in use - please delete to Incoming on the Discovery-Search (Current work) board.Jan 31 2019, 10:54 PM
Gehel moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Feb 3 2019, 11:14 PM
gerritbot added a comment.Feb 6 2019, 2:27 PM

Change 488432 had a related patch set uploaded (by Gehel; owner: Gehel):
[wikimedia/discovery/discovery-parent-pom@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488432

gerritbot added a comment.Feb 6 2019, 2:29 PM

Change 488433 had a related patch set uploaded (by Gehel; owner: Gehel):
[search/extra-analysis@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488433

gerritbot added a comment.Feb 6 2019, 2:31 PM

Change 488434 had a related patch set uploaded (by Gehel; owner: Gehel):
[wikimedia/discovery/discovery-maven-tool-configs@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488434

gerritbot added a comment.Feb 6 2019, 2:35 PM

Change 488437 had a related patch set uploaded (by Gehel; owner: Gehel):
[search/extra@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488437

gerritbot added a comment.Feb 6 2019, 2:36 PM

Change 488439 had a related patch set uploaded (by Gehel; owner: Gehel):
[search/highlighter@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488439

gerritbot added a comment.Feb 6 2019, 2:38 PM

Change 488440 had a related patch set uploaded (by Gehel; owner: Gehel):
[wikidata/query/rdf@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488440

gerritbot added a comment.Feb 6 2019, 3:55 PM

Change 488434 merged by jenkins-bot:
[wikimedia/discovery/discovery-maven-tool-configs@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488434

gerritbot added a comment.Feb 6 2019, 3:55 PM

Change 488433 merged by jenkins-bot:
[search/extra-analysis@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488433

gerritbot added a comment.Feb 6 2019, 3:56 PM

Change 488432 merged by jenkins-bot:
[wikimedia/discovery/discovery-parent-pom@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488432

gerritbot added a comment.Feb 6 2019, 3:57 PM

Change 488439 merged by jenkins-bot:
[search/highlighter@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488439

Gehel mentioned this in rDMTCf5dc327cebf8: Download maven from WMF archiva repository..Feb 6 2019, 4:23 PM
Gehel mentioned this in rDMTC053a50894517: Download maven from WMF archiva repository..
Gehel mentioned this in rDPOMa59b116453fc: Download maven from WMF archiva repository..Feb 6 2019, 7:40 PM
Gehel mentioned this in rDPOMd6f84ba5afc5: Download maven from WMF archiva repository..
gerritbot added a comment.Feb 6 2019, 8:51 PM

Change 488440 merged by jenkins-bot:
[wikidata/query/rdf@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488440

gerritbot added a comment.Feb 7 2019, 8:27 AM

Change 488437 merged by Gehel:
[search/extra@master] Download maven from WMF archiva repository.

https://gerrit.wikimedia.org/r/488437

gerritbot added a comment.Mar 7 2019, 4:03 PM

Change 487285 merged by jenkins-bot:
[integration/config@master] java: build maven projects with maven wrapper if it exists

https://gerrit.wikimedia.org/r/487285

Gehel moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Mar 7 2019, 6:37 PM
hashar added a comment.Mar 7 2019, 7:16 PM

I got the images build:

docker-registry.wikimedia.org/releng/java8:0.5.0
docker-registry.wikimedia.org/releng/java8-wikidata-query-rdf:0.3.0
docker-registry.wikimedia.org/releng/java8-mjolnir:0.2.0
docker-registry.wikimedia.org/releng/java8-sonar-scanner:0.3.0
docker-registry.wikimedia.org/releng/java8-xgboost:0.2.0

Gerrit search file:mvnw gives some example repositories :]

gerritbot added a comment.Mar 7 2019, 7:29 PM

Change 495022 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Update Jenkins job to use latest java8 containers

https://gerrit.wikimedia.org/r/495022

Stashbot subscribed.Mar 8 2019, 10:04 AM

Mentioned in SAL (#wikimedia-releng) [2019-03-08T10:04:39Z] <hashar> Updating maven based jobs to latest java8 containers | https://gerrit.wikimedia.org/r/#/c/integration/config/+/495022/ | T208938

gerritbot added a comment.Mar 8 2019, 10:07 AM

Change 495022 merged by jenkins-bot:
[integration/config@master] Update Jenkins job to use latest java8 containers

https://gerrit.wikimedia.org/r/495022

hashar closed this task as Resolved.Mar 8 2019, 12:29 PM

Should be good CI wise now.

jijiki mentioned this in rDMTC2f0bc79c3183: Download maven from WMF archiva repository..Mar 18 2019, 4:38 PM
jijiki mentioned this in rDPOMd15bade1f9e6: Download maven from WMF archiva repository..Apr 5 2019, 10:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits