Page MenuHomePhabricator

Race condition: with JS disabled watchstar icon sometimes appears as filled in the page shown after successful removal
Closed, DuplicatePublic

Description

Watch star is functional to non-JS browsers on mobile and desktop.

When a user wants to remove a page from the watchlist using a javascript-disabled browser, he/she could do that using the same method as adding the page to the watchlist. Contradictorily the page that is shown after a successful removal has the watchstar filled indicating the page is still in the user's watchlist (but it isn't). This should be corrected.

This impacts both Vector AND Minerva so is an issue in core.

Screen shots

Replication Steps

(Not able to replicate)

Visit https://en.m.wikipedia.org/w/index.php?title=Spain&action=unwatch where Spain is watched

Developer notes

I've definitely seen this issue before (in Vector) and it's a race condition/caching problem and not specific to Minerva. I cannot replicate this right now...

Event Timeline

Kaartic created this task.Nov 10 2018, 11:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2018, 11:42 AM
Jdlrobson renamed this task from Non-JS watchstar icon shouldn't be filled in the page shown after successful removal to Race condition: Non-JS watchstar icon sometimes appears as filled in the page shown after successful removal.Nov 12 2018, 4:45 PM
Jdlrobson triaged this task as Low priority.
Jdlrobson edited projects, added MediaWiki-General; removed MinervaNeue.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

Was this replicated on the beta cluster by any chance? I know race conditions are far more likely to occur there.

Jdlrobson renamed this task from Race condition: Non-JS watchstar icon sometimes appears as filled in the page shown after successful removal to Race condition: with JS disabled watchstar icon sometimes appears as filled in the page shown after successful removal.Nov 12 2018, 4:47 PM

I managed to replicate this on beta cluster on Vector:

Jdlrobson updated the task description. (Show Details)Nov 12 2018, 4:48 PM

This has been an issue at least since 2010 :)

This has been an issue at least since 2010 :)

This issue dates back to a lot of years!!!