Maniphest T209213

Race condition: with JS disabled watchstar icon sometimes appears as filled in the page shown after successful removal
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Kaartic
	Nov 10 2018, 11:42 AM

Description

Watch star is functional to non-JS browsers on mobile and desktop.

When a user wants to remove a page from the watchlist using a javascript-disabled browser, he/she could do that using the same method as adding the page to the watchlist. Contradictorily the page that is shown after a successful removal has the watchstar filled indicating the page is still in the user's watchlist (but it isn't). This should be corrected.

This impacts both Vector AND Minerva so is an issue in core.

Screen shots

watchstar-filled-after-removal-non-js.png (800×480 px, 59 KB)

Replication Steps

(Not able to replicate)

Visit https://en.m.wikipedia.org/w/index.php?title=Spain&action=unwatch where Spain is watched

Developer notes

I've definitely seen this issue before (in Vector) and it's a race condition/caching problem and not specific to Minerva. I cannot replicate this right now...

Related Objects

Mentioned Here: T196893: Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8

Event Timeline

Kaartic created this task.Nov 10 2018, 11:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2018, 11:42 AM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Nov 12 2018, 4:27 PM

Was this replicated on the beta cluster by any chance? I know race conditions are far more likely to occur there.

I managed to replicate this on beta cluster on Vector:

Screen Shot 2018-11-12 at 8.46.49 AM.png (314×935 px, 46 KB)

Jdlrobson updated the task description. (Show Details)Nov 12 2018, 4:48 PM

This has been an issue at least since 2010 :)

matmarex closed this task as a duplicate of T28292: Skin should show "Watch" (not "Unwatch") tab on action=unwatch response.Nov 14 2018, 2:31 PM

In T209213#4746486, @matmarex wrote:

This has been an issue at least since 2010 :)

This issue dates back to a lot of years!!!

	F27200945: Screen Shot 2018-11-12 at 8.46.49 AM.png
	Nov 12 2018, 4:47 PM

	F27165135: watchstar-filled-after-removal-non-js.png
	Nov 10 2018, 11:42 AM

	F27200938: watch.gif
	Nov 12 2018, 4:45 PM

Race condition: with JS disabled watchstar icon sometimes appears as filled in the page shown after successful removalClosed, DuplicatePublicActions