Maniphest T196893

Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	CKoerner_WMF
	Jun 11 2018, 12:49 PM

Description

From: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Mobile_site_broke_on_Windows_Phone

After I do log in, the hamburger menu greets me by name, but the Nearby and Watchlist buttons are missing. I'd really like the Watchlist back.

Affected devices:

WinPho 8.1 + Internet Explorer
Limuia 535, Windows 10

Acceptance criteria

With JavaScript disabled, Watchlist should appear in the main menu
With JavaScript disabled, the user icon should appear in the main menu (see original report in T197824)
With JavaScript disabled, the watch star should appear and be clickable (using the workflow in screenshot below)
With JavaScript enabled, make sure it's not possible when clicking the watchstar to enter the non-JS workflow (unless the user right clicks the star).
Ensure redundant page actions CSS has been removed (e.g. https://gerrit.wikimedia.org/r/444132)

Testing steps

Test on beta cluster.

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileMenu with a grade C phone. Watchlist and login should be present and both have icons.
Click random.
Watch the article.
Visit the menu (https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileMenu ) again and click watchlist
Ensure the page watched is present in the "List" view.

Developer notes

Following user agent can be used for testing and development (example grade C browser):
"Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; NOKIA; Lumia 520)"

Related: T142527

Details

Subject	Repo	Branch	Lines +/-
Watchstar is accessible to non-js users	mediawiki/skins/MinervaNeue	master	+32 -3
Cleanup unused page actions CSS	mediawiki/skins/MinervaNeue	master	+2 -18
Watchstar uses "a" tag for consistency with other page actions	mediawiki/extensions/MobileFrontend	master	+1 -1
Show watchlist to non-JS users of Minerva	mediawiki/skins/MinervaNeue	master	+1 -1
WIP: Simplify page actions selectors	mediawiki/skins/MinervaNeue	master	+2 -16
Fix: add login icon as a server render dependency of main menu	mediawiki/skins/MinervaNeue	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T196893 Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8
		Resolved		Jdlrobson	T207480 [subtask] selenium-MinervaNeue and mwselenium-quibble-docker CI jobs failing for watchlist and watchstar

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 441933 had a related patch set uploaded (by Jdlrobson; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Fix: add login icon as a server render dependency of main menu

https://gerrit.wikimedia.org/r/441933

gerritbot added a project: Patch-For-Review.Jun 29 2018, 12:24 AM

Change 441933 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Fix: add login icon as a server render dependency of main menu

https://gerrit.wikimedia.org/r/441933

Jdlrobson removed a project: Patch-For-Review.Jun 29 2018, 5:47 PM

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 7:01 PM

• Vvjjkkii renamed this task from Restore Watchlist functionality to grade C browsers e.g. Windows Phone 8 to 29aaaaaaaa.Jul 1 2018, 1:05 AM

• Vvjjkkii removed ovasileva as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii removed subscribers: gerritbot, Aklapper.

Kaartic renamed this task from 29aaaaaaaa to Restore Watchlist functionality to grade C browsers e.g. Windows Phone 8.Jul 1 2018, 3:24 PM

Kaartic assigned this task to ovasileva.

Kaartic lowered the priority of this task from High to Medium.

Kaartic removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

Kaartic updated the task description. (Show Details)

Kaartic added subscribers: gerritbot, Aklapper.

Kaartic merged a task: T197824: Icon near user name not visible when JS is disabled.Jul 1 2018, 3:56 PM

ovasileva set the point value for this task to 3.Jul 3 2018, 4:40 PM

@alexhollender the confirmation page has only one button "Yes", and no "cancel", "go back". Also, there are no back buttons on the page, if we ask the user for confirmation, we should allow for declining the action.

Jdlrobson updated the task description. (Show Details)Jul 3 2018, 6:19 PM

@pmiazga I agree that we should have a cancel button next to the confirmation button. Although, perhaps an even better solution here would be to skip the confirmation/cancel step altogether, since I'm not sure it's necessary.

In T196893#4396020, @alexhollender wrote:

@pmiazga I agree that we should have a cancel button next to the confirmation button. Although, perhaps an even better solution here would be to skip the confirmation/cancel step altogether, since I'm not sure it's necessary.

Another task please since such a change would impact desktop too. Let's just do the most simple thing here. @Jdrewniak suggested making the watchstar a form.

Change 444132 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] WIP: Simplify page actions selectors

https://gerrit.wikimedia.org/r/444132

gerritbot added a project: Patch-For-Review.Jul 5 2018, 10:49 PM

Jdlrobson mentioned this in T136755: The main menu when viewed in Opera Mini doesn't make efficient use of the space.Jul 9 2018, 4:31 PM

Jdlrobson removed a project: Patch-For-Review.Jul 10 2018, 9:17 PM

• bmansurov unsubscribed.Jul 16 2018, 12:15 AM

Jdlrobson updated the task description. (Show Details)Jul 30 2018, 10:31 AM

Change 444132 abandoned by Jdlrobson:
WIP: Simplify page actions selectors

https://gerrit.wikimedia.org/r/444132

Jdlrobson moved this task from Upcoming to Triaged but Future on the Web-Team-Backlog board.Aug 28 2018, 9:37 PM

ovasileva moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Oct 2 2018, 9:11 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.

Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 10 2018, 5:00 PM

Jdlrobson claimed this task.Oct 10 2018, 5:05 PM

Change 465768 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Show watchlist to non-JS users of Minerva

https://gerrit.wikimedia.org/r/465768

Change 465769 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Watchstar is accessible to non-js users

https://gerrit.wikimedia.org/r/465769

Change 465770 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Cleanup unused page actions CSS

https://gerrit.wikimedia.org/r/465770

Change 465771 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Watchstar uses "a" tag for consistency with other page actions

https://gerrit.wikimedia.org/r/465771

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 10 2018, 9:31 PM

ovasileva added a project: User-notice.Oct 10 2018, 9:40 PM

phuedx unsubscribed.Oct 11 2018, 11:37 AM

@ovasileva Thank you for marking this for inclusion in Tech News. Making sure I don't misunderstanding, something like this, in very simplified terms with a link to this Phab task?

"Some old browsers can use the watchlist again. This has not worked for a while. These browsers are called [[<tvar|gradec>mw:Special:MyLanguage/Compatibility#Basic (Grade_C)</>|grade C browsers]]. This helps for example Window Phone 8.1 with Internet Explorer and Limuia 535 with Windows 10. [1]"

^ @Johan that will be correct as soon as the patches are merged. So "can use" should probably be "will soon be able"
This is also limited to the mobile site.

Change 465768 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Show watchlist to non-JS users of Minerva

https://gerrit.wikimedia.org/r/465768

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)).Oct 15 2018, 10:00 AM

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 16 2018, 6:13 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 16 2018, 10:04 PM

Johan moved this task from To Triage to Not ready to announce on the User-notice board.Oct 17 2018, 9:09 AM

Change 465771 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Watchstar uses "a" tag for consistency with other page actions

https://gerrit.wikimedia.org/r/465771

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 18 2018, 10:00 PM

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 18 2018, 11:50 PM

Jdlrobson added a subtask: T207480: [subtask] selenium-MinervaNeue and mwselenium-quibble-docker CI jobs failing for watchlist and watchstar.Oct 19 2018, 4:15 PM

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Oct 19 2018, 5:44 PM

Jdlrobson closed subtask T207480: [subtask] selenium-MinervaNeue and mwselenium-quibble-docker CI jobs failing for watchlist and watchstar as Resolved.Oct 23 2018, 5:02 PM

Change 465769 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Watchstar is accessible to non-js users

https://gerrit.wikimedia.org/r/465769

Change 465770 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Cleanup unused page actions CSS

https://gerrit.wikimedia.org/r/465770

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.2; 2018-10-30); removed MW-1.33-notes (1.33.0-wmf.1; 2018-10-23).Oct 23 2018, 9:00 PM

Jdlrobson reassigned this task from Jdlrobson to • alexhollender_WMF.Oct 23 2018, 9:35 PM

Jdlrobson moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Jdlrobson updated the task description. (Show Details)

Confirming that I am able to add pages to my watchlist using an LG Exalt phone with the Opera Mini browser.

Jdlrobson assigned this task to Ryasmeen.Nov 1 2018, 2:51 PM

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Jdlrobson added a project: Product-QA.

LGTM to me on a few platforms

Screen Shot 2018-11-06 at 4.29.42 PM.png (1×672 px, 472 KB)

Screen Shot 2018-11-06 at 4.34.56 PM.png (1×596 px, 483 KB)

Screen Shot 2018-11-06 at 4.38.43 PM.png (1×614 px, 600 KB)

Screen Shot 2018-11-06 at 4.24.21 PM.png (1×754 px, 720 KB)

Hi,

Just a few suggestions

I just tested this in my mobile (Firefox Nightly 65.0a1 for Android) browser by disabling JavaScript for that page. Adding pages to watchlist and removing them worked correctly.

But I was surprised to see that there's no obvious way to go to the article page from the page you see after successfully adding/removing an article. I had to hit back twice to go to the article page.

So, coming to the point, it would be nice to have a link back to the article page that reads 'Go to article' in the page that shows the message after successfully adding/removing an article to watchlist.
Also I noticed that the watchstar remained filled on the page that conveyed the message that the article and it's talk page have been removed from the watchlist (see screen shot). I guess it's wrong. The watch star shouldn't be filled when the message states the article has been removed from the watchlist.

Screenshot_2018-11-07-07-05-42.png (800×480 px, 61 KB)

Jdlrobson mentioned this in T208971: Non-javascript watch action flow needs a more intuitive exit/return to page strategy.Nov 7 2018, 5:58 PM

Thanks for the feedback @Kaartic I've opened T208971 !
@ovasileva can you sign off on this?

looks good

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 7 2018, 9:43 PM

Johan moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Nov 8 2018, 11:26 AM

Jdforrester-WMF renamed this task from Restore Watchlist functionality to grade C browsers e.g. Windows Phone 8 to Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8.Nov 8 2018, 7:45 PM

Jdforrester-WMF removed a project: Patch-For-Review.

Kaartic mentioned this in T209213: Race condition: with JS disabled watchstar icon sometimes appears as filled in the page shown after successful removal.Nov 10 2018, 11:42 AM

RandomDSdevel awarded a token.Nov 13 2018, 2:33 AM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Nov 15 2018, 12:18 PM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM

	F27087072: Screenshot_2018-11-07-07-05-42.png
	Nov 7 2018, 1:41 AM

	F27086667: Screen Shot 2018-11-06 at 4.34.56 PM.png
	Nov 7 2018, 12:40 AM

	F27086666: Screen Shot 2018-11-06 at 4.29.42 PM.png
	Nov 7 2018, 12:40 AM

	F27086669: Screen Shot 2018-11-06 at 4.38.43 PM.png
	Nov 7 2018, 12:40 AM

	F27086672: Screen Shot 2018-11-06 at 4.24.21 PM.png
	Nov 7 2018, 12:40 AM

	F22148316: Screen Shot 2018-06-12 at 11.06.05 AM.png
	Jun 12 2018, 6:07 PM

Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8Closed, ResolvedPublic3 Estimated Story PointsActions