Maniphest T196947

Show "keep me logged in" checkbox for users on login page without Javascript
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 11 2018, 8:27 PM

Description

From: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Mobile_site_broke_on_Windows_Phone

When a user has JavaScript enabled on a mobile device with a display less than 721px wide, we automatically mark them as "keep me logged in" and don't give them the option to untick the box.

Although this is convenient for those users with JavaScript, users without JavaScript get an annoying experience (see T196893)

Acceptance criteria

If JS is disabled I see the remember me checkbox and I can select or unselect it
If JS is enabled I do not see the remember me checkbox and it is ticked by default.

Note: Logging out will forgot users across all devices so provided a user remembers to logout there should be no need to check this checkbox.

Design

10px padding/margin between the checkbox and password field
23px padding/margin between the checkbox and the login button

QA step

Goal 1: Check no change in behaviour for modern devices

Please visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin on a mobile device
Verify that on modern iPhone / Android - there is no checkbox on the login form
Verify that on iPad the checkbox is visible.

Goal 2: Check new behaviour in old devices
We should test in as many versions of Opera Mini as possible (can we test version4?) as well as other grade C browsers such as Windows Phones, Android 2.

Please visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin on an older mobile device
Verify that the checkbox shows on a mobile device
Please test the behaviour of the checkbox on the login page. When clicking the checkbox, it should render as clicked and it should not reload the page.

Details

	Subject	Repo	Branch	Lines +/-
	Checkboxes should be styled on non-JS browsers	mediawiki/core	master	+2 -4
	Allow non-js users to remember login on grade C browsers	mediawiki/skins/MinervaNeue	master	+28 -3

Customize query in gerrit

Related Objects

Mentioned In: T196893: Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8
Mentioned Here: T196893: Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8

Event Timeline

Jdlrobson created this task.Jun 11 2018, 8:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 11 2018, 8:27 PM

I believe Windows Phone 8 has the user agent "Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; NOKIA; Lumia 520)" which makes it a grade B/C browser. Traffic is too low on this browser to upgrade it to a grade A browser.

Because JavaScript does not run, there's no way for us to automatically mark the user to have their login remembered. It's trivial for us to restore the checkbox for non-logged in users like so:

Screen Shot 2018-06-11 at 1.24.36 PM.png (556×392 px, 40 KB)

@ovasileva sound good?

Jdlrobson updated the task description. (Show Details)Jun 11 2018, 8:27 PM

Jdlrobson mentioned this in T196893: Restore mobile Watchlist functionality to grade C browsers e.g. Windows Phone 8.

In T196947#4273725, @Jdlrobson wrote:

I believe Windows Phone 8 has the user agent "Mozilla/5.0 (compatible; MSIE 10.0; Windows Phone 8.0; Trident/6.0; IEMobile/10.0; ARM; Touch; NOKIA; Lumia 520)" which makes it a grade B/C browser. Traffic is too low on this browser to upgrade it to a grade A browser.

Because JavaScript does not run, there's no way for us to automatically mark the user to have their login remembered. It's trivial for us to restore the checkbox for non-logged in users like so:

@ovasileva sound good?

Sounds good to me.

ovasileva triaged this task as Medium priority.Jun 12 2018, 3:46 PM

@Jdlrobson

10px padding/margin between the checkbox and password field
23px padding/margin between the checkbox and the login button

Jdlrobson updated the task description. (Show Details)Jun 15 2018, 8:02 PM

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Design).

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Jun 18 2018, 5:32 PM

Jdlrobson set the point value for this task to 1.Jun 19 2018, 4:18 PM

ovasileva added a project: Readers-Web-Kanbanana-Board-Old.Jun 19 2018, 4:18 PM

ovasileva moved this task from Upcoming to 2017-18 Q4 on the Web-Team-Backlog board.

As always with a 1 pointer I've found a snag.
@Volker_E looks like mediawiki.ui.checkbox does not style non-JavaScript clients.

Looking at CSS inside core this code was introduced in I0b9691daa61fddb484b6adff759f4413d201ae03 sadly without a corresponding task

// We also disable this styling on JavaScript disabled devices. This fixes the issue with
// Opera Mini where checking/unchecking doesn't apply styling but potentially leaves other
// more capable browsers with unstyled checkboxes.
.client-js .mw-ui-checkbox:not( #noop ) {

I'm tempted to drop support for older devices Opera Mini provided we can verify this works correctly on the latest version.

Change 441148 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Checkboxes should be styled on non-JS browsers

https://gerrit.wikimedia.org/r/441148

gerritbot added a project: Patch-For-Review.Jun 20 2018, 12:09 AM

Jdlrobson moved this task from Blocked on Others to Doing on the Readers-Web-Kanbanana-Board-Old board.Jun 20 2018, 6:41 PM

Change 441246 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Allow non-js users to remember login on grade C browsers

https://gerrit.wikimedia.org/r/441246

Jdlrobson moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jun 20 2018, 6:45 PM

@Niedzielski to review.

• Niedzielski updated the task description. (Show Details)Jun 25 2018, 5:54 PM

@Jdlrobson, this change looks good to me but has a big impact. Is there any deprecation policy we need to go through or is this acceptable to push through based on our compatibility matrix alone?

Nope. This can just be merged.

Change 441148 merged by jenkins-bot:
[mediawiki/core@master] Checkboxes should be styled on non-JS browsers

https://gerrit.wikimedia.org/r/441148

Change 441246 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Allow non-js users to remember login on grade C browsers

https://gerrit.wikimedia.org/r/441246

• Niedzielski moved this task from Needs Code Review to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jun 26 2018, 5:14 PM

Have added QA steps. Test on the beta cluster please (https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:UserLogin)

ovasileva added a project: User-notice.Jun 28 2018, 2:06 PM

Johan moved this task from To Triage to Not ready to announce on the User-notice board.Jun 28 2018, 2:19 PM

Passing this over to Anthony. As far as I can tell this is all set, but I don't have the necessary devices to test this properly.

• alexhollender_WMF reassigned this task from • alexhollender_WMF to ABorbaWMF.Jun 28 2018, 5:04 PM

• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.

Looks good to me on Beta. Tried a bunch of opera mini versions. It looks like Android 4.x with opera mini 28 (or older) shows the checkbox as expected. Newer versions of Opera mini (version 30+) show no checkbox even on older android, but I think that's ok too.
w/o checkbox

w/ checkbox

Looks good! Also tested in latest Opera Mini with extreme mode - checkbox appears (@ABorbaWMF - extreme mode turns javascript off for Opera mini)

ovasileva closed this task as Resolved.Jun 29 2018, 11:12 AM

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 5:02 PM

• Vvjjkkii renamed this task from Show "keep me logged in" checkbox for users on login page without Javascript to k8aaaaaaaa.Jul 1 2018, 1:04 AM

• Vvjjkkii reopened this task as Open.

• Vvjjkkii removed ABorbaWMF as the assignee of this task.

• Vvjjkkii raised the priority of this task from Medium to High.

• Vvjjkkii edited projects, added CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish); removed MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).

• Vvjjkkii updated the task description. (Show Details)

• Vvjjkkii removed the point value for this task.

• Vvjjkkii edited subscribers, added: ABorbaWMF; removed: gerritbot, Aklapper.

CommunityTechBot renamed this task from k8aaaaaaaa to Show "keep me logged in" checkbox for users on login page without Javascript.Jul 2 2018, 9:18 AM

CommunityTechBot closed this task as Resolved.

CommunityTechBot assigned this task to ABorbaWMF.

CommunityTechBot lowered the priority of this task from High to Medium.

CommunityTechBot set the point value for this task to 1.

CommunityTechBot updated the task description. (Show Details)

CommunityTechBot removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.

CommunityTechBot edited subscribers, added: gerritbot, Aklapper; removed: ABorbaWMF.

Johan moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Jul 18 2018, 1:48 PM

What is the goal here? If you just want to hide the keep logged in checkbox, that should be done in a way that works with or without Javascript (probably by checking and hiding it in the AuthChangeFormFields hook).

Trizek-WMF moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Jul 26 2018, 12:46 PM

RandomDSdevel awarded a token.Oct 1 2018, 1:21 AM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:54 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2022, 2:35 PM

	F22034573: Screen Shot 2018-06-11 at 1.24.36 PM.png
	Jun 11 2018, 8:28 PM

	F23063894: image.png
	Jun 28 2018, 11:52 PM

	F23063902: image.png
	Jun 28 2018, 11:52 PM

	F23063898: image.png
	Jun 28 2018, 11:52 PM

	F23063904: image.png
	Jun 28 2018, 11:52 PM

Show "keep me logged in" checkbox for users on login page without JavascriptClosed, ResolvedPublic1 Estimated Story PointsActions