Problem
If an Action extends Action then users who are partially blocked are also blocked from performing that action.
if ( $this->requiresUnblock() && $user->isBlocked() ) {
$block = $user->getBlock();
throw new UserBlockedError( $block );
}Solution
This should be changed to something like:
$block = $user->getBlock();
if ( $this->requiresUnblock() && $block && $block->isSitewide() ) {
throw new UserBlockedError( $block );
}| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Action::checkCanExecute should only block an Action if the user is sitewide blocked | mediawiki/core | master | +74 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | TheDJ | T190350 Epic: ⚡️ Partial blocks | |||
| Resolved | • TBolliger | T2674 Allow users to be blocked from editing a specific article or all articles inside a namespace | |||
| Resolved | • TBolliger | T208613 👩👦👦 Partial blocks complete blockers for ITWP release | |||
| Resolved | • TBolliger | T208560 If a user is partially blocked they should be able to perform rollback on unrelated pages | |||
| Resolved | • TBolliger | T208968 Partially blocked users should be able to patrol edits for other pages | |||
| Resolved | dbarratt | T209284 Action::checkCanExecute should only block an Action if the user is sitewide blocked |
Change 473024 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/core@master] Action::checkCanExecute should only block an Action if the user is sitewide blocked
Change 473024 merged by jenkins-bot:
[mediawiki/core@master] Action::checkCanExecute should only block an Action if the user is sitewide blocked