Page MenuHomePhabricator
Create Task
Maniphest T209471

HTTP 400 error "Bad geojson - unknown type ExternalData" for Maps from Wikidata query; nothing displayed
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/wiki/Help:Extension:Kartographer#GeoShapes_via_Wikidata_Query

Details

SubjectRepoBranchLines +/-
Fix: Loosen WDQS content-type header checkmaps/kartotherian/deploymaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Naveenpf created this task.Nov 14 2018, 11:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2018, 11:35 AM
Naveenpf added a comment.Nov 14 2018, 11:37 AM

All goes to blank

https://en.wikipedia.org/wiki/National_Highway_(India)#Current_system
https://en.wikipedia.org/wiki/List_of_national_parks_of_India#Map
https://en.wikipedia.org/wiki/List_of_state_highways_in_Kerala
https://ml.wikipedia.org/wiki/List_of_state_highways_in_Kerala

Aklapper renamed this task from Feature broken in Maps. Maps from Wikidata query is broken. to HTTP 400 error "Bad geojson - unknown type ExternalData" for Maps from Wikidata query; nothing displayed.Nov 14 2018, 12:42 PM
Aklapper triaged this task as Unbreak Now! priority.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptNov 14 2018, 12:42 PM
Aklapper added a comment.Nov 14 2018, 12:43 PM

The 'network' tab of your browser's Developer tools shows a HTTP400 error for https://maps.wikimedia.org/img/osm-intl,4,21,78,500x500.png?lang=en&domain=en.wikipedia.org&title=National+Highway+(India)&groups=_005fdaa798183d5cc2d67de64dc698ef69be1eff

Aklapper merged a task: T209567: GeoShapes via Wikidata Query has stopped working.Nov 15 2018, 10:07 AM
Aklapper edited projects, added Maps (Kartographer); removed Maps.
Aklapper added a subscriber: WikedKentaur.
MSantos claimed this task.Nov 15 2018, 12:16 PM
MSantos added a project: Product-Infrastructure-Team-Backlog-Deprecated (Kanban).
MSantos moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
MSantos added a comment.Nov 15 2018, 6:20 PM

WDQS is now sending an unexpected header, from this example is possible to extract this error.

It happens because geoshape service doesn't expect the header application/sparql-results+json;charset=utf-8. There is a new PR in progress but needs more tests to make sure the changes works properly on the jessie instances since we have some work related strictly to the stretch migration.

Smalyshev subscribed.Nov 15 2018, 7:50 PM

Looks like new jetty adds charset to the header but geoshapes expects exactly application/sparql-results+json. I'd probably replace exact match with startsWith or something like that.

gerritbot subscribed.Nov 15 2018, 8:04 PM

Change 473832 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[maps/kartotherian/deploy@master] Fix: Loosen WDQS content-type header check

https://gerrit.wikimedia.org/r/473832

gerritbot added a project: Patch-For-Review.Nov 15 2018, 8:04 PM
gerritbot added a comment.Nov 15 2018, 8:08 PM

Change 473832 merged by jenkins-bot:
[maps/kartotherian/deploy@master] Fix: Loosen WDQS content-type header check

https://gerrit.wikimedia.org/r/473832

Stashbot subscribed.Nov 15 2018, 8:11 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-15T20:11:19Z] <mholloway-shell@deploy1001> Started deploy [kartotherian/deploy@48a1e83]: Fix: Loosen WDQS content-type header check to unbreak maps (T209471)

Stashbot added a comment.Nov 15 2018, 8:15 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-15T20:15:45Z] <mholloway-shell@deploy1001> Finished deploy [kartotherian/deploy@48a1e83]: Fix: Loosen WDQS content-type header check to unbreak maps (T209471) (duration: 04m 26s)

Stashbot added a comment.Nov 15 2018, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-15T20:18:11Z] <mholloway-shell@deploy1001> Started deploy [kartotherian/deploy@UNKNOWN]: Fix: Loosen WDQS content-type header check to unbreak maps (T209471)

Stashbot added a comment.Nov 15 2018, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-15T20:22:06Z] <mholloway-shell@deploy1001> Finished deploy [kartotherian/deploy@UNKNOWN]: Fix: Loosen WDQS content-type header check to unbreak maps (T209471) (duration: 03m 55s)

• Mholloway lowered the priority of this task from Unbreak Now! to High.Nov 15 2018, 8:25 PM
• Mholloway subscribed.

Deployed a temporary fix and the examples above are now working. Downgrading the priority from UBN accordingly. I'll leave the ticket open until this has been fixed properly in kartotherian/geoshapes.

• Mholloway removed a project: Patch-For-Review.Nov 15 2018, 8:48 PM
• Mholloway edited projects, added Maps (Kartotherian); removed Maps (Kartographer).
Naveenpf added a comment.EditedNov 16 2018, 6:12 PM

Thank you so much WMF team !!! Presenting Wikimedia Maps tomorrow in Bangalore for SOTM Asia
http://stateofthemap.asia

• Mholloway added a comment.Nov 16 2018, 9:06 PM
In T209471#4754320, @Naveenpf wrote:

Thank you so much WMF team !!! Presenting Wikimedia Maps tomorrow in Bangalore for SOTM Asia
http://stateofthemap.asia

Awesome! Best of luck presenting!

MSantos lowered the priority of this task from High to Medium.Nov 20 2018, 4:23 PM
MSantos moved this task from Doing to Blocked on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
MSantos closed this task as Resolved.Apr 12 2019, 4:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL