Page MenuHomePhabricator
Create Task
Maniphest T210207

MFA: Port search related code to webpack
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Code relating to the search code currently lives in mobile.search and mobile.search.api, we will move it to webpack.

Acceptance criteria

  • there is no mobile.search module
  • there is no mobile.search.api
  • tests are ported to node-qunit
  • search module is contained by mobile.startup module
  • Minerva is retained in a mergeable state throughout the migration. No need to worry about cached html but an alias module (empty module with mobile.startup dependency) will be needed until references in Minerva have been updated.
  • There has been no attempt to increase code coverage. Out of scope for task.
  • The search code lives in a features folder in search a la watchstar and references

Code:

Test

Sign off steps

[X ] Progress is updated.

  • Review which features to port next and create cards.

Details

SubjectRepoBranchLines +/-
Hygiene: remove deprecated ResourceLoader search modulesmediawiki/extensions/MobileFrontendmaster+0 -31
Hygiene: consolidate mobile.search into mobile.startupmediawiki/extensions/MobileFrontendmaster+724 -716
Hygiene: collapse mobile.search templates and LESS into mobile.startupmediawiki/extensions/MobileFrontendmaster+10 -14
Hygiene: collapse mobile.search* into mobile.startupmediawiki/skins/MinervaNeuemaster+5 -5
Hygiene: collapse mobile.search LESS into mobile.startupmediawiki/skins/MinervaNeuemaster+6 -8
Hygiene: collapse mobile.search.images into mobile.startup.imagesmediawiki/extensions/MobileFrontendmaster+5 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Nov 22 2018, 10:28 PM
Restricted Application added a subscriber: • Gilles. · View Herald TranscriptNov 22 2018, 10:28 PM
Jdlrobson updated the task description. (Show Details)Nov 22 2018, 10:38 PM
Jdlrobson triaged this task as High priority.Nov 22 2018, 10:47 PM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.
• Gilles unsubscribed.Nov 23 2018, 8:52 AM
Jdlrobson renamed this task from Port search related code to webpack to MFA: Port search related code to webpack.Nov 23 2018, 11:48 PM
Jdlrobson updated the task description. (Show Details)Nov 27 2018, 5:11 PM
Jdlrobson updated the task description. (Show Details)Nov 27 2018, 5:14 PM
• Niedzielski added a subtask: T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack.Nov 27 2018, 5:15 PM
ovasileva set the point value for this task to 5.Nov 27 2018, 5:16 PM
ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.Nov 28 2018, 6:23 PM
• Niedzielski claimed this task.Nov 30 2018, 8:45 PM
• Niedzielski moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
gerritbot subscribed.Dec 6 2018, 10:46 PM

Change 478108 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] WIP: Hygiene: collapse mobile.search* into mobile.startup

https://gerrit.wikimedia.org/r/478108

gerritbot added a project: Patch-For-Review.Dec 6 2018, 10:46 PM
gerritbot added a comment.Dec 6 2018, 10:49 PM

Change 478109 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] WIP: Hygiene: collapse mobile.search* into mobile.startup

https://gerrit.wikimedia.org/r/478109

• Niedzielski added a comment.Dec 10 2018, 10:49 PM

Do we want to move extendSearchParams.js under src/mobile.startup.js/search as part of this task?

• Niedzielski removed • Niedzielski as the assignee of this task.Dec 11 2018, 7:42 PM
• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
• Niedzielski subscribed.
• Niedzielski claimed this task.Dec 11 2018, 9:24 PM
• Niedzielski moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Jdlrobson closed subtask T208921: MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack as Resolved.Dec 12 2018, 12:05 AM
gerritbot added a comment.Dec 12 2018, 9:31 PM

Change 479331 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: remove deprecated ResourceLoader modules

https://gerrit.wikimedia.org/r/479331

• Niedzielski removed • Niedzielski as the assignee of this task.Dec 12 2018, 9:32 PM
• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 13 2018, 5:36 PM
• Niedzielski claimed this task.Dec 13 2018, 6:09 PM
gerritbot added a comment.Dec 13 2018, 9:14 PM

Change 479540 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: collapse mobile.search templates and LESS into mobile.startup

https://gerrit.wikimedia.org/r/479540

gerritbot added a comment.Dec 13 2018, 9:33 PM

Change 479549 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/extensions/MobileFrontend@master] Hygiene: consolidate mobile.search into mobile.startup

https://gerrit.wikimedia.org/r/479549

• Niedzielski removed • Niedzielski as the assignee of this task.Dec 14 2018, 5:39 PM
• Niedzielski claimed this task.
• Niedzielski removed • Niedzielski as the assignee of this task.
• Niedzielski moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 14 2018, 7:00 PM
gerritbot added a comment.Dec 14 2018, 7:10 PM

Change 478108 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: collapse mobile.search.images into mobile.startup.images

https://gerrit.wikimedia.org/r/478108

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 14 2018, 8:00 PM
• Niedzielski moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 4:05 PM
• Niedzielski moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 6:05 PM
Jdlrobson moved this task from Needs Design Review to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 9:16 PM
Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 9:24 PM
gerritbot added a comment.Dec 17 2018, 9:54 PM

Change 480249 had a related patch set uploaded (by Niedzielski; owner: Stephen Niedzielski):
[mediawiki/skins/MinervaNeue@master] Hygiene: collapse mobile.search LESS into mobile.startup

https://gerrit.wikimedia.org/r/480249

gerritbot added a comment.Dec 17 2018, 10:27 PM

Change 480249 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: collapse mobile.search LESS into mobile.startup

https://gerrit.wikimedia.org/r/480249

gerritbot added a comment.Dec 17 2018, 10:36 PM

Change 479540 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: collapse mobile.search templates and LESS into mobile.startup

https://gerrit.wikimedia.org/r/479540

gerritbot added a comment.Dec 17 2018, 10:36 PM

Change 479549 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: consolidate mobile.search into mobile.startup

https://gerrit.wikimedia.org/r/479549

gerritbot added a comment.Dec 17 2018, 10:36 PM

Change 478109 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Hygiene: collapse mobile.search* into mobile.startup

https://gerrit.wikimedia.org/r/478109

Jdlrobson moved this task from Needs More Work to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 17 2018, 11:02 PM
gerritbot added a comment.Dec 17 2018, 11:15 PM

Change 479331 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hygiene: remove deprecated ResourceLoader search modules

https://gerrit.wikimedia.org/r/479331

Jdlrobson claimed this task.Dec 18 2018, 1:13 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson closed this task as Resolved.Dec 18 2018, 10:31 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

T210210 and T210209 are next!
This LGTM! Good job all!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits