Maniphest T210208

MFA: mobile.toggle migrated to webpack
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Code relating to the toggle code currently lives in mobile.toggle and we will move it to webpack.

Acceptance criteria

there is no mobile.toggle module
tests are ported to node-qunit
toggle module is contained by mobile.startup module
Minerva is retained in a mergeable state throughout the migration. No need to worry about cached html but an alias module (empty module with mobile.startup dependency) will be needed until references in Minerva have been updated.

Code:

https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/tree/master/resources/mobile.toggle

Sign off steps

Progress is updated.
Review which features to port next and create cards.

Details

Subject	Repo	Branch	Lines +/-
Remove mobile.toggle module	mediawiki/extensions/MobileFrontend	master	+0 -10
Remove references to "mobile.toggle" module.	mediawiki/skins/MinervaNeue	master	+5 -8
Port toggle.js to webpack	mediawiki/extensions/MobileFrontend	master	+843 -792

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T195475 [EPIC] Automate asset bundling in MobileFrontend
Resolved	Jdlrobson	T207787 [EPIC] Reduce the amount of modules in MobileFrontend
Resolved	Jdlrobson	T210208 MFA: mobile.toggle migrated to webpack

Event Timeline

Jdlrobson created this task.Nov 22 2018, 10:39 PM

Restricted Application added a subscriber: • Gilles. · View Herald TranscriptNov 22 2018, 10:39 PM

Jdlrobson triaged this task as High priority.Nov 22 2018, 10:47 PM

Jdlrobson moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.

Jdlrobson moved this task from Triaged but Future to Upcoming on the Web-Team-Backlog board.Nov 22 2018, 10:53 PM

• Gilles unsubscribed.Nov 23 2018, 8:52 AM

Jdlrobson renamed this task from mobile.toggle migrated to webpack to MFA: mobile.toggle migrated to webpack.Nov 23 2018, 11:48 PM

ovasileva set the point value for this task to 5.Nov 27 2018, 5:08 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2); removed Web-Team-Backlog.Nov 28 2018, 6:23 PM

Jdrewniak moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 10 2018, 10:21 AM

Jdrewniak claimed this task.Dec 11 2018, 11:34 AM

Change 479137 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/MobileFrontend@master] Port toggle.js to webpack

https://gerrit.wikimedia.org/r/479137

gerritbot added a project: Patch-For-Review.Dec 11 2018, 10:48 PM

Jdrewniak moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 11 2018, 10:57 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 12 2018, 6:16 PM

Jdrewniak moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 13 2018, 12:30 PM

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 13 2018, 5:36 PM

Change 479568 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/skins/MinervaNeue@master] Remove references to "mobile.toggle" module.

https://gerrit.wikimedia.org/r/479568

Jdlrobson moved this task from Doing to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 14 2018, 1:30 AM

Jdrewniak mentioned this in T210517: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown().Dec 14 2018, 8:55 AM

Change 479137 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Port toggle.js to webpack

https://gerrit.wikimedia.org/r/479137

Change 479568 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove references to "mobile.toggle" module.

https://gerrit.wikimedia.org/r/479568

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 14 2018, 5:01 PM

Needs more work as mobile.toggle can now be removed from extension.json \o/

Jdlrobson updated the task description. (Show Details)Dec 14 2018, 6:57 PM

Jdlrobson removed a project: Patch-For-Review.

Jdlrobson moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.Dec 14 2018, 10:00 PM

Change 479852 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove mobile.toggle module

https://gerrit.wikimedia.org/r/479852

gerritbot added a project: Patch-For-Review.Dec 14 2018, 10:04 PM

Change 479852 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Remove mobile.toggle module

https://gerrit.wikimedia.org/r/479852

Jdlrobson removed Jdrewniak as the assignee of this task.Dec 17 2018, 9:26 PM

Jdlrobson claimed this task.

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a subscriber: Jdrewniak.

Jdlrobson updated the task description. (Show Details)Dec 18 2018, 1:12 AM