Page MenuHomePhabricator
Create Task
Maniphest T210647

Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code
Closed, ResolvedPublic
Actions

Description

See discussion @ https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/476053/3/tests/parserTests.txt#31161

Most of the empty p-tags are likely edge case bugs.

Details

SubjectRepoBranchLines +/-
Bump Parsoid to 0.12.0-a17mediawiki/vendormaster+226 -285
Revert the rest of 18a98afmediawiki/services/parsoidmaster+0 -3
Bump Parsoid to v0.12.0-a15mediawiki/vendormaster+1 K -641
WIP: Quick fix for incorrect p-wrapping of table captionsmediawiki/services/parsoidmaster+5 -2
Add caption to always suppressingmediawiki/coremaster+1 -1
Add caption to always suppressingmediawiki/services/parsoidmaster+44 -28
Don't migrate out trailing non-breaking spacesmediawiki/services/parsoidmaster+1 -1
Stop matching non-breaking spaces in TokenUtils.isSolTransparentmediawiki/services/parsoidmaster+18 -10
Customize query in gerrit

Related Objects

Event Timeline

• ssastry created this task.Nov 28 2018, 7:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2018, 7:27 PM
• ssastry renamed this task from Paragraph wrapper introduces <p></p> in o utput HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code to Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code.Nov 28 2018, 7:27 PM
• ssastry triaged this task as Medium priority.
• ssastry added a comment.Nov 28 2018, 7:30 PM

This test "Empty paragraphs (marked with mw-empty-elt) found in source should not be normalized away" should be removed after this is fixed.

gerritbot subscribed.Nov 28 2018, 7:52 PM

Change 476352 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Stop matching non-breaking spaces in TokenUtils.isSolTransparent

https://gerrit.wikimedia.org/r/476352

gerritbot added a project: Patch-For-Review.Nov 28 2018, 7:52 PM
Arlolra subscribed.Nov 28 2018, 7:53 PM

There's ~80 semantic regression on https://parsoid-rt-tests.wikimedia.org/regressions/between/970751a51b4c706a0be449cdd12f6f61f35f88bb/179b04141edea6b9fc6658b891ca198c405b771f

After the above patch, it's down to 28

Arlolra claimed this task.Nov 28 2018, 7:54 PM
gerritbot added a comment.Nov 28 2018, 10:56 PM

Change 476352 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Stop matching non-breaking spaces in TokenUtils.isSolTransparent

https://gerrit.wikimedia.org/r/476352

gerritbot added a comment.Dec 4 2018, 10:03 PM

Change 477686 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Don't migrate out trailing non-breaking spaces

https://gerrit.wikimedia.org/r/477686

gerritbot added a comment.Dec 4 2018, 10:16 PM

Change 477686 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Don't migrate out trailing non-breaking spaces

https://gerrit.wikimedia.org/r/477686

Arlolra removed a project: Patch-For-Review.Dec 4 2018, 10:20 PM
Stashbot subscribed.Dec 5 2018, 9:39 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-05T21:39:08Z] <arlolra> Updated Parsoid to a6058e3 (T210647, T208360, T205333)

Stashbot mentioned this in T208360: Split Utils and DOMUtils into smaller chunks based on functionality.Dec 5 2018, 9:39 PM
Stashbot mentioned this in T205333: Eliminate circular dependencies.
Arlolra removed Arlolra as the assignee of this task.Jan 23 2019, 4:52 PM
Aklapper edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project.Feb 29 2020, 5:14 PM
Arlolra moved this task from Needs Triage to Backlog on the Parsoid board.Mar 2 2020, 3:41 PM
gerritbot added a comment.May 15 2020, 9:26 PM

Change 596761 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] WIP: Quick fix for incorrect p-wrapping of table captions

https://gerrit.wikimedia.org/r/596761

gerritbot added a project: Patch-For-Review.May 15 2020, 9:26 PM
• ssastry lowered the priority of this task from Medium to Low.May 15 2020, 9:26 PM
• ssastry moved this task from Backlog to Known Differences on the Parsoid board.
gerritbot added a comment.May 21 2020, 5:22 PM

Change 597319 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] Add caption to always suppressing

https://gerrit.wikimedia.org/r/597319

gerritbot added a comment.May 27 2020, 4:22 PM

Change 599076 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Add caption to always suppressing

https://gerrit.wikimedia.org/r/599076

gerritbot added a comment.May 27 2020, 9:00 PM

Change 597319 merged by jenkins-bot:
[mediawiki/core@master] Add caption to always suppressing

https://gerrit.wikimedia.org/r/597319

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.35; 2020-06-02).May 27 2020, 9:01 PM
gerritbot added a comment.May 27 2020, 9:12 PM

Change 599076 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add caption to always suppressing

https://gerrit.wikimedia.org/r/599076

Arlolra added a comment.May 27 2020, 9:12 PM

It seems like quite a number of cases have been covered in the above patches. I wonder if now's the time to remove the papering over and see what shakes out?

• ssastry added a comment.May 27 2020, 9:14 PM
In T210647#6170812, @Arlolra wrote:

It seems like quite a number of cases have been covered in the above patches. I wonder if now's the time to remove the papering over and see what shakes out?

A low-priority tech debt task sure.

gerritbot added a comment.May 27 2020, 9:23 PM

Change 599123 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] Revert the rest of 18a98af

https://gerrit.wikimedia.org/r/599123

gerritbot added a comment.May 28 2020, 3:00 PM

Change 596761 abandoned by Arlolra:
WIP: Quick fix for incorrect p-wrapping of table captions

Reason:
In favour of https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/ /599076

https://gerrit.wikimedia.org/r/596761

gerritbot added a comment.Jun 1 2020, 8:49 PM

Change 601428 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to v0.12.0-a15

https://gerrit.wikimedia.org/r/601428

gerritbot added a comment.Jun 2 2020, 3:56 AM

Change 601428 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to v0.12.0-a15

https://gerrit.wikimedia.org/r/601428

gerritbot added a comment.Jun 10 2020, 2:08 AM

Change 599123 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Revert the rest of 18a98af

https://gerrit.wikimedia.org/r/599123

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2020, 2:10 AM
• ssastry closed this task as Resolved.Jun 10 2020, 2:22 AM
• ssastry assigned this task to Arlolra.
gerritbot added a comment.Jun 15 2020, 9:47 PM

Change 605678 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a17

https://gerrit.wikimedia.org/r/605678

gerritbot added a project: Patch-For-Review.Jun 15 2020, 9:47 PM
gerritbot added a comment.Jun 15 2020, 10:43 PM

Change 605678 merged by jenkins-bot:
[mediawiki/vendor@master] Bump Parsoid to 0.12.0-a17

https://gerrit.wikimedia.org/r/605678

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2020, 11:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits