Page MenuHomePhabricator
Create Task
Maniphest T208360

Split Utils and DOMUtils into smaller chunks based on functionality
Closed, ResolvedPublic
Actions

Description

Utils and DOMUtils have, over time, come to encapsulate a lot of useful functionality, but where they have become large files by grouping unrelated helpers in one place. It would be useful to separate out groups of helper utilities based on functionality they support.

Details

SubjectRepoBranchLines +/-
Split utils/DOMUtils.js into separate functional unitsmediawiki/services/parsoidmaster+3 K -2 K
Move pipeline helpers from DOMUtils.js to PipelineUtils.jsmediawiki/services/parsoidmaster+455 -452
Extract parsing pipeline related utils from Util.jsmediawiki/services/parsoidmaster+230 -202
Move sole use util functions closer to use sitemediawiki/services/parsoidmaster+106 -94
Extracted token-related helpers from Util to TokenUtilsmediawiki/services/parsoidmaster+633 -585
Extract ScriptUtils from Utilsmediawiki/services/parsoidmaster+512 -490
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Oct 30 2018, 9:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 30 2018, 9:27 PM
ssastry triaged this task as Medium priority.Oct 30 2018, 9:28 PM
ssastry moved this task from Backlog to Post-Port Work on the Parsoid-PHP board.

There are 100 helpers in Util.js and ~200 helpers in DOMUtils.js which is far too many!

gerritbot subscribed.Oct 30 2018, 9:44 PM

Change 470708 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Extract ScriptUtils from Utils

https://gerrit.wikimedia.org/r/470708

gerritbot added a project: Patch-For-Review.Oct 30 2018, 9:44 PM
gerritbot added a comment.Oct 30 2018, 10:55 PM

Change 470708 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Extract ScriptUtils from Utils

https://gerrit.wikimedia.org/r/470708

gerritbot added a comment.Oct 30 2018, 11:04 PM

Change 470725 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Extracted token-related helpers from Util to TokenUtils

https://gerrit.wikimedia.org/r/470725

gerritbot added a comment.Oct 30 2018, 11:48 PM

Change 470725 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Extracted token-related helpers from Util to TokenUtils

https://gerrit.wikimedia.org/r/470725

gerritbot added a comment.Oct 31 2018, 3:33 AM

Change 470742 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Move parser functions helper to ParserFunctions.js

https://gerrit.wikimedia.org/r/470742

gerritbot added a comment.Oct 31 2018, 3:33 AM

Change 470743 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Extract parsing pipeline related utils from Util.js

https://gerrit.wikimedia.org/r/470743

gerritbot added a comment.Oct 31 2018, 4:16 AM

Change 470750 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Move pipeline helpers from DOMUtils.js to PipelineUtils.js

https://gerrit.wikimedia.org/r/470750

gerritbot added a comment.Oct 31 2018, 1:57 PM

Change 470742 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move sole use util functions closer to use site

https://gerrit.wikimedia.org/r/470742

gerritbot added a comment.Oct 31 2018, 2:18 PM

Change 470743 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Extract parsing pipeline related utils from Util.js

https://gerrit.wikimedia.org/r/470743

gerritbot added a comment.Oct 31 2018, 2:22 PM

Change 470750 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Move pipeline helpers from DOMUtils.js to PipelineUtils.js

https://gerrit.wikimedia.org/r/470750

Stashbot mentioned this in T205334: Identify and remove dead code.Nov 5 2018, 9:49 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2018-11-05T21:49:08Z] <arlolra> Updated Parsoid to 8ed698b (T205334, T208360)

Arlolra removed a project: Patch-For-Review.Nov 5 2018, 10:13 PM
gerritbot added a comment.Nov 17 2018, 6:44 PM

Change 470906 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Split utils/DOMUtils.js into separate functional units

https://gerrit.wikimedia.org/r/470906

gerritbot added a project: Patch-For-Review.Nov 17 2018, 6:44 PM
gerritbot added a comment.Dec 3 2018, 9:32 PM

Change 470906 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Split utils/DOMUtils.js into separate functional units

https://gerrit.wikimedia.org/r/470906

ssastry closed this task as Resolved.Dec 3 2018, 9:33 PM
Stashbot mentioned this in T210647: Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code.Dec 5 2018, 9:39 PM

Mentioned in SAL (#wikimedia-operations) [2018-12-05T21:39:08Z] <arlolra> Updated Parsoid to a6058e3 (T210647, T208360, T205333)

Stashbot mentioned this in T205333: Eliminate circular dependencies.Dec 5 2018, 9:39 PM
Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL