Page MenuHomePhabricator
Create Task
Maniphest T210893

Ingenico Connect hosted checkouts - using broken URL?
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Ejegg
Authored By
Ejegg
Nov 30 2018, 10:11 PM
Tags
Referenced Files
None
Subscribers
Aklapper
• DStrine
Ejegg
gerritbot
• mepps

Description

This is from our new tech contact at Ingenico:

it looks like your system was trying to access the Connect HostedCheckout page without the HostedCheckout ID. For instance, every time yours system submits a new CreateHostedCheckout API, you will get a unique redirect URL which looks similar to

'https://payment.pay2.secured-by-ingenico.com/checkout/6570-946cbfe58771406d8b915d26b0fd2ecb:f3d310bc-f3d7-424f-bcd9-a807f83ce856:a052f54caa3d4f8980837a6fd4335996'

but it looks like sometimes your system will just put 'https://payment.pay2.secured-by-ingenico.com/checkout' in the iframe which had triggered a lot of the errors that we are seeing. Can you ask your development team to double check on this?

Let's start with a bunch of logging at least.

Details

SubjectRepoBranchLines +/-
Front-end logging for Ingenico url too shortmediawiki/extensions/DonationInterfacedeployment+16 -3
Front-end logging for Ingenico url too shortmediawiki/extensions/DonationInterfacemaster+16 -3
Log an error on too-short Ingenico iframe urlmediawiki/extensions/DonationInterfacemaster+9 -0
Customize query in gerrit

Event Timeline

Ejegg created this task.Nov 30 2018, 10:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2018, 10:11 PM
• DStrine added a project: Fundraising Sprint Window dressing is mostly olive oil.Nov 30 2018, 10:13 PM
• DStrine moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
gerritbot subscribed.Nov 30 2018, 10:48 PM

Change 476984 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Log an error on too-short Ingenico iframe url

https://gerrit.wikimedia.org/r/476984

gerritbot added a project: Patch-For-Review.Nov 30 2018, 10:48 PM
gerritbot added a comment.Dec 4 2018, 5:22 PM

Change 476984 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Log an error on too-short Ingenico iframe url

https://gerrit.wikimedia.org/r/476984

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 4 2018, 6:01 PM
• DStrine added a project: Fundraising Sprint XML ate my homework.Dec 11 2018, 9:14 PM
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint XML ate my homework board.Dec 12 2018, 3:19 AM
• DStrine added a project: Fundraising Sprint A series of unfortunate event handlers.Jan 8 2019, 9:21 PM
• mepps subscribed.Jan 9 2019, 9:57 PM

I see a patch merged @Ejegg. Is this pending deployment?

Ejegg added a comment.Jan 10 2019, 5:38 PM

@mepps one patch to add logging is deployed, but we could add logging in a couple other places to catch other sorts of failures.

• DStrine added a project: Fundraising Sprint Bert and Ernie's Excellent Adventure.Jan 22 2019, 9:13 PM
• DStrine subscribed.Feb 5 2019, 9:21 PM

new DoD: someone adds some extra logging and maybe investigates this for a half day.

• DStrine added a project: Fundraising Sprint Casino Royale With Cheese.Feb 5 2019, 9:28 PM
Ejegg added a comment.Feb 9 2019, 1:20 AM

See email Re: Changes in Platform for Wikimedia Ref : ref:_00D57ri6p._5001i1yk5m:ref

Ejegg moved this task from Backlog to Doing on the Fundraising Sprint Casino Royale With Cheese board.Feb 11 2019, 2:37 PM
gerritbot added a comment.Feb 11 2019, 2:49 PM

Change 489700 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Front-end logging for Ingenico url too short

https://gerrit.wikimedia.org/r/489700

Ejegg moved this task from Doing to Review on the Fundraising Sprint Casino Royale With Cheese board.Feb 11 2019, 2:49 PM
XenoRyet moved this task from Review to Pending Deployment on the Fundraising Sprint Casino Royale With Cheese board.Feb 14 2019, 5:23 PM
gerritbot added a comment.Feb 14 2019, 5:24 PM

Change 489700 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Front-end logging for Ingenico url too short

https://gerrit.wikimedia.org/r/489700

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.18; 2019-02-19); removed MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Feb 14 2019, 6:01 PM
• DStrine added a project: Fundraising Sprint Da Vinci Coder.Feb 19 2019, 9:46 PM
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Da Vinci Coder board.Feb 20 2019, 6:12 PM
gerritbot added a comment.Mar 5 2019, 12:40 AM

Change 494397 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@deployment] Front-end logging for Ingenico url too short

https://gerrit.wikimedia.org/r/494397

gerritbot added a comment.Mar 5 2019, 12:41 AM

Change 494397 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@deployment] Front-end logging for Ingenico url too short

https://gerrit.wikimedia.org/r/494397

Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Da Vinci Coder board.Mar 5 2019, 3:23 AM
Ejegg closed this task as Resolved.Mar 5 2019, 9:15 PM
Ejegg claimed this task.

More logging added, but we haven't actually fixed the problem. Should keep looking at the error logs.

Ejegg set the point value for this task to 1.Oct 28 2019, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 28 2019, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits