Page MenuHomePhabricator

`scap prep 1.33-wmf.8` failed
Closed, InvalidPublic

Description

[zfilipin@deploy1001 ~]$ cd release/make-wmf-branch/

[zfilipin@deploy1001 make-wmf-branch (master u=)]$ git pull
Already up-to-date.

[zfilipin@deploy1001 make-wmf-branch (master u=)]$ ./make-wmf-branch -n 1.33-wmf.8 -o master
...

[zfilipin@deploy1001 make-wmf-branch (master u=)]$ cd /srv/mediawiki-staging/

[zfilipin@deploy1001 mediawiki-staging (master u=)]$ scap prep 1.33-wmf.8 
13:36:31 WARNING  - Unhandled error:
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/scap/cli.py", line 325, in run
    app = Application.factory()
  File "/usr/lib/python2.7/dist-packages/scap/cli.py", line 287, in factory
    args, extra_args = parser.parse_known_args()
  File "/usr/lib/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1942, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1898, in consume_positionals
    take_action(action, args)
  File "/usr/lib/python2.7/argparse.py", line 1807, in take_action
    action(self, namespace, argument_values, option_string)
  File "/usr/lib/python2.7/argparse.py", line 1096, in __call__
    subnamespace, arg_strings = parser.parse_known_args(arg_strings, None)
  File "/usr/lib/python2.7/argparse.py", line 1733, in parse_known_args
    namespace, args = self._parse_known_args(args, namespace)
  File "/usr/lib/python2.7/argparse.py", line 1942, in _parse_known_args
    stop_index = consume_positionals(start_index)
  File "/usr/lib/python2.7/argparse.py", line 1898, in consume_positionals
    take_action(action, args)
  File "/usr/lib/python2.7/argparse.py", line 1791, in take_action
    argument_values = self._get_values(action, argument_strings)
  File "/usr/lib/python2.7/argparse.py", line 2231, in _get_values
    value = self._get_value(action, arg_string)
  File "/usr/lib/python2.7/argparse.py", line 2260, in _get_value
    result = type_func(arg_string)
  File "/srv/mediawiki-staging/scap/plugins/prep.py", line 20, in version_parser
    return re.match(r"(1\.\d\d\.\d+-wmf\.\d+|master)", ver).group(0)
AttributeError: 'NoneType' object has no attribute 'group'
13:36:31 ERROR    - scap failed: <AttributeError> 'NoneType' object has no attribute 'group'

Event Timeline

zeljkofilipin triaged this task as Unbreak Now! priority.Dec 11 2018, 1:52 PM
zeljkofilipin created this task.
Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptDec 11 2018, 1:52 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald Transcript

Somehow I've missed .0. It should be 1.33.0-wmf.8, not 1.33-wmf.8.

zeljkofilipin closed this task as Invalid.Dec 11 2018, 1:56 PM
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptDec 11 2018, 1:56 PM

Can we delete all the 1.33-wmf.8 branches? They're cluttering up auto-completes etc..

Reedy added a subscriber: Reedy.Dec 12 2018, 8:43 PM

Can we delete all the 1.33-wmf.8 branches? They're cluttering up auto-completes etc..

I deleted it in core and vendor

git submodule foreach 'git push origin :wmf/1.33-wmf.8 || :'

Done!

Thanks and apologies for the mess.