Page MenuHomePhabricator

PHP Notice: Undefined index: 1 from line 424 of includes/http/MWHttpRequest.php:
Closed, ResolvedPublic

Description

Error

Request ID: XBQAcQpAAEEAAHz-WAYAAAAB

message
[{exception_id}] {exception_url} ErrorException from line 424 of /srv/mediawiki/php-1.33.0-wmf.8/includes/http/MWHttpRequest.php: PHP Notice: Undefined index: 1
trace
PHP Notice: Undefined index: 1

#0 /srv/mediawiki/php-1.33.0-wmf.8/includes/http/MWHttpRequest.php(424): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.33.0-wmf.8/includes/http/CurlHttpRequest.php(138): MWHttpRequest->setStatus()
#2 /srv/mediawiki/php-1.33.0-wmf.8/includes/http/Http.php(75): CurlHttpRequest->execute()
#3 /srv/mediawiki/php-1.33.0-wmf.8/includes/http/Http.php(122): Http::request(string, string, array, string)
#4 /srv/mediawiki/php-1.33.0-wmf.8/extensions/Collection/rendering/MWServeRenderingAPI.php(39): Http::post(string, array, string)
#5 /srv/mediawiki/php-1.33.0-wmf.8/extensions/Collection/rendering/CollectionRenderingAPI.php(78): MWServeRenderingAPI->makeRequest(string, array)
#6 /srv/mediawiki/php-1.33.0-wmf.8/extensions/Collection/rendering/CollectionRenderingAPI.php(55): CollectionRenderingAPI->doRender(array)
#7 /srv/mediawiki/php-1.33.0-wmf.8/extensions/Collection/Collection.body.php(1055): CollectionRenderingAPI->render(array)
#8 /srv/mediawiki/php-1.33.0-wmf.8/extensions/Collection/Collection.body.php(250): SpecialCollection->renderCollection(array, Title, string)
#9 /srv/mediawiki/php-1.33.0-wmf.8/includes/specialpage/SpecialPage.php(569): SpecialCollection->execute(NULL)
#10 /srv/mediawiki/php-1.33.0-wmf.8/includes/specialpage/SpecialPageFactory.php(558): SpecialPage->run(NULL)
#11 /srv/mediawiki/php-1.33.0-wmf.8/includes/MediaWiki.php(288): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#12 /srv/mediawiki/php-1.33.0-wmf.8/includes/MediaWiki.php(862): MediaWiki->performRequest()
#13 /srv/mediawiki/php-1.33.0-wmf.8/includes/MediaWiki.php(517): MediaWiki->main()
#14 /srv/mediawiki/php-1.33.0-wmf.8/index.php(42): MediaWiki->run()

Impact

Notes

Started yesterday (December 13) with the rollout of 1.33.0-wmf.8. Since then, observed around 4,500 times in Logstash.

Source code line 424
			list( $code, $message ) = explode( " ", $this->respStatus, 2 );

Event Timeline

Krinkle created this task.Dec 14 2018, 7:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2018, 7:25 PM

Recent changes in includes/http that may have caused this:

BPirkle claimed this task.Dec 14 2018, 9:37 PM
BPirkle triaged this task as High priority.

Change 479853 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/core@master] Fix exception on certain http failures

https://gerrit.wikimedia.org/r/479853

Change 479899 had a related patch set uploaded (by Krinkle; owner: BPirkle):
[mediawiki/core@wmf/1.33.0-wmf.8] Fix exception on certain http failures

https://gerrit.wikimedia.org/r/479899

Change 479853 merged by jenkins-bot:
[mediawiki/core@master] Fix exception on certain http failures

https://gerrit.wikimedia.org/r/479853

Change 479899 abandoned by Krinkle:
Fix exception on certain http failures

Reason:
wmf.9 is everywhere now :)

https://gerrit.wikimedia.org/r/479899

Krinkle closed this task as Resolved.Dec 20 2018, 7:21 PM
Krinkle removed a project: Patch-For-Review.