Page MenuHomePhabricator

Maintenance scripts no longer accept options
Open, Needs TriagePublic

Description

The maintenance scripts extensions/SecurePoll/cli/dump.php and extensions/SecurePoll/cli/tally.php on mwmaint1002 are broken, since the system does not recognise the empty options --votes and --html.

This means that the instructions for tallying SecurePoll elections on Wikitech no longer work.

Event Timeline

jrbs created this task.Dec 15 2018, 6:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2018, 6:31 AM
Peachey88 updated the task description. (Show Details)Dec 15 2018, 8:42 AM

This seems to be a chronic problem at least with SecurePoll scripts, most of them have some variation of an empty option. makeSimpleList.php gave me problems earlier because I needed to use one and so instead I had to copy it to my home directory and edit it (basically adding it as an option with an argument/not empty) and then I could get it to work. Not sure if this is an issue with mwscript or internal ways with how maintenance scripts are checked but it wasn't this was at least last year. We were able to find workarounds for this election but had to include manually inserting the key into the DB etc so would be good to either update the scripts or figure out what's up with the wrappers.

Reedy added a subscriber: Reedy.Dec 15 2018, 1:44 PM

I guess most of them need rewriting to use the proper maintenance script wrappers...

Reedy added a comment.Dec 15 2018, 1:50 PM

Are you running it with mwscript extensions/SecurePoll/cli/dump.php --wiki=foowiki --options?

Change 479884 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert tally.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479884

Change 479887 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert dump.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479887

Change 479893 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert dumpComments.php and dumpVoteCsv.php

https://gerrit.wikimedia.org/r/479893

Change 479894 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert convertVotes.php

https://gerrit.wikimedia.org/r/479894

Change 479895 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert dumpGlobalVoterList.php

https://gerrit.wikimedia.org/r/479895

Change 479896 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert delete.php

https://gerrit.wikimedia.org/r/479896

Change 479897 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert makeSimpleList.php

https://gerrit.wikimedia.org/r/479897

Change 479900 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert import.php

https://gerrit.wikimedia.org/r/479900

Are you running it with mwscript extensions/SecurePoll/cli/dump.php --wiki=foowiki --options?

Yeah, we are, thank you for all of the patches :)

Change 479897 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert makeSimpleList.php

https://gerrit.wikimedia.org/r/479897

Change 479887 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert dump.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479887

Change 479894 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert convertVotes.php

https://gerrit.wikimedia.org/r/479894

Change 479896 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert delete.php

https://gerrit.wikimedia.org/r/479896

Change 479895 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert dumpGlobalVoterList.php

https://gerrit.wikimedia.org/r/479895

Change 479884 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert tally.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479884

Change 479893 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert dumpComments.php and dumpVoteCsv.php

https://gerrit.wikimedia.org/r/479893

Change 479900 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert import.php

https://gerrit.wikimedia.org/r/479900