Page MenuHomePhabricator
Create Task
Maniphest T212027

Maintenance scripts no longer accept options
Closed, ResolvedPublic
Actions

Description

The maintenance scripts extensions/SecurePoll/cli/dump.php and extensions/SecurePoll/cli/tally.php on mwmaint1002 are broken, since the system does not recognise the empty options --votes and --html.

This means that the instructions for tallying SecurePoll elections on Wikitech no longer work.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/SecurePollmaster+257 -262Convert import.php
mediawiki/extensions/SecurePollmaster+108 -101Convert dumpComments.php and dumpVoteCsv.php
mediawiki/extensions/SecurePollmaster+58 -50Convert tally.php to be a proper MW maintenance script
mediawiki/extensions/SecurePollmaster+70 -51Convert dumpGlobalVoterList.php
mediawiki/extensions/SecurePollmaster+77 -75Convert delete.php
mediawiki/extensions/SecurePollmaster+35 -39Convert convertVotes.php
mediawiki/extensions/SecurePollmaster+80 -73Convert dump.php to be a proper MW maintenance script
mediawiki/extensions/SecurePollmaster+112 -121Convert makeSimpleList.php
Customize query in gerrit

Related Objects

Event Timeline

jrbs created this task.Dec 15 2018, 6:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2018, 6:31 AM
jrbs added a project: MediaWiki-Maintenance-system.Dec 15 2018, 6:31 AM
Peachey88 updated the task description. (Show Details)Dec 15 2018, 8:42 AM
Jalexander added a comment.Dec 15 2018, 9:10 AM

This seems to be a chronic problem at least with SecurePoll scripts, most of them have some variation of an empty option. makeSimpleList.php gave me problems earlier because I needed to use one and so instead I had to copy it to my home directory and edit it (basically adding it as an option with an argument/not empty) and then I could get it to work. Not sure if this is an issue with mwscript or internal ways with how maintenance scripts are checked but it wasn't this was at least last year. We were able to find workarounds for this election but had to include manually inserting the key into the DB etc so would be good to either update the scripts or figure out what's up with the wrappers.

jrbs added a project: MediaWiki-extensions-SecurePoll.Dec 15 2018, 9:11 AM
Reedy added a subscriber: Reedy.Dec 15 2018, 1:44 PM

I guess most of them need rewriting to use the proper maintenance script wrappers...

Reedy added a comment.Dec 15 2018, 1:50 PM

Are you running it with mwscript extensions/SecurePoll/cli/dump.php --wiki=foowiki --options?

gerritbot added a subscriber: gerritbot.Dec 15 2018, 2:06 PM

Change 479884 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert tally.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479884

gerritbot added a project: Patch-For-Review.Dec 15 2018, 2:06 PM
gerritbot added a comment.Dec 15 2018, 2:21 PM

Change 479887 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert dump.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479887

gerritbot added a comment.Dec 15 2018, 3:00 PM

Change 479893 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert dumpComments.php and dumpVoteCsv.php

https://gerrit.wikimedia.org/r/479893

gerritbot added a comment.Dec 15 2018, 3:49 PM

Change 479894 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert convertVotes.php

https://gerrit.wikimedia.org/r/479894

gerritbot added a comment.Dec 15 2018, 3:54 PM

Change 479895 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert dumpGlobalVoterList.php

https://gerrit.wikimedia.org/r/479895

gerritbot added a comment.Dec 15 2018, 4:03 PM

Change 479896 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert delete.php

https://gerrit.wikimedia.org/r/479896

gerritbot added a comment.Dec 15 2018, 4:15 PM

Change 479897 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert makeSimpleList.php

https://gerrit.wikimedia.org/r/479897

gerritbot added a comment.Dec 15 2018, 4:35 PM

Change 479900 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/SecurePoll@master] Convert import.php

https://gerrit.wikimedia.org/r/479900

Jalexander added a comment.Dec 15 2018, 8:53 PM
In T212027#4825469, @Reedy wrote:

Are you running it with mwscript extensions/SecurePoll/cli/dump.php --wiki=foowiki --options?

Yeah, we are, thank you for all of the patches :)

gerritbot added a comment.Dec 15 2018, 10:51 PM

Change 479897 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert makeSimpleList.php

https://gerrit.wikimedia.org/r/479897

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Dec 15 2018, 11:00 PM
gerritbot added a comment.Dec 15 2018, 11:06 PM

Change 479887 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert dump.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479887

gerritbot added a comment.Dec 15 2018, 11:13 PM

Change 479894 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert convertVotes.php

https://gerrit.wikimedia.org/r/479894

gerritbot added a comment.Dec 16 2018, 4:01 AM

Change 479896 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert delete.php

https://gerrit.wikimedia.org/r/479896

gerritbot added a comment.Dec 16 2018, 4:02 AM

Change 479895 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert dumpGlobalVoterList.php

https://gerrit.wikimedia.org/r/479895

gerritbot added a comment.Dec 16 2018, 4:06 AM

Change 479884 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert tally.php to be a proper MW maintenance script

https://gerrit.wikimedia.org/r/479884

gerritbot added a comment.Dec 16 2018, 4:09 AM

Change 479893 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert dumpComments.php and dumpVoteCsv.php

https://gerrit.wikimedia.org/r/479893

gerritbot added a comment.Feb 14 2019, 8:13 AM

Change 479900 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Convert import.php

https://gerrit.wikimedia.org/r/479900

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.18; 2019-02-19); removed MW-1.33-notes (1.33.0-wmf.9; 2018-12-18).Feb 14 2019, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 1:41 PM
Reedy closed this task as Resolved.Dec 6 2019, 8:03 PM
Reedy claimed this task.

Dejavu T239968: `cli/dump.php` does not accept the --votes modifier

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL