Page MenuHomePhabricator

Fold the reference section when containing a non-mandatory constraint
Open, Needs TriagePublic

Description

Currently, when a reference contains a constraint violation, the section is unfolded, in order to help the community seeing the problem and fixing the reference or the constraint.

When the constraint is not fixed for some reason (non-mandatory constraint, exception, disagreement between editors), the reference section would stay unfolded, making the reading and editing experience more difficult.

A suggestion would be to make the difference between mandatory and non-mandatory constraints: when a reference section contains only non-mandatory constraint(s), it could stay folded.

Follows this discussion: References_not_to_displayed_unfolded (Dec 2018)

Event Timeline

So, here's the idea: we add in the code a way to identify the level of the constraints (mandatory or not). Then, people can add a line in their common.js to hide the non-mandatory constraints if they want to. We would also write this line for them. @Lucas_Werkmeister_WMDE Does it correctly summarize what we discussed about?

From my side this is fine.
One thing to keep in mind is that we want to add a new level for suggestions so it should probably not be indicating mandatory or not but specify which of the three it is.

Also if we do this we should probably do this not just on reference but also for main snak and qualifiers.

Also if we do this we should probably do this not just on reference but also for main snak and qualifiers.

I thought this task wasn’t about hiding constraints, just about not expanding the reference section?

Yes, the end result should be to have the references section folded.