Page MenuHomePhabricator
Create Task
Maniphest T212797

Warning: Missing ipb_reason_text and ipb_reason_data fields in row with
Closed, ResolvedPublic
Actions

Description

Setup

  • MediaWiki 1.32.0-rc.1 (92ea1ec) 22:07, 27 December 2018
  • PHP 7.0.33-0+deb9u1 (apache2handler)
  • MariaDB 10.1.37-MariaDB-0+deb9u1
  • UserMerge 1.10.1 (891619a) 22:22, 1 January 2019

Issue
Then performing a user merge I get the following warning:

Warning: Missing ipb_reason_text and ipb_reason_data fields in row with MIGRATION_OLD [Called from CommentStore::getCommentInternal in /../w/includes/CommentStore.php at line 285] in /../w/includes/debug/MWDebug.php on line 309

Since I am not sure what is causing this issue I added all possible applicable tags. Please remove as see fit.

Details

SubjectRepoBranchLines +/-
Replace '*' query with DatabaseBlock::getQueryInfo()mediawiki/extensions/UserMergeREL1_33+7 -3
Replace '*' query with DatabaseBlock::getQueryInfo()mediawiki/extensions/UserMergemaster+7 -3
Customize query in gerrit

Related Objects

Event Timeline

Kghbln created this task.Jan 2 2019, 6:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2019, 6:35 PM
Marostegui added a subscriber: Anomie.Jan 3 2019, 6:42 AM
Legoktm moved this task from Backlog to Extensions on the MW-1.32-release board.Jan 3 2019, 6:32 PM
Krinkle moved this task from Untriaged to Usage problem on the MediaWiki-libs-Rdbms board.Apr 3 2019, 3:01 AM
Krinkle subscribed.Jul 18 2019, 8:06 PM

Which component is the error coming from? A special page? (which one), an API request (which one), etc.

Krinkle edited projects, added Wikimedia-database-issue, MW-1.33-release, MediaWiki-User-management; removed MediaWiki-libs-Rdbms.Jul 18 2019, 8:06 PM
Krinkle moved this task from Backlog to User blocking on the MediaWiki-User-management board.
Kghbln added a comment.Jul 18 2019, 8:12 PM
In T212797#5347569, @Krinkle wrote:

Which component is the error coming from? A special page? (which one), an API request (which one), etc.

Caused by using "Special:UserMerge". I cannot tell if this one is calling the API at one stage or not to do its job.

Krinkle removed a project: MediaWiki-User-management.Jul 18 2019, 8:13 PM
Anomie edited projects, added Platform Team Workboards (Clinic Duty Team); removed Wikimedia-database-issue.Jul 19 2019, 2:42 PM
Anomie moved this task from Inbox to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.
gerritbot added a comment.Jul 19 2019, 2:42 PM

Change 524530 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/UserMerge@master] Replace '*' query with DatabaseBlock::getQueryInfo()

https://gerrit.wikimedia.org/r/524530

gerritbot added a project: Patch-For-Review.Jul 19 2019, 2:42 PM
Anomie claimed this task.Jul 23 2019, 4:14 PM
gerritbot added a comment.Jul 24 2019, 1:53 AM

Change 524530 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Replace '*' query with DatabaseBlock::getQueryInfo()

https://gerrit.wikimedia.org/r/524530

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 24 2019, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2019, 2:10 AM
Anomie closed this task as Resolved.Jul 24 2019, 1:45 PM
Anomie moved this task from Waiting for Review to EM Sign Off on the Platform Team Workboards (Clinic Duty Team) board.

This is now fixed in the master branch of MediaWiki-extensions-UserMerge. If you're using an older release version, you should be able to backport the patch.

Kghbln added a comment.EditedJul 24 2019, 1:55 PM

This is now fixed in the master branch of

You are cool! Thanks for the effort! Much appreciated!!! :)

If you're using an older release version, you should be able to backport the patch.

Since it only started with MW 1.33 a backport to REL_1_33 should do the trick. I will cherry-pick right now!

gerritbot added a comment.Jul 24 2019, 1:55 PM

Change 525286 had a related patch set uploaded (by Kghbln; owner: Anomie):
[mediawiki/extensions/UserMerge@REL1_33] Replace '*' query with DatabaseBlock::getQueryInfo()

https://gerrit.wikimedia.org/r/525286

gerritbot added a project: Patch-For-Review.Jul 24 2019, 1:56 PM
gerritbot added a comment.Jul 25 2019, 4:06 PM

Change 525286 merged by Jforrester:
[mediawiki/extensions/UserMerge@REL1_33] Replace '*' query with DatabaseBlock::getQueryInfo()

https://gerrit.wikimedia.org/r/525286

Kghbln removed a project: Patch-For-Review.Jul 25 2019, 4:08 PM

Cool. Thanks a ton. You rock!

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits