Page MenuHomePhabricator

[Regression pre-wmf.12] Insert button stays disabled while trying to add a gallery
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open VE and go to Insert>Gallery
  2. Select an image or two.

The Insert button stays disabled.

Event Timeline

Ryasmeen created this task.Jan 2 2019, 8:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 2 2019, 8:35 PM

Change 482037 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Default originalGalleryGroupItems to empty array

https://gerrit.wikimedia.org/r/482037

Esanders claimed this task.Jan 3 2019, 3:13 PM
Esanders triaged this task as High priority.
Esanders edited projects, added VisualEditor (Current work); removed VisualEditor.
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.

Change 482037 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Default originalGalleryGroupItems to empty array

https://gerrit.wikimedia.org/r/482037

My bad. Thanks for catching and fixing this!

(The bug was in 79e16e218f4700ae8d14b6022b4c269c32fba0a8 and not included in any release yet, so no backports needed.)

matmarex renamed this task from [Regression pre-wmf.8] Insert button stays disabled while trying to add a gallery to [Regression pre-wmf.12] Insert button stays disabled while trying to add a gallery.Jan 3 2019, 5:37 PM
marcella closed this task as Resolved.Jan 8 2019, 9:44 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 8 2019, 9:44 PM