the user should land back on the same page after they complete the login.

This part is ready for review: https://github.com/wikimedia/svgtranslate/pull/71

In case they had multiple in-progress translations, preserve translations for all of those.

Does this include switching to and from other To languages (i.e. without reloading the page)? I've been assuming it does, but that may be wrong (I think we did talk about not doing that a while ago).

In T213045#4963461, @Samwilson wrote:

the user should land back on the same page after they complete the login.

This part is ready for review: https://github.com/wikimedia/svgtranslate/pull/71

In case they had multiple in-progress translations, preserve translations for all of those.

Does this include switching to and from other To languages (i.e. without reloading the page)? I've been assuming it does, but that may be wrong (I think we did talk about not doing that a while ago).

@Samwilson I meant if they had multiple tabs open with the tool and were in the process of translating multiple files. Switching between multiple To languages should not preserve translations. We should discard existing translations when they decide to change the language (which is what we have the popup for).
Is this clearer?

I meant if they had multiple tabs open with the tool and were in the process of translating multiple files. Switching between multiple To languages should not preserve translations. We should discard existing translations when they decide to change the language (which is what we have the popup for).
Is this clearer?

Yep! That makes sense. Thanks.

WIP for the rest of this ticket: https://github.com/wikimedia/svgtranslate/pull/70

I was too hasty above with "rest of this"... but a chunk more has been done and is ready for QA: the From and To languages should be correctly remembered when you login or close the window.

I'd like to get this part QA'd (it's now live on the staging site) before going on with the message form inputs themselves, in case there's some structural problem.

@Samwilson This works well for me. The languages seem to be correctly remembered as they should.
Let's get the rest of this done.

PR for saving translations: https://github.com/wikimedia/svgtranslate/pull/104 (WIP)

I did a rudimentary test on this and it seems to work fine.

Requirements

• If a user navigates away (or their tab crashes etc) from the translate tab in the middle of adding translations, their translations for the image should be temporarily preserved (15 minutes is good enough). In case they had multiple in-progress translations, preserve translations for all of those.

It is my understanding that the tool only stores partial translations for one file/tab at a time, the one you have most recently worked on. If you have multiple translations in progress, closing or navigating away (incl. logging in) from a tab you have not recently used will lose your unsaved translation.

We may need to recommend users not translate more than one file at a time, or use different browsers for each file.

EDIT: In fact, the local storage is shared across tabs, so if you have two translations on the go you may find translations you do on one tab appearing in the other (if you, for example, refresh the page). Or, if you translate one image after another, the translations for the previous image can appear in the current image.

In T213045#5137325, @dom_walden wrote:

Requirements

• If a user navigates away (or their tab crashes etc) from the translate tab in the middle of adding translations, their translations for the image should be temporarily preserved (15 minutes is good enough). In case they had multiple in-progress translations, preserve translations for all of those.

It is my understanding that the tool only stores partial translations for one file/tab at a time, the one you have most recently worked on. If you have multiple translations in progress, closing or navigating away (incl. logging in) from a tab you have not recently used will lose your unsaved translation.

We may need to recommend users not translate more than one file at a time, or use different browsers for each file.

Gotcha. I can live with only being able to have one translation in progress at a time. I will add that to the documentation.

@dom_walden Dropping this in the QA column for you in case there's any further QA work you want to do here. :) Thank you!

Commits linked to this task have been released in svgtranslate 0.9.0.

In T213045#5154724, @Niharika wrote:

@dom_walden Dropping this in the QA column for you in case there's any further QA work you want to do here. :) Thank you!

I have nothing else to add. I raised bug T223380 for:

In T213045#5137325, @dom_walden wrote:

...if you translate one image after another, the translations for the previous image can appear in the current image.

as that affects users who are translating one image after another.