Maniphest T213474

Port talk code to webpack
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Code relating to the talk feature currently lives in 'mobile.talk.overlays and we will move it to webpack.

Similar to the language feature it is lazy loaded.

Acceptance criteria

code for mobile.talk.overlays module compiled in webpack
code for mobile.talk.overlays is not loaded on the critical path - it is delayed until an image is clicked (see also T210210)
critical js size (mobile.startup.js + mobile.common.js) has not increased. Beware of any modules that are shared among the lazy loaded chunks and are not in mobile.startup.js. Webpack will excise these into mobile.common.js and increase our critical js size.
tests are ported to node-qunit (tests/qunit/mobile.talk.overlays)
Minerva is retained in a mergeable state throughout the migration. No need to worry about cached html but an alias module (empty module with mobile.startup dependency) will be needed if any module renames happen until references in Minerva have been updated.

Code:

Sign off steps

[x ] Progress is updated.

Details

	Subject	Repo	Branch	Lines +/-
	Port talk code to webpack	mediawiki/extensions/MobileFrontend	master	+939 -894

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
		Resolved		Jdlrobson	T195475 [EPIC] Automate asset bundling in MobileFrontend
		Resolved		Jdlrobson	T207787 [EPIC] Reduce the amount of modules in MobileFrontend
		Resolved		Jdrewniak	T213474 Port talk code to webpack

Event Timeline

Jdlrobson triaged this task as High priority.Jan 10 2019, 7:35 PM

Jdlrobson created this task.

Jdlrobson mentioned this in T207787: [EPIC] Reduce the amount of modules in MobileFrontend.Jan 10 2019, 7:38 PM

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

ovasileva set the point value for this task to 3.Jan 15 2019, 5:33 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Web-Team-Backlog.

• nray claimed this task.Jan 17 2019, 8:13 PM

• nray moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Change 485130 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Port talk code to webpack

https://gerrit.wikimedia.org/r/485130

gerritbot added a project: Patch-For-Review.Jan 18 2019, 12:06 AM

• nray moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 18 2019, 12:08 AM

Change 485130 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Port talk code to webpack

https://gerrit.wikimedia.org/r/485130

Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 18 2019, 12:57 AM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 18 2019, 1:00 AM

Jdlrobson updated the task description. (Show Details)Jan 18 2019, 1:15 AM

• nray removed • nray as the assignee of this task.Jan 18 2019, 4:56 PM

• nray subscribed.

Jdrewniak claimed this task.Jan 22 2019, 12:47 PM

Jdrewniak closed this task as Resolved.Jan 23 2019, 11:45 AM

Jdrewniak updated the task description. (Show Details)